From: David Matlack <dmatlack@google.com>
To: Colton Lewis <coltonlewis@google.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, maz@kernel.org,
seanjc@google.com, oupton@google.com, ricarkol@google.com
Subject: Re: [PATCH 2/3] KVM: selftests: Randomize which pages are written vs read
Date: Wed, 10 Aug 2022 16:37:47 -0700 [thread overview]
Message-ID: <YvRBS5ZJ/kx92TnC@google.com> (raw)
In-Reply-To: <YvRAWKGXbPzool6j@google.com>
On Wed, Aug 10, 2022 at 04:33:44PM -0700, David Matlack wrote:
> On Wed, Aug 10, 2022 at 05:58:29PM +0000, Colton Lewis wrote:
> > Randomize which pages are written vs read by using the random number
>
> Same thing here about stating what the patch does first.
Sorry -- you do state what the patch does first here. But I think it
could just be a little more direct and specific. e.g.
Replace the -f<fraction> option in dirty_log_perf_test.c with
-w<percent>, to allow the user to specify the percentage of which
pages are written.
>
> > table for each page modulo 100. This changes how the -w argument
> > works. It is now a percentage from 0 to 100 inclusive that represents
> > what percentage of accesses are writes. It keeps the same default of
> > 100 percent writes.
next prev parent reply other threads:[~2022-08-10 23:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 17:58 [PATCH 0/3] KVM: selftests: Randomize memory access of dirty_log_perf_test Colton Lewis
2022-08-10 17:58 ` [PATCH 1/3] KVM: selftests: Add random table to randomize memory access Colton Lewis
2022-08-10 23:18 ` David Matlack
2022-08-10 23:26 ` David Matlack
2022-08-12 16:09 ` Colton Lewis
2022-08-10 17:58 ` [PATCH 2/3] KVM: selftests: Randomize which pages are written vs read Colton Lewis
2022-08-10 23:33 ` David Matlack
2022-08-10 23:37 ` David Matlack [this message]
2022-08-12 16:11 ` Colton Lewis
2022-08-10 17:58 ` [PATCH 3/3] KVM: selftests: Randomize page access order Colton Lewis
2022-08-10 23:49 ` David Matlack
2022-08-12 16:24 ` Colton Lewis
2022-08-12 16:28 ` David Matlack
2022-08-12 16:40 ` Colton Lewis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvRBS5ZJ/kx92TnC@google.com \
--to=dmatlack@google.com \
--cc=coltonlewis@google.com \
--cc=kvm@vger.kernel.org \
--cc=maz@kernel.org \
--cc=oupton@google.com \
--cc=pbonzini@redhat.com \
--cc=ricarkol@google.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.