From: Wolfram Sang <wsa@kernel.org>
To: Robin Reckmann <robin.reckmann@googlemail.com>
Cc: "Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Konrad Dybcio" <konrad.dybcio@somainline.org>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
"Robin Reckmann" <robin.reckmann@gmail.com>,
linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH] i2c: qcom-geni: Fix GPI DMA buffer sync-back
Date: Thu, 11 Aug 2022 14:14:47 +0200 [thread overview]
Message-ID: <YvTyt4nmOZqQYSCa@shikoro> (raw)
In-Reply-To: <20220807140455.409417-1-robin.reckmann@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 650 bytes --]
On Sun, Aug 07, 2022 at 11:04:54PM +0900, Robin Reckmann wrote:
> Fix i2c transfers using GPI DMA mode for all message types that do not set
> the I2C_M_DMA_SAFE flag (e.g. SMBus "read byte").
>
> In this case a bounce buffer is returned by i2c_get_dma_safe_msg_buf(),
> and it has to synced back to the message after the transfer is done.
>
> Add missing assignment of dma buffer in geni_i2c_gpi().
>
> Set xferred in i2c_put_dma_safe_msg_buf() to true in case of no error to
> ensure the sync-back of this dma buffer to the message.
>
> Signed-off-by: Robin Reckmann <robin.reckmann@gmail.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@kernel.org>
To: Robin Reckmann <robin.reckmann@googlemail.com>
Cc: linux-arm-msm@vger.kernel.org,
"Konrad Dybcio" <konrad.dybcio@somainline.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
"Sumit Semwal" <sumit.semwal@linaro.org>,
linaro-mm-sig@lists.linaro.org, "Andy Gross" <agross@kernel.org>,
linux-i2c@vger.kernel.org,
"Robin Reckmann" <robin.reckmann@gmail.com>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH] i2c: qcom-geni: Fix GPI DMA buffer sync-back
Date: Thu, 11 Aug 2022 14:14:47 +0200 [thread overview]
Message-ID: <YvTyt4nmOZqQYSCa@shikoro> (raw)
In-Reply-To: <20220807140455.409417-1-robin.reckmann@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 650 bytes --]
On Sun, Aug 07, 2022 at 11:04:54PM +0900, Robin Reckmann wrote:
> Fix i2c transfers using GPI DMA mode for all message types that do not set
> the I2C_M_DMA_SAFE flag (e.g. SMBus "read byte").
>
> In this case a bounce buffer is returned by i2c_get_dma_safe_msg_buf(),
> and it has to synced back to the message after the transfer is done.
>
> Add missing assignment of dma buffer in geni_i2c_gpi().
>
> Set xferred in i2c_put_dma_safe_msg_buf() to true in case of no error to
> ensure the sync-back of this dma buffer to the message.
>
> Signed-off-by: Robin Reckmann <robin.reckmann@gmail.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-08-11 12:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-07 14:04 [PATCH] i2c: qcom-geni: Fix GPI DMA buffer sync-back Robin Reckmann
2022-08-07 14:04 ` Robin Reckmann
2022-08-07 15:31 ` Caleb Connolly
2022-08-07 15:31 ` Caleb Connolly
2022-08-08 5:54 ` Wolfram Sang
2022-08-08 5:54 ` Wolfram Sang
2022-08-08 13:38 ` Robin Reckmann
2022-08-08 6:59 ` Luca Weiss
2022-08-08 6:59 ` Luca Weiss
2022-08-08 11:46 ` Konrad Dybcio
2022-08-08 11:46 ` Konrad Dybcio
2022-08-11 12:14 ` Wolfram Sang [this message]
2022-08-11 12:14 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvTyt4nmOZqQYSCa@shikoro \
--to=wsa@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=konrad.dybcio@somainline.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=robin.reckmann@gmail.com \
--cc=robin.reckmann@googlemail.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.