All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Siddh Raman Pant <code@siddh.me>
Cc: netdev <netdev@vger.kernel.org>,
	syzbot+6cb476b7c69916a0caca
	<syzbot+6cb476b7c69916a0caca@syzkaller.appspotmail.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	syzbot+f9acff9bf08a845f225d
	<syzbot+f9acff9bf08a845f225d@syzkaller.appspotmail.com>,
	eric dumazet <edumazet@google.com>,
	syzbot+9250865a55539d384347
	<syzbot+9250865a55539d384347@syzkaller.appspotmail.com>,
	jakub kicinski <kuba@kernel.org>,
	johannes berg <johannes@sipsolutions.net>,
	paolo abeni <pabeni@redhat.com>,
	linux-kernel-mentees
	<linux-kernel-mentees@lists.linuxfoundation.org>,
	"david s. miller" <davem@davemloft.net>
Subject: Re: [PATCH v2] wifi: cfg80211: Fix UAF in ieee80211_scan_rx()
Date: Fri, 12 Aug 2022 17:27:58 +0200	[thread overview]
Message-ID: <YvZxfpY4JUqvsOG5@kroah.com> (raw)
In-Reply-To: <18292791718.88f48d22175003.6675210189148271554@siddh.me>

On Fri, Aug 12, 2022 at 08:03:05PM +0530, Siddh Raman Pant wrote:
> On Fri, 12 Aug 2022 17:45:58 +0530  Greg KH  wrote:
> > The merge window is for new features to be added, bugfixes can be merged
> > at any point in time, but most maintainers close their trees until after
> > the merge window is closed before accepting new fixes, like this one.
> > 
> > So just relax, wait another week or so, and if there's no response,
> > resend it then.
> > 
> 
> Okay, sure.
> 
> > Personally, this patch seems very incorrect, but hey, I'm not the wifi
> > subsystem maintainer :)
> 
> Why do you think so?

rcu just delays freeing of an object, you might just be delaying the
race condition.  Just moving a single object to be freed with rcu feels
very odd if you don't have another reference somewhere.

Anyway, I don't know this codebase, so I could be totally wrong.

greg k-h
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Siddh Raman Pant <code@siddh.me>
Cc: johannes berg <johannes@sipsolutions.net>,
	"david s. miller" <davem@davemloft.net>,
	eric dumazet <edumazet@google.com>,
	jakub kicinski <kuba@kernel.org>, paolo abeni <pabeni@redhat.com>,
	netdev <netdev@vger.kernel.org>,
	syzbot+6cb476b7c69916a0caca 
	<syzbot+6cb476b7c69916a0caca@syzkaller.appspotmail.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	syzbot+f9acff9bf08a845f225d 
	<syzbot+f9acff9bf08a845f225d@syzkaller.appspotmail.com>,
	syzbot+9250865a55539d384347 
	<syzbot+9250865a55539d384347@syzkaller.appspotmail.com>,
	linux-kernel-mentees 
	<linux-kernel-mentees@lists.linuxfoundation.org>
Subject: Re: [PATCH v2] wifi: cfg80211: Fix UAF in ieee80211_scan_rx()
Date: Fri, 12 Aug 2022 17:27:58 +0200	[thread overview]
Message-ID: <YvZxfpY4JUqvsOG5@kroah.com> (raw)
In-Reply-To: <18292791718.88f48d22175003.6675210189148271554@siddh.me>

On Fri, Aug 12, 2022 at 08:03:05PM +0530, Siddh Raman Pant wrote:
> On Fri, 12 Aug 2022 17:45:58 +0530  Greg KH  wrote:
> > The merge window is for new features to be added, bugfixes can be merged
> > at any point in time, but most maintainers close their trees until after
> > the merge window is closed before accepting new fixes, like this one.
> > 
> > So just relax, wait another week or so, and if there's no response,
> > resend it then.
> > 
> 
> Okay, sure.
> 
> > Personally, this patch seems very incorrect, but hey, I'm not the wifi
> > subsystem maintainer :)
> 
> Why do you think so?

rcu just delays freeing of an object, you might just be delaying the
race condition.  Just moving a single object to be freed with rcu feels
very odd if you don't have another reference somewhere.

Anyway, I don't know this codebase, so I could be totally wrong.

greg k-h

  reply	other threads:[~2022-08-12 15:28 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-26 12:39 [PATCH v2] wifi: cfg80211: Fix UAF in ieee80211_scan_rx() Siddh Raman Pant via Linux-kernel-mentees
2022-07-26 12:39 ` Siddh Raman Pant
2022-08-12  9:51 ` Siddh Raman Pant via Linux-kernel-mentees
2022-08-12  9:51   ` Siddh Raman Pant
2022-08-12 12:15   ` Greg KH
2022-08-12 12:15     ` Greg KH
2022-08-12 14:33     ` Siddh Raman Pant via Linux-kernel-mentees
2022-08-12 14:33       ` Siddh Raman Pant
2022-08-12 15:27       ` Greg KH [this message]
2022-08-12 15:27         ` Greg KH
2022-08-12 16:27         ` Siddh Raman Pant via Linux-kernel-mentees
2022-08-12 16:27           ` Siddh Raman Pant
2022-08-12 19:25           ` Jakub Kicinski
2022-08-12 19:25             ` Jakub Kicinski
2022-08-13 16:19             ` Siddh Raman Pant via Linux-kernel-mentees
2022-08-13 16:19               ` Siddh Raman Pant
2022-08-15 16:47               ` Jakub Kicinski
2022-08-15 19:58                 ` Johannes Berg
2022-08-15 19:58                   ` Johannes Berg
2022-08-16  0:51                   ` Jakub Kicinski
2022-08-16  8:52                   ` Siddh Raman Pant via Linux-kernel-mentees
2022-08-16  8:52                     ` Siddh Raman Pant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YvZxfpY4JUqvsOG5@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=code@siddh.me \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=johannes@sipsolutions.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=syzbot+6cb476b7c69916a0caca@syzkaller.appspotmail.com \
    --cc=syzbot+9250865a55539d384347@syzkaller.appspotmail.com \
    --cc=syzbot+f9acff9bf08a845f225d@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.