All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Saravana Kannan <saravanak@google.com>,
	Michael Walle <michael@walle.cc>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	kernelci-results@groups.io, bot@kernelci.org,
	gtucker@collabora.com, linux-arm-kernel@lists.infradead.org,
	linux-pci@vger.kernel.org
Subject: Re: next/master bisection: baseline.bootrr.intel-igb-probed on kontron-pitx-imx8m
Date: Wed, 17 Aug 2022 13:58:09 +0100	[thread overview]
Message-ID: <Yvzl4XK1QDfTbshr@sirena.org.uk> (raw)
In-Reply-To: <YvyOOWB6rBq0ZEpF@kroah.com>

[-- Attachment #1: Type: text/plain, Size: 1695 bytes --]

On Wed, Aug 17, 2022 at 08:44:09AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Aug 16, 2022 at 10:48:04AM -0700, Saravana Kannan wrote:

> > Ah, this is news to me. I'll poke around to see if the path can be
> > maintained even after converting a class to a bus.

> Which specific path are you worried about?

The various files in /sys/class/regulator.

> > (though
> > > TBH given how entirely virtual this stuff us it seems odd that we'd be
> > > going for a bus).

> > I'm going for a bus because class doesn't have a distinction between
> > "device has been added" and "device is ready if these things happen".
> > There's nothing to say that a "bus" has to be a real hardware bus.

> busses are not always real hardware busses, look at the virtual bus code
> for examples of that.

Sure, but the less things correspond to the concrete concept of a thing
the more chance there is that things will be redefined later, and in
this case I'm struggling to see this matching even the abstract idea of
a bus.

> Classes are "representations of a type of device that userspace
> interacts with" like input, sound, tty, and so on, that are independant
> of the type of hardware bus or device it is.  Do all regulators need to
> interact with userspace in a common way?  If so, it's a class, if not,
> maybe a bus would work, but that takes more code than a class so it
> should only be done if you really need it for some odd reason.

My understanding is that people are using the current class interface
for monitoring of what the framework is doing, there's regular attempts
to add a write interface too though that isn't happening.  It kind of
corresponds to the write side of hwmon in some ways.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Saravana Kannan <saravanak@google.com>,
	Michael Walle <michael@walle.cc>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	kernelci-results@groups.io, bot@kernelci.org,
	gtucker@collabora.com, linux-arm-kernel@lists.infradead.org,
	linux-pci@vger.kernel.org
Subject: Re: next/master bisection: baseline.bootrr.intel-igb-probed on kontron-pitx-imx8m
Date: Wed, 17 Aug 2022 13:58:09 +0100	[thread overview]
Message-ID: <Yvzl4XK1QDfTbshr@sirena.org.uk> (raw)
In-Reply-To: <YvyOOWB6rBq0ZEpF@kroah.com>


[-- Attachment #1.1: Type: text/plain, Size: 1695 bytes --]

On Wed, Aug 17, 2022 at 08:44:09AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Aug 16, 2022 at 10:48:04AM -0700, Saravana Kannan wrote:

> > Ah, this is news to me. I'll poke around to see if the path can be
> > maintained even after converting a class to a bus.

> Which specific path are you worried about?

The various files in /sys/class/regulator.

> > (though
> > > TBH given how entirely virtual this stuff us it seems odd that we'd be
> > > going for a bus).

> > I'm going for a bus because class doesn't have a distinction between
> > "device has been added" and "device is ready if these things happen".
> > There's nothing to say that a "bus" has to be a real hardware bus.

> busses are not always real hardware busses, look at the virtual bus code
> for examples of that.

Sure, but the less things correspond to the concrete concept of a thing
the more chance there is that things will be redefined later, and in
this case I'm struggling to see this matching even the abstract idea of
a bus.

> Classes are "representations of a type of device that userspace
> interacts with" like input, sound, tty, and so on, that are independant
> of the type of hardware bus or device it is.  Do all regulators need to
> interact with userspace in a common way?  If so, it's a class, if not,
> maybe a bus would work, but that takes more code than a class so it
> should only be done if you really need it for some odd reason.

My understanding is that people are using the current class interface
for monitoring of what the framework is doing, there's regular attempts
to add a write interface too though that isn't happening.  It kind of
corresponds to the write side of hwmon in some ways.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-08-17 12:58 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <62eed399.170a0220.2503a.1c64@mx.google.com>
2022-08-08 12:22 ` next/master bisection: baseline.bootrr.intel-igb-probed on kontron-pitx-imx8m Mark Brown
2022-08-08 12:22   ` Mark Brown
2022-08-08 12:31   ` Michael Walle
2022-08-08 12:31     ` Michael Walle
2022-08-08 12:35   ` Michael Walle
2022-08-08 12:35     ` Michael Walle
2022-08-08 12:41     ` Mark Brown
2022-08-08 12:41       ` Mark Brown
2022-08-12 23:54       ` Saravana Kannan
2022-08-12 23:54         ` Saravana Kannan
2022-08-16 17:26         ` Mark Brown
2022-08-16 17:26           ` Mark Brown
2022-08-16 17:48           ` Saravana Kannan
2022-08-16 17:48             ` Saravana Kannan
2022-08-16 17:53             ` Mark Brown
2022-08-16 17:53               ` Mark Brown
2022-08-16 18:04               ` Saravana Kannan
2022-08-16 18:04                 ` Saravana Kannan
2022-08-17  6:44             ` Greg Kroah-Hartman
2022-08-17  6:44               ` Greg Kroah-Hartman
2022-08-17 12:58               ` Mark Brown [this message]
2022-08-17 12:58                 ` Mark Brown
2022-08-12 19:29   ` [REGRESSION] " Bjorn Helgaas
2022-08-12 19:29     ` Bjorn Helgaas
2022-08-12 23:48     ` Saravana Kannan
2022-08-12 23:48       ` Saravana Kannan
     [not found] <63f141b2.170a0220.57e67.6c7c@mx.google.com>
2023-02-20 18:10 ` Mark Brown
2023-02-20 18:10   ` Mark Brown
2023-02-20 18:38   ` Michael Walle
2023-02-20 18:38     ` Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yvzl4XK1QDfTbshr@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=bot@kernelci.org \
    --cc=geert+renesas@glider.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=gtucker@collabora.com \
    --cc=kernelci-results@groups.io \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=michael@walle.cc \
    --cc=saravanak@google.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.