From: Breno Leitao <leitao@debian.org>
To: cgel.zte@gmail.com
Cc: nayna@linux.ibm.com, pfsmorigo@gmail.com, mpe@ellerman.id.au,
npiggin@gmail.com, christophe.leroy@csgroup.eu,
herbert@gondor.apana.org.au, davem@davemloft.net,
linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
Jinpeng Cui <cui.jinpeng2@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux-next] crypto: nx: remove redundant variable rc
Date: Wed, 31 Aug 2022 09:18:18 -0700 [thread overview]
Message-ID: <Yw+JysFvbmW0yJL8@gmail.com> (raw)
In-Reply-To: <20220831140248.303940-1-cui.jinpeng2@zte.com.cn>
On Wed, Aug 31, 2022 at 02:02:48PM +0000, cgel.zte@gmail.com wrote:
> From: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
>
> Return value directly from set_msg_len() instead of
> getting value from redundant variable rc.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
Reviewed-by: Breno Leitao <leitao@debian.org>
> ---
> drivers/crypto/nx/nx-aes-ccm.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/crypto/nx/nx-aes-ccm.c b/drivers/crypto/nx/nx-aes-ccm.c
> index 3793885f928d..c843f4c6f684 100644
> --- a/drivers/crypto/nx/nx-aes-ccm.c
> +++ b/drivers/crypto/nx/nx-aes-ccm.c
> @@ -134,7 +134,6 @@ static int generate_b0(u8 *iv, unsigned int assoclen, unsigned int authsize,
> unsigned int cryptlen, u8 *b0)
> {
> unsigned int l, lp, m = authsize;
> - int rc;
>
> memcpy(b0, iv, 16);
>
> @@ -148,9 +147,7 @@ static int generate_b0(u8 *iv, unsigned int assoclen, unsigned int authsize,
> if (assoclen)
> *b0 |= 64;
>
> - rc = set_msg_len(b0 + 16 - l, cryptlen, l);
> -
> - return rc;
> + return set_msg_len(b0 + 16 - l, cryptlen, l);
> }
>
> static int generate_pat(u8 *iv,
> --
> 2.25.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Breno Leitao <leitao@debian.org>
To: cgel.zte@gmail.com
Cc: herbert@gondor.apana.org.au, Zeal Robot <zealci@zte.com.cn>,
nayna@linux.ibm.com, linux-kernel@vger.kernel.org,
pfsmorigo@gmail.com, npiggin@gmail.com,
Jinpeng Cui <cui.jinpeng2@zte.com.cn>,
linuxppc-dev@lists.ozlabs.org, davem@davemloft.net,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH linux-next] crypto: nx: remove redundant variable rc
Date: Wed, 31 Aug 2022 09:18:18 -0700 [thread overview]
Message-ID: <Yw+JysFvbmW0yJL8@gmail.com> (raw)
In-Reply-To: <20220831140248.303940-1-cui.jinpeng2@zte.com.cn>
On Wed, Aug 31, 2022 at 02:02:48PM +0000, cgel.zte@gmail.com wrote:
> From: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
>
> Return value directly from set_msg_len() instead of
> getting value from redundant variable rc.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
Reviewed-by: Breno Leitao <leitao@debian.org>
> ---
> drivers/crypto/nx/nx-aes-ccm.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/crypto/nx/nx-aes-ccm.c b/drivers/crypto/nx/nx-aes-ccm.c
> index 3793885f928d..c843f4c6f684 100644
> --- a/drivers/crypto/nx/nx-aes-ccm.c
> +++ b/drivers/crypto/nx/nx-aes-ccm.c
> @@ -134,7 +134,6 @@ static int generate_b0(u8 *iv, unsigned int assoclen, unsigned int authsize,
> unsigned int cryptlen, u8 *b0)
> {
> unsigned int l, lp, m = authsize;
> - int rc;
>
> memcpy(b0, iv, 16);
>
> @@ -148,9 +147,7 @@ static int generate_b0(u8 *iv, unsigned int assoclen, unsigned int authsize,
> if (assoclen)
> *b0 |= 64;
>
> - rc = set_msg_len(b0 + 16 - l, cryptlen, l);
> -
> - return rc;
> + return set_msg_len(b0 + 16 - l, cryptlen, l);
> }
>
> static int generate_pat(u8 *iv,
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-08-31 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 14:02 [PATCH linux-next] crypto: nx: remove redundant variable rc cgel.zte
2022-08-31 14:02 ` cgel.zte
2022-08-31 16:18 ` Breno Leitao [this message]
2022-08-31 16:18 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yw+JysFvbmW0yJL8@gmail.com \
--to=leitao@debian.org \
--cc=cgel.zte@gmail.com \
--cc=christophe.leroy@csgroup.eu \
--cc=cui.jinpeng2@zte.com.cn \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nayna@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=pfsmorigo@gmail.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.