All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: "Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Kishon Vijay Abraham I" <kishon@ti.com>,
	"Marek Behún" <kabel@kernel.org>,
	"Shinichiro Kawasaki" <shinichiro.kawasaki@wdc.com>,
	"Damien Le Moal" <Damien.LeMoal@wdc.com>,
	linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: marvell: phy-mvebu-a3700-comphy: Remove broken reset support
Date: Tue, 30 Aug 2022 10:33:00 +0530	[thread overview]
Message-ID: <Yw2aBNnVoV8wwk4i@matsya> (raw)
In-Reply-To: <20220829083046.15082-1-pali@kernel.org>

On 29-08-22, 10:30, Pali Rohár wrote:
> Reset support for SATA PHY is somehow broken and after calling it, kernel
> is not able to detect and initialize SATA disk Samsung SSD 850 EMT0 [1].
> 
> Reset support was introduced in commit 934337080c6c ("phy: marvell:
> phy-mvebu-a3700-comphy: Add native kernel implementation") as part of
> complete rewrite of this driver. v1 patch series of that commit [2] did
> not contain reset support and was tested that is working fine with
> Ethernet, SATA and USB PHYs without issues too.
> 
> So for now remove broken reset support and change implementation of
> power_off callback to power off all functions on specified lane (and not
> only selected function) because during startup kernel does not know which
> function was selected and configured by bootloader. Same logic was used
> also in v1 patch series of that commit.
> 
> This change fixes issues with initialization of SATA disk Samsung SSD 850
> and disk is working again, like before mentioned commit.
> 
> Once problem with PHY reset callback is solved its functionality could be
> re-introduced. But for now it is unknown why it does not work.

Applied, thanks

-- 
~Vinod

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: "Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Kishon Vijay Abraham I" <kishon@ti.com>,
	"Marek Behún" <kabel@kernel.org>,
	"Shinichiro Kawasaki" <shinichiro.kawasaki@wdc.com>,
	"Damien Le Moal" <Damien.LeMoal@wdc.com>,
	linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: marvell: phy-mvebu-a3700-comphy: Remove broken reset support
Date: Tue, 30 Aug 2022 10:33:00 +0530	[thread overview]
Message-ID: <Yw2aBNnVoV8wwk4i@matsya> (raw)
In-Reply-To: <20220829083046.15082-1-pali@kernel.org>

On 29-08-22, 10:30, Pali Rohár wrote:
> Reset support for SATA PHY is somehow broken and after calling it, kernel
> is not able to detect and initialize SATA disk Samsung SSD 850 EMT0 [1].
> 
> Reset support was introduced in commit 934337080c6c ("phy: marvell:
> phy-mvebu-a3700-comphy: Add native kernel implementation") as part of
> complete rewrite of this driver. v1 patch series of that commit [2] did
> not contain reset support and was tested that is working fine with
> Ethernet, SATA and USB PHYs without issues too.
> 
> So for now remove broken reset support and change implementation of
> power_off callback to power off all functions on specified lane (and not
> only selected function) because during startup kernel does not know which
> function was selected and configured by bootloader. Same logic was used
> also in v1 patch series of that commit.
> 
> This change fixes issues with initialization of SATA disk Samsung SSD 850
> and disk is working again, like before mentioned commit.
> 
> Once problem with PHY reset callback is solved its functionality could be
> re-introduced. But for now it is unknown why it does not work.

Applied, thanks

-- 
~Vinod

  parent reply	other threads:[~2022-08-30  5:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-29  8:30 [PATCH] phy: marvell: phy-mvebu-a3700-comphy: Remove broken reset support Pali Rohár
2022-08-29  8:30 ` Pali Rohár
2022-08-29  9:02 ` Shinichiro Kawasaki
2022-08-29  9:02   ` Shinichiro Kawasaki
2022-08-30  5:03 ` Vinod Koul [this message]
2022-08-30  5:03   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yw2aBNnVoV8wwk4i@matsya \
    --to=vkoul@kernel.org \
    --cc=Damien.LeMoal@wdc.com \
    --cc=kabel@kernel.org \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=pali@kernel.org \
    --cc=shinichiro.kawasaki@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.