All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Saravana Kannan <saravanak@google.com>
Cc: Zhen Lei <thunder.leizhen@huawei.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, patches@armlinux.org.uk,
	Kefeng Wang <wangkefeng.wang@huawei.com>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2] ARM: Add sanity check for dev->periphid in amba_probe()
Date: Tue, 30 Aug 2022 10:48:36 +0100	[thread overview]
Message-ID: <Yw3c9Dbai5E9Nvvp@shell.armlinux.org.uk> (raw)
In-Reply-To: <Yw3cs6wb4PvnDN/7@shell.armlinux.org.uk>

On Tue, Aug 30, 2022 at 10:47:31AM +0100, Russell King (Oracle) wrote:
> How can we get to amba_probe() if amba_match() has not returned a
> positive match for an ID? Surely if that happens, the driver model
> is failed - since a probe function should not be called unless the
> driver matches the device.
> 
> This patch, and 9229/1 both feel like they're working around some
> brokenness elsewhere in the kernel.
> 
> The description in 9229/1, specifically "But not all drivers have .match

Sorry, meant 9238/1.

> hook, such as pl031, the dev->bus->probe will be called directly in
> __driver_attach()." AMBA drivers do not have a .match hook - the bus
> does, which all AMBA drivers must be a member of. If amba_match fails,
> there is no way that amba_probe() should ever be called.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Saravana Kannan <saravanak@google.com>
Cc: Zhen Lei <thunder.leizhen@huawei.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, patches@armlinux.org.uk,
	Kefeng Wang <wangkefeng.wang@huawei.com>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2] ARM: Add sanity check for dev->periphid in amba_probe()
Date: Tue, 30 Aug 2022 10:48:36 +0100	[thread overview]
Message-ID: <Yw3c9Dbai5E9Nvvp@shell.armlinux.org.uk> (raw)
In-Reply-To: <Yw3cs6wb4PvnDN/7@shell.armlinux.org.uk>

On Tue, Aug 30, 2022 at 10:47:31AM +0100, Russell King (Oracle) wrote:
> How can we get to amba_probe() if amba_match() has not returned a
> positive match for an ID? Surely if that happens, the driver model
> is failed - since a probe function should not be called unless the
> driver matches the device.
> 
> This patch, and 9229/1 both feel like they're working around some
> brokenness elsewhere in the kernel.
> 
> The description in 9229/1, specifically "But not all drivers have .match

Sorry, meant 9238/1.

> hook, such as pl031, the dev->bus->probe will be called directly in
> __driver_attach()." AMBA drivers do not have a .match hook - the bus
> does, which all AMBA drivers must be a member of. If amba_match fails,
> there is no way that amba_probe() should ever be called.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

  reply	other threads:[~2022-08-30  9:50 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-30  6:54 [PATCH v2] ARM: Add sanity check for dev->periphid in amba_probe() Zhen Lei
2022-08-30  6:54 ` Zhen Lei
2022-08-30  7:20 ` Saravana Kannan
2022-08-30  7:20   ` Saravana Kannan
2022-08-30  9:47   ` Russell King (Oracle)
2022-08-30  9:47     ` Russell King (Oracle)
2022-08-30  9:48     ` Russell King (Oracle) [this message]
2022-08-30  9:48       ` Russell King (Oracle)
2022-08-30 10:03     ` Leizhen (ThunderTown)
2022-08-30 10:03       ` Leizhen (ThunderTown)
2022-08-30 10:07       ` Russell King (Oracle)
2022-08-30 10:07         ` Russell King (Oracle)
2022-08-30 10:31         ` Leizhen (ThunderTown)
2022-08-30 10:31           ` Leizhen (ThunderTown)
2022-08-30 10:36           ` Russell King (Oracle)
2022-08-30 10:36             ` Russell King (Oracle)
2022-08-30 11:19             ` Linus Walleij
2022-08-30 11:19               ` Linus Walleij
2022-08-30 11:49               ` Leizhen (ThunderTown)
2022-08-30 11:49                 ` Leizhen (ThunderTown)
2022-08-30 17:34             ` Saravana Kannan
2022-08-30 17:34               ` Saravana Kannan
2022-08-30 23:48               ` Saravana Kannan
2022-08-30 23:48                 ` Saravana Kannan
2022-08-30  9:50 ` Russell King (Oracle)
2022-08-30  9:50   ` Russell King (Oracle)
2022-08-30 10:07   ` Leizhen (ThunderTown)
2022-08-30 10:07     ` Leizhen (ThunderTown)
2022-08-30 12:11     ` Leizhen (ThunderTown)
2022-08-30 12:11       ` Leizhen (ThunderTown)
2022-08-30 10:28 ` Russell King (Oracle)
2022-08-30 10:28   ` Russell King (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yw3c9Dbai5E9Nvvp@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@armlinux.org.uk \
    --cc=saravanak@google.com \
    --cc=thunder.leizhen@huawei.com \
    --cc=wangkefeng.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.