From: Paul Mackerras <paulus@ozlabs.org>
To: Jilin Yuan <yuanjilin@cdjrlc.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
npiggin@gmail.com
Subject: Re: [PATCH] KVM: fix repeated words in comments
Date: Wed, 31 Aug 2022 13:34:48 +1000 [thread overview]
Message-ID: <Yw7W2DfOvqqm7IvM@cleo> (raw)
In-Reply-To: <20220831004454.33921-1-yuanjilin@cdjrlc.com>
On Wed, Aug 31, 2022 at 08:44:54AM +0800, Jilin Yuan wrote:
> Delete the redundant word 'that'.
Nack, having two "that"s in a row is intentional. It's "make sure
that" (i.e. bring about the situation described in what follows)
"that many HPTEs" (i.e. the number of HPTEs referenced previously)
"are invalid".
> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
> ---
> arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c
> index e9744b41a226..8e4b42b5f37f 100644
> --- a/arch/powerpc/kvm/book3s_64_mmu_hv.c
> +++ b/arch/powerpc/kvm/book3s_64_mmu_hv.c
> @@ -1601,7 +1601,7 @@ long kvm_vm_ioctl_resize_hpt_commit(struct kvm *kvm,
> * is valid, it is written to the HPT as if an H_ENTER with the
> * exact flag set was done. When the invalid count is non-zero
> * in the header written to the stream, the kernel will make
> - * sure that that many HPTEs are invalid, and invalidate them
> + * sure that many HPTEs are invalid, and invalidate them
> * if not.
> */
Paul.
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mackerras <paulus@ozlabs.org>
To: Jilin Yuan <yuanjilin@cdjrlc.com>
Cc: mpe@ellerman.id.au, npiggin@gmail.com,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: fix repeated words in comments
Date: Wed, 31 Aug 2022 13:34:48 +1000 [thread overview]
Message-ID: <Yw7W2DfOvqqm7IvM@cleo> (raw)
In-Reply-To: <20220831004454.33921-1-yuanjilin@cdjrlc.com>
On Wed, Aug 31, 2022 at 08:44:54AM +0800, Jilin Yuan wrote:
> Delete the redundant word 'that'.
Nack, having two "that"s in a row is intentional. It's "make sure
that" (i.e. bring about the situation described in what follows)
"that many HPTEs" (i.e. the number of HPTEs referenced previously)
"are invalid".
> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
> ---
> arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c
> index e9744b41a226..8e4b42b5f37f 100644
> --- a/arch/powerpc/kvm/book3s_64_mmu_hv.c
> +++ b/arch/powerpc/kvm/book3s_64_mmu_hv.c
> @@ -1601,7 +1601,7 @@ long kvm_vm_ioctl_resize_hpt_commit(struct kvm *kvm,
> * is valid, it is written to the HPT as if an H_ENTER with the
> * exact flag set was done. When the invalid count is non-zero
> * in the header written to the stream, the kernel will make
> - * sure that that many HPTEs are invalid, and invalidate them
> + * sure that many HPTEs are invalid, and invalidate them
> * if not.
> */
Paul.
next prev parent reply other threads:[~2022-08-31 3:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 0:44 [PATCH] KVM: fix repeated words in comments Jilin Yuan
2022-08-31 0:44 ` Jilin Yuan
2022-08-31 3:34 ` Paul Mackerras [this message]
2022-08-31 3:34 ` Paul Mackerras
2022-08-31 11:06 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yw7W2DfOvqqm7IvM@cleo \
--to=paulus@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=yuanjilin@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.