All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: devicetree@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, Keerthy <j-keerthy@ti.com>,
	Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH v2 2/2] arm64: dts: ti: k3-am65: Add general purpose timers for am65
Date: Wed, 31 Aug 2022 08:05:39 +0300	[thread overview]
Message-ID: <Yw7sI81Nzo5koM6c@atomide.com> (raw)
In-Reply-To: <20220830070750.30640-3-tony@atomide.com>

* Tony Lindgren <tony@atomide.com> [220830 07:09]:
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> @@ -271,6 +271,138 @@ main_spi4: spi@2140000 {
>  		#size-cells = <0>;
>  	};
>  
> +	main_timer0: timer@2400000 {
> +		compatible = "ti,am654-timer";
> +		reg = <0x00 0x2400000 0x00 0x400>;
> +		interrupts = <GIC_SPI 224 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&k3_clks 23 0>;
> +		clock-names = "fck";
> +		assigned-clocks = <&k3_clks 23 0>;
> +		assigned-clock-parents = <&k3_clks 23 1>;
> +		ti,timer-pwm;
> +	};

Oops the power-domains are missing for the timers. This should
have power-domains = <&k3_pds 23 TI_SCI_PD_EXCLUSIVE>.

Can we tag all the timers with TI_SCI_PD_EXCLUSIVE, or do some
always need to be TI_SCI_PD_SHARED?

Regards,

Tony


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: devicetree@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, Keerthy <j-keerthy@ti.com>,
	Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH v2 2/2] arm64: dts: ti: k3-am65: Add general purpose timers for am65
Date: Wed, 31 Aug 2022 08:05:39 +0300	[thread overview]
Message-ID: <Yw7sI81Nzo5koM6c@atomide.com> (raw)
In-Reply-To: <20220830070750.30640-3-tony@atomide.com>

* Tony Lindgren <tony@atomide.com> [220830 07:09]:
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> @@ -271,6 +271,138 @@ main_spi4: spi@2140000 {
>  		#size-cells = <0>;
>  	};
>  
> +	main_timer0: timer@2400000 {
> +		compatible = "ti,am654-timer";
> +		reg = <0x00 0x2400000 0x00 0x400>;
> +		interrupts = <GIC_SPI 224 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&k3_clks 23 0>;
> +		clock-names = "fck";
> +		assigned-clocks = <&k3_clks 23 0>;
> +		assigned-clock-parents = <&k3_clks 23 1>;
> +		ti,timer-pwm;
> +	};

Oops the power-domains are missing for the timers. This should
have power-domains = <&k3_pds 23 TI_SCI_PD_EXCLUSIVE>.

Can we tag all the timers with TI_SCI_PD_EXCLUSIVE, or do some
always need to be TI_SCI_PD_SHARED?

Regards,

Tony


  reply	other threads:[~2022-08-31  5:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-30  7:07 [PATCH v2 0/2] Configure dmtimers for am65 Tony Lindgren
2022-08-30  7:07 ` Tony Lindgren
2022-08-30  7:07 ` [PATCH v2 1/2] arm64: dts: ti: k3-am65: Configure pinctrl for timer IO pads Tony Lindgren
2022-08-30  7:07   ` Tony Lindgren
2022-08-30  7:07 ` [PATCH v2 2/2] arm64: dts: ti: k3-am65: Add general purpose timers for am65 Tony Lindgren
2022-08-30  7:07   ` Tony Lindgren
2022-08-31  5:05   ` Tony Lindgren [this message]
2022-08-31  5:05     ` Tony Lindgren
2022-09-01 10:37     ` Vignesh Raghavendra
2022-09-01 10:37       ` Vignesh Raghavendra
2022-08-30  7:22 ` [PATCH v2 0/2] Configure dmtimers " Tony Lindgren
2022-08-30  7:22   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yw7sI81Nzo5koM6c@atomide.com \
    --to=tony@atomide.com \
    --cc=devicetree@vger.kernel.org \
    --cc=j-keerthy@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=nm@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.