All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Victor Hassan <victor@allwinnertech.com>,
	linus.walleij@linaro.org, yanfei.xu@windriver.com,
	ardb@kernel.org, tglx@linutronix.de, mirq-linux@rere.qmqm.pl,
	arnd@arndb.de, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	allwinner-opensource-support@allwinnertech.com
Subject: Re: [PATCH] ARM: mmu: fix access to illegal address when using earlycon & memblock=debug
Date: Wed, 31 Aug 2022 14:51:07 +0100	[thread overview]
Message-ID: <Yw9nS0GXOPCGUWbn@shell.armlinux.org.uk> (raw)
In-Reply-To: <9a425a51-9460-6c4d-e331-5cd5873f8a43@samsung.com>

On Wed, Aug 31, 2022 at 01:52:57PM +0200, Marek Szyprowski wrote:
> Hi Victor,
> 
> On 16.03.2022 03:33, Victor Hassan wrote:
> > earlycon uses fixmap to create a memory map,
> > So we need to close earlycon before closing fixmap,
> > otherwise printk will access illegal addresses.
> > After creating a new memory map, we open earlycon again.
> >
> > Signed-off-by: Victor Hassan <victor@allwinnertech.com>
> 
> This patch landed in linux next-20220831 as commit a76886d117cb ("ARM: 
> 9223/1: mmu: fix access to illegal address when using earlycon & 
> memblock=debug"). Unfortunately it breaks booting of all my test boards 
> which *do not* use earlycon. It can be easily reproduced even with QEMU.
> 
> With kernel compiled from multi_v7_defconfig the following setup boots:
> 
> $ qemu-system-arm -nographic -kernel arch/arm/boot/zImage -append 
> "console=ttyAMA0 earlycon" -M virt -smp 2 -m 512
> 
> while this one doesn't:
> 
> $ qemu-system-arm -nographic -kernel arch/arm/boot/zImage -append 
> "console=ttyAMA0" -M virt -smp 2 -m 512

That's the second patch to drop from my merge yesterday... not good.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Victor Hassan <victor@allwinnertech.com>,
	linus.walleij@linaro.org, yanfei.xu@windriver.com,
	ardb@kernel.org, tglx@linutronix.de, mirq-linux@rere.qmqm.pl,
	arnd@arndb.de, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	allwinner-opensource-support@allwinnertech.com
Subject: Re: [PATCH] ARM: mmu: fix access to illegal address when using earlycon & memblock=debug
Date: Wed, 31 Aug 2022 14:51:07 +0100	[thread overview]
Message-ID: <Yw9nS0GXOPCGUWbn@shell.armlinux.org.uk> (raw)
In-Reply-To: <9a425a51-9460-6c4d-e331-5cd5873f8a43@samsung.com>

On Wed, Aug 31, 2022 at 01:52:57PM +0200, Marek Szyprowski wrote:
> Hi Victor,
> 
> On 16.03.2022 03:33, Victor Hassan wrote:
> > earlycon uses fixmap to create a memory map,
> > So we need to close earlycon before closing fixmap,
> > otherwise printk will access illegal addresses.
> > After creating a new memory map, we open earlycon again.
> >
> > Signed-off-by: Victor Hassan <victor@allwinnertech.com>
> 
> This patch landed in linux next-20220831 as commit a76886d117cb ("ARM: 
> 9223/1: mmu: fix access to illegal address when using earlycon & 
> memblock=debug"). Unfortunately it breaks booting of all my test boards 
> which *do not* use earlycon. It can be easily reproduced even with QEMU.
> 
> With kernel compiled from multi_v7_defconfig the following setup boots:
> 
> $ qemu-system-arm -nographic -kernel arch/arm/boot/zImage -append 
> "console=ttyAMA0 earlycon" -M virt -smp 2 -m 512
> 
> while this one doesn't:
> 
> $ qemu-system-arm -nographic -kernel arch/arm/boot/zImage -append 
> "console=ttyAMA0" -M virt -smp 2 -m 512

That's the second patch to drop from my merge yesterday... not good.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

  parent reply	other threads:[~2022-08-31 13:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220831115257eucas1p20d37a01c51e42767860920a936255bd7@eucas1p2.samsung.com>
2022-03-16  2:33 ` [PATCH] ARM: mmu: fix access to illegal address when using earlycon & memblock=debug Victor Hassan
2022-03-16  2:33   ` Victor Hassan
2022-04-17 23:21   ` Linus Walleij
2022-04-17 23:21     ` Linus Walleij
2022-04-18 15:08     ` Victor Hassan
2022-04-18 15:08       ` Victor Hassan
2022-06-17 13:30       ` Victor Hassan
2022-06-17 13:30         ` Victor Hassan
2022-06-28  8:34         ` Linus Walleij
2022-06-28  8:34           ` Linus Walleij
2022-08-31 11:52   ` Marek Szyprowski
2022-08-31 11:52     ` Marek Szyprowski
2022-08-31 12:37     ` Victor Hassan
2022-08-31 12:37       ` Victor Hassan
2022-09-01 12:53       ` Victor Hassan
2022-09-01 12:53         ` Victor Hassan
2022-09-01 13:21         ` Rob Herring
2022-09-01 13:21           ` Rob Herring
2022-09-01 13:49           ` Rob Herring
2022-09-01 13:49             ` Rob Herring
2022-09-03  8:54           ` Victor Hassan
2022-09-03  8:54             ` Victor Hassan
2022-08-31 13:51     ` Russell King (Oracle) [this message]
2022-08-31 13:51       ` Russell King (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yw9nS0GXOPCGUWbn@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=allwinner-opensource-support@allwinnertech.com \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mirq-linux@rere.qmqm.pl \
    --cc=tglx@linutronix.de \
    --cc=victor@allwinnertech.com \
    --cc=yanfei.xu@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.