From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
qemu-devel@nongnu.org, Peter Xu <peterx@redhat.com>,
Bin Meng <bmeng.cn@gmail.com>
Subject: Re: [PATCH 2/4] tests/migration/aarch64: Speed up the aarch64 migration test
Date: Mon, 22 Aug 2022 11:57:52 +0100 [thread overview]
Message-ID: <YwNhMASJCURwrQXv@redhat.com> (raw)
In-Reply-To: <20220819053802.296584-3-thuth@redhat.com>
On Fri, Aug 19, 2022 at 07:38:00AM +0200, Thomas Huth wrote:
> The migration tests spend a lot of time waiting for a sign of live
> of the guest on the serial console. The aarch64 migration code only
> outputs "B"s every couple of seconds (at least it takes more than 4
> seconds between each characeter on my x86 laptop). There are a lot
> of migration tests, and if each test that checks for a successful
> migration waits for these characters before and after migration, the
> wait time sums up to multiple minutes! Let's use a shorter delay to
> speed things up.
>
> While we're at it, also remove a superfluous masking with 0xff - we're
> reading and storing bytes, so the upper bits of the register do not
> matter anyway.
>
> With these changes, the test runs twice as fast on my laptop, decreasing
> the total run time from approx. 8 minutes to only 4 minutes!
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/migration/aarch64/a-b-kernel.h | 10 +++++-----
> tests/migration/aarch64/a-b-kernel.S | 3 +--
> 2 files changed, 6 insertions(+), 7 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2022-08-22 10:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 5:37 [PATCH 0/4] Speed up migration tests Thomas Huth
2022-08-19 5:37 ` [PATCH 1/4] tests/qtest/migration-test: Only wait for serial output where migration succeeds Thomas Huth
2022-08-19 5:38 ` [PATCH 2/4] tests/migration/aarch64: Speed up the aarch64 migration test Thomas Huth
2022-08-22 10:57 ` Daniel P. Berrangé [this message]
2022-08-19 5:38 ` [PATCH 3/4] tests/migration/i386: Speed up the i386 migration test (when using TCG) Thomas Huth
2022-08-22 10:58 ` Daniel P. Berrangé
2022-08-19 5:38 ` [PATCH 4/4] tests/qtest/migration-test: Remove duplicated test_postcopy from the test plan Thomas Huth
2022-08-22 10:59 ` Daniel P. Berrangé
2022-08-22 15:32 ` Dr. David Alan Gilbert
2022-08-19 16:25 ` [PATCH 0/4] Speed up migration tests Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwNhMASJCURwrQXv@redhat.com \
--to=berrange@redhat.com \
--cc=bmeng.cn@gmail.com \
--cc=dgilbert@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.