From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
Juan Quintela <quintela@redhat.com>,
qemu-devel@nongnu.org, Peter Xu <peterx@redhat.com>,
Bin Meng <bmeng.cn@gmail.com>
Subject: Re: [PATCH 4/4] tests/qtest/migration-test: Remove duplicated test_postcopy from the test plan
Date: Mon, 22 Aug 2022 16:32:20 +0100 [thread overview]
Message-ID: <YwOhhAlaqsDIp7ZM@work-vm> (raw)
In-Reply-To: <YwNhhsWk9Gsn6A1e@redhat.com>
* Daniel P. Berrangé (berrange@redhat.com) wrote:
> On Fri, Aug 19, 2022 at 07:38:02AM +0200, Thomas Huth wrote:
> > test_postcopy() is currently run twice - which is just a waste of resources
> > and time. The commit d1a27b169b2d that introduced the duplicate talked about
> > renaming the "postcopy/unix" test, but apparently it forgot to remove the
> > old entry. Let's do that now.
>
> It was probably a merge error
Yeh I remember having to do a lot of manual merges around htere.
Dave
> >
> > Fixes: d1a27b169b ("tests: Add postcopy tls migration test")
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> > tests/qtest/migration-test.c | 1 -
> > 1 file changed, 1 deletion(-)
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>
>
> With regards,
> Daniel
> --
> |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org -o- https://fstop138.berrange.com :|
> |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2022-08-22 17:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 5:37 [PATCH 0/4] Speed up migration tests Thomas Huth
2022-08-19 5:37 ` [PATCH 1/4] tests/qtest/migration-test: Only wait for serial output where migration succeeds Thomas Huth
2022-08-19 5:38 ` [PATCH 2/4] tests/migration/aarch64: Speed up the aarch64 migration test Thomas Huth
2022-08-22 10:57 ` Daniel P. Berrangé
2022-08-19 5:38 ` [PATCH 3/4] tests/migration/i386: Speed up the i386 migration test (when using TCG) Thomas Huth
2022-08-22 10:58 ` Daniel P. Berrangé
2022-08-19 5:38 ` [PATCH 4/4] tests/qtest/migration-test: Remove duplicated test_postcopy from the test plan Thomas Huth
2022-08-22 10:59 ` Daniel P. Berrangé
2022-08-22 15:32 ` Dr. David Alan Gilbert [this message]
2022-08-19 16:25 ` [PATCH 0/4] Speed up migration tests Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwOhhAlaqsDIp7ZM@work-vm \
--to=dgilbert@redhat.com \
--cc=berrange@redhat.com \
--cc=bmeng.cn@gmail.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.