From: Christoph Hellwig <hch@infradead.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: "Gautham R . Shenoy" <ego@linux.vnet.ibm.com>,
amd-gfx@lists.freedesktop.org, "Pan, Xinhui" <Xinhui.Pan@amd.com>,
"Felix Kuehling" <Felix.Kuehling@amd.com>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Lai Jiangshan" <jiangshanlai@gmail.com>,
linux-kernel@vger.kernel.org,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Tejun Heo" <tj@kernel.org>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
linuxppc-dev@lists.ozlabs.org,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH] powerpc: export cpu_smallcore_map for modules
Date: Mon, 22 Aug 2022 04:30:05 -0700 [thread overview]
Message-ID: <YwNovfuf3pDBh2Zk@infradead.org> (raw)
In-Reply-To: <87o7wdkkt4.fsf@mpe.ellerman.id.au>
On Mon, Aug 22, 2022 at 01:40:23PM +1000, Michael Ellerman wrote:
> Randy Dunlap <rdunlap@infradead.org> writes:
> > drivers/gpu/drm/amd/amdkfd/kfd_device.c calls cpu_smt_mask().
> > This is an inline function on powerpc which references
> > cpu_smallcore_map.
> >
> > Fixes: 425752c63b6f ("powerpc: Detect the presence of big-cores via "ibm, thread-groups"")
> > Fixes: 7bc913085765 ("drm/amdkfd: Try to schedule bottom half on same core")
>
> That 2nd commit is not in mainline, only linux-next.
>
> I don't mind merging this fix preemptively, but is that SHA stable?
I really do not think this has any business being exported at all.
kfd_queue_work is not something that should be done in a driver.
Something like this belongs into the workqueue core, not in an
underdocumented helper in a random driver.
Drm guys: once again, please please work with the maintainers instead
of just making up random stuff in the drivers.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: "Gautham R . Shenoy" <ego@linux.vnet.ibm.com>,
amd-gfx@lists.freedesktop.org, "Pan, Xinhui" <Xinhui.Pan@amd.com>,
"Felix Kuehling" <Felix.Kuehling@amd.com>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Lai Jiangshan" <jiangshanlai@gmail.com>,
linux-kernel@vger.kernel.org, "Tejun Heo" <tj@kernel.org>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
linuxppc-dev@lists.ozlabs.org,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH] powerpc: export cpu_smallcore_map for modules
Date: Mon, 22 Aug 2022 04:30:05 -0700 [thread overview]
Message-ID: <YwNovfuf3pDBh2Zk@infradead.org> (raw)
In-Reply-To: <87o7wdkkt4.fsf@mpe.ellerman.id.au>
On Mon, Aug 22, 2022 at 01:40:23PM +1000, Michael Ellerman wrote:
> Randy Dunlap <rdunlap@infradead.org> writes:
> > drivers/gpu/drm/amd/amdkfd/kfd_device.c calls cpu_smt_mask().
> > This is an inline function on powerpc which references
> > cpu_smallcore_map.
> >
> > Fixes: 425752c63b6f ("powerpc: Detect the presence of big-cores via "ibm, thread-groups"")
> > Fixes: 7bc913085765 ("drm/amdkfd: Try to schedule bottom half on same core")
>
> That 2nd commit is not in mainline, only linux-next.
>
> I don't mind merging this fix preemptively, but is that SHA stable?
I really do not think this has any business being exported at all.
kfd_queue_work is not something that should be done in a driver.
Something like this belongs into the workqueue core, not in an
underdocumented helper in a random driver.
Drm guys: once again, please please work with the maintainers instead
of just making up random stuff in the drivers.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: "Randy Dunlap" <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org,
"Gautham R . Shenoy" <ego@linux.vnet.ibm.com>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
linuxppc-dev@lists.ozlabs.org, amd-gfx@lists.freedesktop.org,
"Felix Kuehling" <Felix.Kuehling@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>, "Tejun Heo" <tj@kernel.org>,
"Lai Jiangshan" <jiangshanlai@gmail.com>
Subject: Re: [PATCH] powerpc: export cpu_smallcore_map for modules
Date: Mon, 22 Aug 2022 04:30:05 -0700 [thread overview]
Message-ID: <YwNovfuf3pDBh2Zk@infradead.org> (raw)
In-Reply-To: <87o7wdkkt4.fsf@mpe.ellerman.id.au>
On Mon, Aug 22, 2022 at 01:40:23PM +1000, Michael Ellerman wrote:
> Randy Dunlap <rdunlap@infradead.org> writes:
> > drivers/gpu/drm/amd/amdkfd/kfd_device.c calls cpu_smt_mask().
> > This is an inline function on powerpc which references
> > cpu_smallcore_map.
> >
> > Fixes: 425752c63b6f ("powerpc: Detect the presence of big-cores via "ibm, thread-groups"")
> > Fixes: 7bc913085765 ("drm/amdkfd: Try to schedule bottom half on same core")
>
> That 2nd commit is not in mainline, only linux-next.
>
> I don't mind merging this fix preemptively, but is that SHA stable?
I really do not think this has any business being exported at all.
kfd_queue_work is not something that should be done in a driver.
Something like this belongs into the workqueue core, not in an
underdocumented helper in a random driver.
Drm guys: once again, please please work with the maintainers instead
of just making up random stuff in the drivers.
next prev parent reply other threads:[~2022-08-22 13:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 21:01 [PATCH] powerpc: export cpu_smallcore_map for modules Randy Dunlap
2022-08-19 21:01 ` Randy Dunlap
2022-08-19 21:01 ` Randy Dunlap
2022-08-19 22:14 ` Felix Kuehling
2022-08-19 22:14 ` Felix Kuehling
2022-08-19 22:14 ` Felix Kuehling
2022-08-19 22:18 ` Alex Deucher
2022-08-19 22:18 ` Alex Deucher
2022-08-19 22:18 ` Alex Deucher
2022-08-22 3:40 ` Michael Ellerman
2022-08-22 3:40 ` Michael Ellerman
2022-08-22 3:40 ` Michael Ellerman
2022-08-22 3:53 ` Randy Dunlap
2022-08-22 3:53 ` Randy Dunlap
2022-08-22 3:53 ` Randy Dunlap
2022-08-22 11:30 ` Christoph Hellwig [this message]
2022-08-22 11:30 ` Christoph Hellwig
2022-08-22 11:30 ` Christoph Hellwig
2022-08-22 13:31 ` Alex Deucher
2022-08-22 13:31 ` Alex Deucher
2022-08-22 13:31 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwNovfuf3pDBh2Zk@infradead.org \
--to=hch@infradead.org \
--cc=Felix.Kuehling@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=christophe.leroy@csgroup.eu \
--cc=ego@linux.vnet.ibm.com \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=rdunlap@infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.