From: Alyssa Rosenzweig <alyssa@collabora.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: robh@kernel.org, tomeu.vizoso@collabora.com,
steven.price@arm.com, alyssa.rosenzweig@collabora.com,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/panfrost: Update io-pgtable API
Date: Mon, 22 Aug 2022 22:51:09 -0400 [thread overview]
Message-ID: <YwRAnbNdx9nbGLom@maud> (raw)
In-Reply-To: <daef7f8c134d989c55636a5790d8c0fcaca1bae3.1661205687.git.robin.murphy@arm.com>
> -static size_t get_pgsize(u64 addr, size_t size)
> +static size_t get_pgsize(u64 addr, size_t size, size_t *count)
> {
> - if (addr & (SZ_2M - 1) || size < SZ_2M)
> - return SZ_4K;
> + size_t blk_offset = -addr % SZ_2M;
addr is unsigned. if this is correct, it's magic.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Alyssa Rosenzweig <alyssa@collabora.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: tomeu.vizoso@collabora.com, dri-devel@lists.freedesktop.org,
steven.price@arm.com, alyssa.rosenzweig@collabora.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/panfrost: Update io-pgtable API
Date: Mon, 22 Aug 2022 22:51:09 -0400 [thread overview]
Message-ID: <YwRAnbNdx9nbGLom@maud> (raw)
In-Reply-To: <daef7f8c134d989c55636a5790d8c0fcaca1bae3.1661205687.git.robin.murphy@arm.com>
> -static size_t get_pgsize(u64 addr, size_t size)
> +static size_t get_pgsize(u64 addr, size_t size, size_t *count)
> {
> - if (addr & (SZ_2M - 1) || size < SZ_2M)
> - return SZ_4K;
> + size_t blk_offset = -addr % SZ_2M;
addr is unsigned. if this is correct, it's magic.
next prev parent reply other threads:[~2022-08-23 2:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 22:01 [PATCH] drm/panfrost: Update io-pgtable API Robin Murphy
2022-08-22 22:01 ` Robin Murphy
2022-08-23 2:51 ` Alyssa Rosenzweig [this message]
2022-08-23 2:51 ` Alyssa Rosenzweig
2022-08-23 10:42 ` Robin Murphy
2022-08-23 10:42 ` Robin Murphy
2022-08-31 12:49 ` Alyssa Rosenzweig
2022-08-31 12:49 ` Alyssa Rosenzweig
2022-09-01 10:17 ` Steven Price
2022-09-01 10:17 ` Steven Price
2022-11-04 20:11 ` Dmitry Osipenko
2022-11-04 20:11 ` Dmitry Osipenko
2022-11-04 20:37 ` Robin Murphy
2022-11-04 20:37 ` Robin Murphy
2022-11-04 20:48 ` Dmitry Osipenko
2022-11-04 20:48 ` Dmitry Osipenko
2022-11-07 16:50 ` Robin Murphy
2022-11-07 16:50 ` Robin Murphy
2022-11-08 14:11 ` Dmitry Osipenko
2022-11-08 14:11 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwRAnbNdx9nbGLom@maud \
--to=alyssa@collabora.com \
--cc=alyssa.rosenzweig@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=steven.price@arm.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.