From: Peter Zijlstra <peterz@infradead.org>
To: Glenn Washburn <development@efficientek.com>
Cc: The development of GNU GRUB <grub-devel@gnu.org>,
Daniel Kiper <dkiper@net-space.pl>
Subject: Re: [PATCH] term/serial: Add support for PCI serial devices
Date: Thu, 25 Aug 2022 21:59:01 +0200 [thread overview]
Message-ID: <YwfUharQEbykNhYp@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20220825142320.47e09095@crass-HP-ZBook-15-G2>
On Thu, Aug 25, 2022 at 02:23:34PM -0500, Glenn Washburn wrote:
> > diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def
> > index 5212dfab1369..c0683da2353b 100644
> > --- a/grub-core/Makefile.core.def
> > +++ b/grub-core/Makefile.core.def
> > @@ -224,12 +224,14 @@ kernel = {
> >
> > i386_efi = kern/i386/efi/init.c;
> > i386_efi = bus/pci.c;
> > + i386_efi_cppflags = '-DGRUB_HAS_PCI';
>
> I imagine this should be enabled for all i386 and x86_64 targets, not
> just the few that you have here. For instance, what about i386-pc,
> which is the 32-bit BIOS target?
So what I did was put that _cppflags thing right next to all the
'bus/pci.c' instances I found, with exception of the pci module.
Where do i386-pc and friends get it from? IOW, what obvious place did I
miss?
next prev parent reply other threads:[~2022-08-25 19:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 11:28 [PATCH] term/serial: Add support for PCI serial devices Peter Zijlstra
2022-08-24 20:13 ` Glenn Washburn
2022-08-24 21:01 ` Peter Zijlstra
2022-08-24 23:36 ` Glenn Washburn
2022-08-25 7:36 ` Peter Zijlstra
2022-08-25 7:57 ` Peter Zijlstra
2022-08-25 15:51 ` Glenn Washburn
2022-08-25 19:33 ` Peter Zijlstra
2022-08-26 1:01 ` Glenn Washburn
2022-08-25 8:10 ` Peter Zijlstra
2022-08-25 19:23 ` Glenn Washburn
2022-08-25 19:59 ` Peter Zijlstra [this message]
2022-08-26 4:02 ` Glenn Washburn
2022-08-25 8:17 ` Peter Zijlstra
2022-08-25 15:46 ` Glenn Washburn
2022-08-25 8:03 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwfUharQEbykNhYp@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=development@efficientek.com \
--cc=dkiper@net-space.pl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.