From: Peter Zijlstra <peterz@infradead.org>
To: Glenn Washburn <development@efficientek.com>
Cc: The development of GNU GRUB <grub-devel@gnu.org>,
Daniel Kiper <dkiper@net-space.pl>
Subject: Re: [PATCH] term/serial: Add support for PCI serial devices
Date: Thu, 25 Aug 2022 21:33:31 +0200 [thread overview]
Message-ID: <YwfOi1cik4eD/uFV@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20220825105129.65b7b9f0@crass-HP-ZBook-15-G2>
On Thu, Aug 25, 2022 at 10:51:29AM -0500, Glenn Washburn wrote:
> On Thu, 25 Aug 2022 09:57:32 +0200
> Peter Zijlstra <peterz@infradead.org> wrote:
>
> > On Wed, Aug 24, 2022 at 06:36:27PM -0500, Glenn Washburn wrote:
> > > You will need to run the bootstrap script in the root of the repo to
> > > rebuild the build scripts before running configure and make.
> >
> > FWIW bootstrap scribbles INSTALL
>
> Its been a while since I've looked at this. But I believe that INSTALL
> is copied to INSTALL.grub. Is INSTALL getting overwritten with a
> default INSTALL not related to GRUB? I'm unsure of what you're really
> wanting to convey here. Something actionable?
When you do ./bootstrap; git diff returns a fairly sizable diff on
INSTALL, which is a bit weird and tends to sneak into patches (had to
kill it twice etc..).
So either add INSTALL to .gitignore, or fix it so that INSTALL doesn't
get scribbled would be my suggestion.
next prev parent reply other threads:[~2022-08-25 19:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 11:28 [PATCH] term/serial: Add support for PCI serial devices Peter Zijlstra
2022-08-24 20:13 ` Glenn Washburn
2022-08-24 21:01 ` Peter Zijlstra
2022-08-24 23:36 ` Glenn Washburn
2022-08-25 7:36 ` Peter Zijlstra
2022-08-25 7:57 ` Peter Zijlstra
2022-08-25 15:51 ` Glenn Washburn
2022-08-25 19:33 ` Peter Zijlstra [this message]
2022-08-26 1:01 ` Glenn Washburn
2022-08-25 8:10 ` Peter Zijlstra
2022-08-25 19:23 ` Glenn Washburn
2022-08-25 19:59 ` Peter Zijlstra
2022-08-26 4:02 ` Glenn Washburn
2022-08-25 8:17 ` Peter Zijlstra
2022-08-25 15:46 ` Glenn Washburn
2022-08-25 8:03 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwfOi1cik4eD/uFV@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=development@efficientek.com \
--cc=dkiper@net-space.pl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.