All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: Richard Palethorpe <rpalethorpe@suse.com>,
	Joerg Vehlow <joerg.vehlow@aox-tech.de>,
	linux-fsdevel@vger.kernel.org, ltp@lists.linux.it,
	automated-testing@lists.yoctoproject.org
Subject: Re: [LTP] [Automated-testing] [PATCH 4/6] tst_device: Use getopts
Date: Mon, 29 Aug 2022 13:42:22 +0200	[thread overview]
Message-ID: <YwymHvpxf/rP1kFT@pevik> (raw)
In-Reply-To: <YwydHBRWBX2NlqMR@yuki>

Hi Cyril,

> Hi!
> > size and filesystems are passed by -s and -f flags.
> > That will help to pass used filesystem.

> This part should be in the next commit description.

> > When it, add also -h.

> "When at it, ..."


> Otherwise it looks good.

Thanks for catching these!
I'll fix them in v2.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

WARNING: multiple messages have this Message-ID (diff)
From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it, Li Wang <liwang@redhat.com>,
	Martin Doucha <mdoucha@suse.cz>,
	Richard Palethorpe <rpalethorpe@suse.com>,
	Joerg Vehlow <joerg.vehlow@aox-tech.de>,
	automated-testing@lists.yoctoproject.org,
	Tim Bird <tim.bird@sony.com>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [Automated-testing] [PATCH 4/6] tst_device: Use getopts
Date: Mon, 29 Aug 2022 13:42:22 +0200	[thread overview]
Message-ID: <YwymHvpxf/rP1kFT@pevik> (raw)
In-Reply-To: <YwydHBRWBX2NlqMR@yuki>

Hi Cyril,

> Hi!
> > size and filesystems are passed by -s and -f flags.
> > That will help to pass used filesystem.

> This part should be in the next commit description.

> > When it, add also -h.

> "When at it, ..."


> Otherwise it looks good.

Thanks for catching these!
I'll fix them in v2.

Kind regards,
Petr

  reply	other threads:[~2022-08-29 11:42 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-27  0:28 [LTP] [PATCH 0/6] Track minimal size per filesystem Petr Vorel
2022-08-27  0:28 ` Petr Vorel
2022-08-27  0:28 ` [LTP] [PATCH 1/6] tst_fs_type: Add nsfs, vfat, squashfs to tst_fs_type_name() Petr Vorel
2022-08-27  0:28   ` Petr Vorel
2022-08-29 10:44   ` [LTP] " Cyril Hrubis
2022-08-29 10:44     ` Cyril Hrubis
2022-08-29 15:46   ` [LTP] " Bird, Tim
2022-08-29 15:46     ` Bird, Tim
2022-08-29 16:14     ` [LTP] " Petr Vorel
2022-08-29 16:14       ` Petr Vorel
2022-08-29 16:35       ` [LTP] " Bird, Tim
2022-08-29 16:35         ` Bird, Tim
2022-08-29 16:49         ` [LTP] " Petr Vorel
2022-08-29 16:49           ` Petr Vorel
2022-08-30  5:59   ` [LTP] " Li Wang
2022-08-27  0:28 ` [LTP] [PATCH 2/6] API: tst_device: Track minimal size per filesystem Petr Vorel
2022-08-27  0:28   ` Petr Vorel
2022-08-29 10:58   ` [LTP] " Cyril Hrubis
2022-08-29 10:58     ` Cyril Hrubis
2022-08-29 11:29     ` [LTP] " Petr Vorel
2022-08-29 11:29       ` Petr Vorel
2022-08-29 12:24       ` [LTP] [Automated-testing] " Cyril Hrubis
2022-08-29 12:24         ` Cyril Hrubis
2022-08-30  6:11     ` [LTP] " Li Wang
2022-08-27  0:28 ` [LTP] [PATCH 3/6] tst_test: Use 16 MB also for tmpfs Petr Vorel
2022-08-27  0:28   ` Petr Vorel
2022-08-29 11:00   ` [LTP] " Cyril Hrubis
2022-08-29 11:00     ` Cyril Hrubis
2022-08-30  6:12   ` [LTP] " Li Wang
2022-08-27  0:28 ` [LTP] [PATCH 4/6] tst_device: Use getopts Petr Vorel
2022-08-27  0:28   ` Petr Vorel
2022-08-29 11:03   ` [LTP] [Automated-testing] " Cyril Hrubis
2022-08-29 11:03     ` Cyril Hrubis
2022-08-29 11:42     ` Petr Vorel [this message]
2022-08-29 11:42       ` Petr Vorel
2022-08-30  6:14   ` [LTP] " Li Wang
2022-08-27  0:28 ` [LTP] [PATCH 5/6] tst_device: Add support -f filesystem Petr Vorel
2022-08-27  0:28   ` Petr Vorel
2022-08-29 11:04   ` [LTP] " Cyril Hrubis
2022-08-29 11:04     ` Cyril Hrubis
2022-08-30  6:14   ` [LTP] " Li Wang
2022-08-27  0:28 ` [LTP] [PATCH 6/6] tst_test.sh: Pass used filesystem to tst_device Petr Vorel
2022-08-27  0:28   ` Petr Vorel
2022-08-29 11:05   ` [LTP] " Cyril Hrubis
2022-08-29 11:05     ` Cyril Hrubis
2022-08-30  6:16   ` [LTP] " Li Wang
2022-08-29 10:43 ` [LTP] [Automated-testing] [PATCH 0/6] Track minimal size per filesystem Cyril Hrubis
2022-08-29 10:43   ` Cyril Hrubis
2022-08-29 11:39   ` [LTP] " Petr Vorel
2022-08-29 11:39     ` Petr Vorel
2022-08-30  5:52     ` [LTP] " Li Wang
2022-08-30  8:18       ` Petr Vorel
2022-08-30  8:18         ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YwymHvpxf/rP1kFT@pevik \
    --to=pvorel@suse.cz \
    --cc=automated-testing@lists.yoctoproject.org \
    --cc=chrubis@suse.cz \
    --cc=joerg.vehlow@aox-tech.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=ltp@lists.linux.it \
    --cc=rpalethorpe@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.