From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Olof Johansson <olof@lixom.net>
Cc: Li Yang <leoyang.li@nxp.com>,
shawnguo@kernel.org, devicetree@vger.kernel.org,
robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
Subject: Re: [PATCH v4 1/2] arm64: dts: lx2160a: update PCIe nodes to match rev2 silicon
Date: Mon, 12 Sep 2022 21:33:38 +0100 [thread overview]
Message-ID: <Yx+XonDqmpE4KGhD@shell.armlinux.org.uk> (raw)
In-Reply-To: <CAOesGMjsegmLUVxbjZJ3kgxnDkVTyxy5BB=is2CM_7Se7TQrWQ@mail.gmail.com>
On Mon, Sep 12, 2022 at 11:54:06AM -0700, Olof Johansson wrote:
> On Mon, Sep 12, 2022 at 12:05 AM Olof Johansson <olof@lixom.net> wrote:
> >
> > Hi,
> >
> > On Wed, Aug 17, 2022 at 1:26 PM Li Yang <leoyang.li@nxp.com> wrote:
> > >
> > > The original dts was created based on the non-production rev1 silicon
> > > which was only used for evaluation. Update the PCIe nodes to align with
> > > the different controller used in production rev2 silicon.
> >
> > How can I confirm what version of silicon I have on a system?
> >
> > My non-evaluation commercially purchased system (HoneyComb LX2K) has:
> >
> > # cat /sys/bus/soc/devices/soc0/revision
> > 1.0
> >
> > And I will be really grumpy if this system stops working. It's what I
> > use to do all my maintainer work, even if that's been fairly dormant
> > this year.
> >
> > It's overall setting off red flags to update an in-place devicetree to
> > a "new revision" of silicon instead of adding a new DT for said
> > revision. 2160A has been on the market for several years, so it just
> > seems odd to all of the sudden retroactively make things
> > non-backwards-compatible.
>
> Confirmed that this patch renders my HoneyComb unbootable -- PCIe doesn't probe.
>
> Shawn, please revert, and be on the lookout for similar problematic
> approaches in the future. Thanks!
I think you may also need to beware of the MC firmware revision - I
seem to remember reading in the changelog notes for it that NXP
dropped support in the MC firmware for the older silicon, though I
may be misremembering. It's been a while since I really looked at
the LX2160A from the point of view of maintaining or developing
anything for it.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Olof Johansson <olof@lixom.net>
Cc: Li Yang <leoyang.li@nxp.com>,
shawnguo@kernel.org, devicetree@vger.kernel.org,
robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
Subject: Re: [PATCH v4 1/2] arm64: dts: lx2160a: update PCIe nodes to match rev2 silicon
Date: Mon, 12 Sep 2022 21:33:38 +0100 [thread overview]
Message-ID: <Yx+XonDqmpE4KGhD@shell.armlinux.org.uk> (raw)
In-Reply-To: <CAOesGMjsegmLUVxbjZJ3kgxnDkVTyxy5BB=is2CM_7Se7TQrWQ@mail.gmail.com>
On Mon, Sep 12, 2022 at 11:54:06AM -0700, Olof Johansson wrote:
> On Mon, Sep 12, 2022 at 12:05 AM Olof Johansson <olof@lixom.net> wrote:
> >
> > Hi,
> >
> > On Wed, Aug 17, 2022 at 1:26 PM Li Yang <leoyang.li@nxp.com> wrote:
> > >
> > > The original dts was created based on the non-production rev1 silicon
> > > which was only used for evaluation. Update the PCIe nodes to align with
> > > the different controller used in production rev2 silicon.
> >
> > How can I confirm what version of silicon I have on a system?
> >
> > My non-evaluation commercially purchased system (HoneyComb LX2K) has:
> >
> > # cat /sys/bus/soc/devices/soc0/revision
> > 1.0
> >
> > And I will be really grumpy if this system stops working. It's what I
> > use to do all my maintainer work, even if that's been fairly dormant
> > this year.
> >
> > It's overall setting off red flags to update an in-place devicetree to
> > a "new revision" of silicon instead of adding a new DT for said
> > revision. 2160A has been on the market for several years, so it just
> > seems odd to all of the sudden retroactively make things
> > non-backwards-compatible.
>
> Confirmed that this patch renders my HoneyComb unbootable -- PCIe doesn't probe.
>
> Shawn, please revert, and be on the lookout for similar problematic
> approaches in the future. Thanks!
I think you may also need to beware of the MC firmware revision - I
seem to remember reading in the changelog notes for it that NXP
dropped support in the MC firmware for the older silicon, though I
may be misremembering. It's been a while since I really looked at
the LX2160A from the point of view of maintaining or developing
anything for it.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-09-12 20:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 20:25 [PATCH v4 0/2] lx216x DTS updates Li Yang
2022-08-17 20:25 ` Li Yang
2022-08-17 20:25 ` [PATCH v4 1/2] arm64: dts: lx2160a: update PCIe nodes to match rev2 silicon Li Yang
2022-08-17 20:25 ` Li Yang
2022-09-12 7:05 ` Olof Johansson
2022-09-12 7:05 ` Olof Johansson
2022-09-12 18:54 ` Olof Johansson
2022-09-12 18:54 ` Olof Johansson
2022-09-12 20:33 ` Russell King (Oracle) [this message]
2022-09-12 20:33 ` Russell King (Oracle)
2022-09-13 2:34 ` Olof Johansson
2022-09-13 2:34 ` Olof Johansson
2022-09-12 20:25 ` Leo Li
2022-09-12 20:25 ` Leo Li
2022-09-13 2:03 ` Shawn Guo
2022-09-13 2:03 ` Shawn Guo
2022-09-12 21:49 ` Leo Li
2022-09-12 21:49 ` Leo Li
2022-08-17 20:25 ` [PATCH v4 2/2] arm64: dts: lx2160a: add pcie EP mode nodes Li Yang
2022-08-17 20:25 ` Li Yang
2022-08-22 3:35 ` [PATCH v4 0/2] lx216x DTS updates Shawn Guo
2022-08-22 3:35 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yx+XonDqmpE4KGhD@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Zhiqiang.Hou@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.