From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] September LTP release
Date: Mon, 12 Sep 2022 11:45:10 +0200 [thread overview]
Message-ID: <Yx7/prIE4LqEOM+P@pevik> (raw)
In-Reply-To: <Yx79pc7IVdLrKmw1@yuki>
> Hi!
> > FYI in minor fanotify cleanup I just wait to get acked TST_EXP_FD_ERRNO [1]
> > It might be usable only in fanotify, but I'd keep it in tst_test_macros.h
> > Sooner or later it will be usable by other tests.
> > I'm also not sure about the name.
> Since it's calling TST_EXP_FD() or TST_EXP_FAIL() the logical name for
> it would be TST_EXP_FD_OR_FAIL()
I guess I should use TST_EXP_FD_OR_FAIL(). If anybody objects can I merge it
with your ack? Of course I can send proper v2 and wait after the release.
> > If you like this idea, in the future we might
> > add more TST_EXP_*_ERRNO(SCALL, ERRNO, ...) macros, i.e. calling TST_EXP_FAIL or TST_EXP_PASS
> > (thus name could be TST_EXP_PASS_FAIL).
> Without _OR_ between PASS and FAIL the name is kind of confusing. And
> it's not that much better even as TST_EXP_PASS_OR_FAIL() but I cannot
> think of anything better at the moment.
TST_EXP_PASS_OR_FAIL() sounds good. I'll try to add it with some tests converted
(after the release).
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-09-12 9:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 8:49 [LTP] September LTP release Cyril Hrubis
2022-09-09 10:39 ` Li Wang
2022-09-09 11:10 ` Cyril Hrubis
2022-09-09 14:36 ` Petr Vorel
2022-09-13 7:11 ` Li Wang
2022-09-13 11:50 ` Cyril Hrubis
2022-09-26 9:58 ` Cyril Hrubis
2022-09-26 10:13 ` Li Wang
2022-09-26 12:26 ` Petr Vorel
2022-09-27 7:44 ` Li Wang
2022-09-27 8:10 ` Petr Vorel
2022-09-27 8:25 ` Li Wang
2022-09-30 14:00 ` Petr Vorel
2022-09-26 10:43 ` Petr Vorel
2022-09-26 10:48 ` Petr Vorel
2022-09-09 14:56 ` Petr Vorel
2022-09-12 9:36 ` Cyril Hrubis
2022-09-12 9:45 ` Petr Vorel [this message]
2022-09-13 8:19 ` xuyang2018.jy
2022-09-13 9:23 ` Cyril Hrubis
2022-09-19 15:31 ` Petr Vorel
2022-09-23 11:01 ` Petr Vorel
2022-09-23 11:59 ` Cyril Hrubis
2022-09-23 12:16 ` Petr Vorel
2022-09-26 9:49 ` Cyril Hrubis
2022-09-30 10:05 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yx7/prIE4LqEOM+P@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.