Re: [EXT] Re: [PATCH V4 2/4] dmaengine: imx-sdma: support hdmi audio

[Vinod Koul <vkoul@kernel.org>]

On 06-09-22, 05:04, Joy Zou wrote:
> 
> > -----Original Message-----
> > From: Vinod Koul <vkoul@kernel.org>
> > Sent: 2022年9月5日 19:03
> > To: Joy Zou <joy.zou@nxp.com>
> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; S.J. Wang
> > <shengjiu.wang@nxp.com>; shawnguo@kernel.org; s.hauer@pengutronix.de;
> > kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx
> > <linux-imx@nxp.com>; dmaengine@vger.kernel.org;
> > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> > Subject: Re: [EXT] Re: [PATCH V4 2/4] dmaengine: imx-sdma: support hdmi
> > audio
> > 
> > Caution: EXT Email
> > 
> > On 05-09-22, 09:07, Joy Zou wrote:
> > > > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > > > >> On 01-09-22, 10:00, Joy Zou wrote:
> > > > >>> Add hdmi audio support in sdma.
> > > > >>
> > > > >> Pls make sure you thread your patches properly! They are broken
> > threads!
> > > > > I am trying to support for hdmi audio feature on community driver
> > > > drivers/gpu/drm/bridge/synopsys/.
> > > >
> > > > This does not answer to the problem you patches do not compose
> > > > proper thread. v5 which you sent now is also broken. Supporting HDMI
> > > > audio feature does not prevent you to send patches correctly, right?
> > > I am trying to support for hdmi audio feature on community driver
> > drivers/gpu/drm/bridge/synopsys/.
> > > I think the feature may take some time because I am not audio driver owner.
> > I only want to update the others patch as soon as possible, so I send the patch
> > v5. I am also solving the thread patches properly.
> > 
> > Sorry you have not!
> > 
> > In my inbox, v5 1/2 and 2/2 do not appear as a single thread
> > 
> > Please fix the way you send the series and send them together, it is very
> > difficult to review when they are disjoint
> > 
> > FWIW, I checked the v5 2/2 and it does not have in-reply-to set, which should
> > point to 1/2.. If you are using git send-email, point both the patches to it so
> > that it will do that correctly for you
> I am very sorry. I find the root cause that the patch not appear as a single thread. I use the
> git send-mail to send separately. I also know the patchwork can check it.

No, please point the whole series to git send-email

For example:
$ mkdir temp; cd temp
$ git format-patch -2 --cover-letter -v <patch version>
$ <update cover letter>
$ <run checkpatch etc and verify patches are in order>
$ git send-email *

That should do it for you!

> I'm so sorry to waste your time and effort. I am very grateful to your comments.
> I will change next patch.
> BR
> Joy Zou
> 
> > 
> > --
> > ~Vinod

-- 
~Vinod