All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH][next] powerpc: Fix fall-through warning for Clang
@ 2022-09-06 21:32 ` Gustavo A. R. Silva
  0 siblings, 0 replies; 8+ messages in thread
From: Gustavo A. R. Silva @ 2022-09-06 21:32 UTC (permalink / raw)
  To: Scott Wood, Michael Ellerman, Nicholas Piggin, Christophe Leroy
  Cc: linuxppc-dev, linux-kernel, Gustavo A. R. Silva, linux-hardening

Fix the following fallthrough warning:

arch/powerpc/platforms/85xx/mpc85xx_cds.c:161:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]

Link: https://github.com/KSPP/linux/issues/198
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/lkml/202209061224.KxORRGVg-lkp@intel.com/
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
 arch/powerpc/platforms/85xx/mpc85xx_cds.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/platforms/85xx/mpc85xx_cds.c b/arch/powerpc/platforms/85xx/mpc85xx_cds.c
index 48f3acfece0b..0b8f2101c5fb 100644
--- a/arch/powerpc/platforms/85xx/mpc85xx_cds.c
+++ b/arch/powerpc/platforms/85xx/mpc85xx_cds.c
@@ -159,6 +159,7 @@ static void __init mpc85xx_cds_pci_irq_fixup(struct pci_dev *dev)
 			else
 				dev->irq = 10;
 			pci_write_config_byte(dev, PCI_INTERRUPT_LINE, dev->irq);
+			break;
 		default:
 			break;
 		}
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH][next] powerpc: Fix fall-through warning for Clang
@ 2022-09-06 21:32 ` Gustavo A. R. Silva
  0 siblings, 0 replies; 8+ messages in thread
From: Gustavo A. R. Silva @ 2022-09-06 21:32 UTC (permalink / raw)
  To: Scott Wood, Michael Ellerman, Nicholas Piggin, Christophe Leroy
  Cc: linux-hardening, linuxppc-dev, linux-kernel, Gustavo A. R. Silva

Fix the following fallthrough warning:

arch/powerpc/platforms/85xx/mpc85xx_cds.c:161:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]

Link: https://github.com/KSPP/linux/issues/198
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/lkml/202209061224.KxORRGVg-lkp@intel.com/
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
 arch/powerpc/platforms/85xx/mpc85xx_cds.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/platforms/85xx/mpc85xx_cds.c b/arch/powerpc/platforms/85xx/mpc85xx_cds.c
index 48f3acfece0b..0b8f2101c5fb 100644
--- a/arch/powerpc/platforms/85xx/mpc85xx_cds.c
+++ b/arch/powerpc/platforms/85xx/mpc85xx_cds.c
@@ -159,6 +159,7 @@ static void __init mpc85xx_cds_pci_irq_fixup(struct pci_dev *dev)
 			else
 				dev->irq = 10;
 			pci_write_config_byte(dev, PCI_INTERRUPT_LINE, dev->irq);
+			break;
 		default:
 			break;
 		}
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH][next] powerpc: Fix fall-through warning for Clang
  2022-09-06 21:32 ` Gustavo A. R. Silva
@ 2022-09-07 23:34   ` Kees Cook
  -1 siblings, 0 replies; 8+ messages in thread
From: Kees Cook @ 2022-09-07 23:34 UTC (permalink / raw)
  To: Gustavo A. R. Silva
  Cc: Scott Wood, Michael Ellerman, Nicholas Piggin, Christophe Leroy,
	linuxppc-dev, linux-kernel, linux-hardening

On Tue, Sep 06, 2022 at 10:32:13PM +0100, Gustavo A. R. Silva wrote:
> Fix the following fallthrough warning:
> 
> arch/powerpc/platforms/85xx/mpc85xx_cds.c:161:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
> 
> Link: https://github.com/KSPP/linux/issues/198
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/lkml/202209061224.KxORRGVg-lkp@intel.com/
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>

Thanks!

Reviewed-by: Kees Cook <keescook@chromium.org>

-- 
Kees Cook

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH][next] powerpc: Fix fall-through warning for Clang
@ 2022-09-07 23:34   ` Kees Cook
  0 siblings, 0 replies; 8+ messages in thread
From: Kees Cook @ 2022-09-07 23:34 UTC (permalink / raw)
  To: Gustavo A. R. Silva
  Cc: linux-kernel, Scott Wood, Nicholas Piggin, linuxppc-dev,
	linux-hardening

On Tue, Sep 06, 2022 at 10:32:13PM +0100, Gustavo A. R. Silva wrote:
> Fix the following fallthrough warning:
> 
> arch/powerpc/platforms/85xx/mpc85xx_cds.c:161:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
> 
> Link: https://github.com/KSPP/linux/issues/198
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/lkml/202209061224.KxORRGVg-lkp@intel.com/
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>

Thanks!

Reviewed-by: Kees Cook <keescook@chromium.org>

-- 
Kees Cook

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH][next] powerpc: Fix fall-through warning for Clang
  2022-09-06 21:32 ` Gustavo A. R. Silva
@ 2022-09-23 11:13   ` Michael Ellerman
  -1 siblings, 0 replies; 8+ messages in thread
From: Michael Ellerman @ 2022-09-23 11:13 UTC (permalink / raw)
  To: Christophe Leroy, Nicholas Piggin, Gustavo A. R. Silva,
	Michael Ellerman, Scott Wood
  Cc: linux-kernel, linuxppc-dev, linux-hardening

On Tue, 6 Sep 2022 22:32:13 +0100, Gustavo A. R. Silva wrote:
> Fix the following fallthrough warning:
> 
> arch/powerpc/platforms/85xx/mpc85xx_cds.c:161:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
> 
> 

Applied to powerpc/next.

[1/1] powerpc: Fix fall-through warning for Clang
      https://git.kernel.org/powerpc/c/d4d944ff68cb1f896d3f3b1af0bc656949dc626a

cheers

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH][next] powerpc: Fix fall-through warning for Clang
@ 2022-09-23 11:13   ` Michael Ellerman
  0 siblings, 0 replies; 8+ messages in thread
From: Michael Ellerman @ 2022-09-23 11:13 UTC (permalink / raw)
  To: Christophe Leroy, Nicholas Piggin, Gustavo A. R. Silva,
	Michael Ellerman, Scott Wood
  Cc: linuxppc-dev, linux-kernel, linux-hardening

On Tue, 6 Sep 2022 22:32:13 +0100, Gustavo A. R. Silva wrote:
> Fix the following fallthrough warning:
> 
> arch/powerpc/platforms/85xx/mpc85xx_cds.c:161:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
> 
> 

Applied to powerpc/next.

[1/1] powerpc: Fix fall-through warning for Clang
      https://git.kernel.org/powerpc/c/d4d944ff68cb1f896d3f3b1af0bc656949dc626a

cheers

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH][next] powerpc: Fix fall-through warning for Clang
  2022-09-23 11:13   ` Michael Ellerman
@ 2022-09-23 16:57     ` Gustavo A. R. Silva
  -1 siblings, 0 replies; 8+ messages in thread
From: Gustavo A. R. Silva @ 2022-09-23 16:57 UTC (permalink / raw)
  To: Michael Ellerman, Christophe Leroy, Nicholas Piggin,
	Gustavo A. R. Silva, Michael Ellerman, Scott Wood
  Cc: linux-kernel, linuxppc-dev, linux-hardening


> Applied to powerpc/next.

Great. :)

Thanks, Michael.
--
Gustavo

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH][next] powerpc: Fix fall-through warning for Clang
@ 2022-09-23 16:57     ` Gustavo A. R. Silva
  0 siblings, 0 replies; 8+ messages in thread
From: Gustavo A. R. Silva @ 2022-09-23 16:57 UTC (permalink / raw)
  To: Michael Ellerman, Christophe Leroy, Nicholas Piggin,
	Gustavo A. R. Silva, Michael Ellerman, Scott Wood
  Cc: linuxppc-dev, linux-kernel, linux-hardening


> Applied to powerpc/next.

Great. :)

Thanks, Michael.
--
Gustavo

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-09-23 17:05 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-06 21:32 [PATCH][next] powerpc: Fix fall-through warning for Clang Gustavo A. R. Silva
2022-09-06 21:32 ` Gustavo A. R. Silva
2022-09-07 23:34 ` Kees Cook
2022-09-07 23:34   ` Kees Cook
2022-09-23 11:13 ` Michael Ellerman
2022-09-23 11:13   ` Michael Ellerman
2022-09-23 16:57   ` Gustavo A. R. Silva
2022-09-23 16:57     ` Gustavo A. R. Silva

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.