Re: [PATCH v4] arm64: dts: qcom: sc7280: Fix Dmic no sound on villager-r1

[Matthias Kaehlcke <mka@chromium.org>]

On Mon, Aug 29, 2022 at 03:20:53PM -0700, Matthias Kaehlcke wrote:
> On Fri, Aug 26, 2022 at 10:14:58AM -0700, Doug Anderson wrote:
> > Hi,
> > 
> > On Thu, Aug 25, 2022 at 11:56 PM Judy Hsiao <judyhsiao@chromium.org> wrote:
> > >
> > > Fix the DMIC no sound issue of villager-r1 by using "PP1800_L2C" as the
> > > DMIC power source to match the hardware schematic.
> > >
> > > This patch:
> > >    1. set vdd-micb-supply to PP1800_L2C as the MIC Bias voltage regulator.
> > >    2. In audio-routing, set VA DMIC01~VA DMIC03 to use the vdd-micb-supply
> > >       setting.
> > >
> > > Co-developed-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> > > Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> > > Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
> > > ---
> > > Changes since V3:
> > >   -- Update the commit message and fix extra blank line.
> > > Changes since V2:
> > >   -- Update the commit message.
> > > Changes since V1:
> > >   -- Update the commit message.
> > >
> > > This patch depends on:
> > > arm64: dts: qcom: sc7280: Add herobrine-villager-r1. [1]
> > >
> > > [1] https://patchwork.kernel.org/patch/12929106
> > 
> > After applying your [1] then your patch applies without merge
> > conflicts. However, it still doesn't compile. You also depend on
> > whatever patch adds the nodes "lpass_va_macro" and "sound" since
> > you're referencing them in your patch. I haven't been keeping track of
> > the latest status of all the audio patches, so I myself can't point to
> > exactly what patches you depend on and whether those patches are ready
> > to land.
> > 
> > In any case, the contents of this patch seem OK assuming the dependent
> > patches cause something that looks like the current (downstream)
> > chromeos-5.15 tree.
> > 
> > Reviewed-by: Douglas Anderson <dianders@chromium.org>
> 
> To my best knowledge the dependencies of the audio mess are (roughly in
> order):
> 
> Add support for audio clock gating resets for SC7280 (v8)
> https://patchwork.kernel.org/project/linux-arm-msm/list/?series=671887
>   ready to land? (patch 2 has a minor comment about SoB tag)

The comment has been addressed in v9:

https://patchwork.kernel.org/project/linux-arm-msm/list/?series=673055

So it seems all the audio bits should be ready to land.

Satya: please make sure to include change logs in all future patches to
help reviewers understand what changed in each version.

> Add DT support for audio clock gating resets for SC7280 (v4)
> https://patchwork.kernel.org/project/linux-arm-msm/list/?series=666480
>   ready to land after dependencies land
> 
> Add soundcard support for sc7280 based platforms (v14)
> https://patchwork.kernel.org/project/linux-arm-msm/list/?series=657417
>   ready to land after dependencies land
> 
> Add dtsi for sc7280 herobrine boards that using rt5682 codec (v3)
> https://patchwork.kernel.org/project/linux-arm-msm/list/?series=644812
>   ready to land after dependencies land
> 
> Add new board revision and LTE SKUs for sc7280-villager family (v8)
> https://patchwork.kernel.org/project/linux-arm-msm/list/?series=663014
>   ready to land after dependencies land
> 
> arm64: dts: qcom: sc7280: Fix Dmic no sound on villager-r1 (v4)
> https://patchwork.kernel.org/project/linux-arm-msm/patch/20220826065621.2255795-1-judyhsiao@chromium.org/
>   ready to land after dependencies land
> 
> So it looks like things are generally ready to land, unless [1] needs a
> re-spin to fix the SoB tag.
> 
> m.
> 
> [1] https://patchwork.kernel.org/project/linux-arm-msm/patch/1661754153-14813-3-git-send-email-quic_c_skakit@quicinc.com/