From: Lee Jones <lee@kernel.org>
To: Yu Zhe <yuzhe@nfschina.com>
Cc: shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, liqiong@nfschina.com
Subject: Re: [PATCH] mfd: fix tests for platform_get_irq() failure
Date: Thu, 8 Sep 2022 09:21:09 +0100 [thread overview]
Message-ID: <Yxml9asIAhYkY240@google.com> (raw)
In-Reply-To: <20220825010911.5324-1-yuzhe@nfschina.com>
On Thu, 25 Aug 2022, Yu Zhe wrote:
> The platform_get_irq() returns negative error codes. It can't actually
> return zero.
>
> Signed-off-by: Yu Zhe <yuzhe@nfschina.com>
> ---
> drivers/mfd/fsl-imx25-tsadc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Already fixed: https://lore.kernel.org/r/YvTfkbVQWYKMKS/t@kili
> diff --git a/drivers/mfd/fsl-imx25-tsadc.c b/drivers/mfd/fsl-imx25-tsadc.c
> index 37e5e02a1d05..8ccdfd73e694 100644
> --- a/drivers/mfd/fsl-imx25-tsadc.c
> +++ b/drivers/mfd/fsl-imx25-tsadc.c
> @@ -179,7 +179,7 @@ static int mx25_tsadc_remove(struct platform_device *pdev)
> struct mx25_tsadc *tsadc = platform_get_drvdata(pdev);
> int irq = platform_get_irq(pdev, 0);
>
> - if (irq) {
> + if (irq > 0) {
> irq_set_chained_handler_and_data(irq, NULL, NULL);
> irq_domain_remove(tsadc->domain);
> }
--
Lee Jones [李琼斯]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee@kernel.org>
To: Yu Zhe <yuzhe@nfschina.com>
Cc: shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, liqiong@nfschina.com
Subject: Re: [PATCH] mfd: fix tests for platform_get_irq() failure
Date: Thu, 8 Sep 2022 09:21:09 +0100 [thread overview]
Message-ID: <Yxml9asIAhYkY240@google.com> (raw)
In-Reply-To: <20220825010911.5324-1-yuzhe@nfschina.com>
On Thu, 25 Aug 2022, Yu Zhe wrote:
> The platform_get_irq() returns negative error codes. It can't actually
> return zero.
>
> Signed-off-by: Yu Zhe <yuzhe@nfschina.com>
> ---
> drivers/mfd/fsl-imx25-tsadc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Already fixed: https://lore.kernel.org/r/YvTfkbVQWYKMKS/t@kili
> diff --git a/drivers/mfd/fsl-imx25-tsadc.c b/drivers/mfd/fsl-imx25-tsadc.c
> index 37e5e02a1d05..8ccdfd73e694 100644
> --- a/drivers/mfd/fsl-imx25-tsadc.c
> +++ b/drivers/mfd/fsl-imx25-tsadc.c
> @@ -179,7 +179,7 @@ static int mx25_tsadc_remove(struct platform_device *pdev)
> struct mx25_tsadc *tsadc = platform_get_drvdata(pdev);
> int irq = platform_get_irq(pdev, 0);
>
> - if (irq) {
> + if (irq > 0) {
> irq_set_chained_handler_and_data(irq, NULL, NULL);
> irq_domain_remove(tsadc->domain);
> }
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2022-09-08 8:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 1:09 [PATCH] mfd: fix tests for platform_get_irq() failure Yu Zhe
2022-08-25 1:09 ` Yu Zhe
2022-09-08 8:21 ` Lee Jones [this message]
2022-09-08 8:21 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yxml9asIAhYkY240@google.com \
--to=lee@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liqiong@nfschina.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=yuzhe@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.