* [PATCH] perf lock: Remove redundant word 'contention' in help message
@ 2022-09-08 1:48 Yang Jihong
2022-09-08 6:59 ` Namhyung Kim
0 siblings, 1 reply; 3+ messages in thread
From: Yang Jihong @ 2022-09-08 1:48 UTC (permalink / raw)
To: peterz, mingo, acme, mark.rutland, alexander.shishkin, jolsa,
namhyung, linux-perf-users, linux-kernel
Cc: yangjihong1
Before:
# perf lock -h
Usage: perf lock [<options>] {record|report|script|info|contention|contention}
-D, --dump-raw-trace dump raw trace in ASCII
-f, --force don't complain, do it
-i, --input <file> input file name
-v, --verbose be more verbose (show symbol address, etc)
--kallsyms <file>
kallsyms pathname
--vmlinux <file> vmlinux pathname
After:
# perf lock -h
Usage: perf lock [<options>] {record|report|script|info|contention}
-D, --dump-raw-trace dump raw trace in ASCII
-f, --force don't complain, do it
-i, --input <file> input file name
-v, --verbose be more verbose (show symbol address, etc)
--kallsyms <file>
kallsyms pathname
--vmlinux <file> vmlinux pathname
Fixes: 528b9cab3b81 ("perf lock: Add 'contention' subcommand")
Signed-off-by: Yang Jihong <yangjihong1@huawei.com>
---
tools/perf/builtin-lock.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
index dd11d3471baf..ea40ae52cd2c 100644
--- a/tools/perf/builtin-lock.c
+++ b/tools/perf/builtin-lock.c
@@ -1874,8 +1874,7 @@ int cmd_lock(int argc, const char **argv)
NULL
};
const char *const lock_subcommands[] = { "record", "report", "script",
- "info", "contention",
- "contention", NULL };
+ "info", "contention", NULL };
const char *lock_usage[] = {
NULL,
NULL
--
2.30.GIT
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] perf lock: Remove redundant word 'contention' in help message
2022-09-08 1:48 [PATCH] perf lock: Remove redundant word 'contention' in help message Yang Jihong
@ 2022-09-08 6:59 ` Namhyung Kim
2022-09-08 18:24 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: Namhyung Kim @ 2022-09-08 6:59 UTC (permalink / raw)
To: Yang Jihong
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, linux-perf-users,
linux-kernel
Hello,
On Wed, Sep 7, 2022 at 6:52 PM Yang Jihong <yangjihong1@huawei.com> wrote:
>
> Before:
> # perf lock -h
>
> Usage: perf lock [<options>] {record|report|script|info|contention|contention}
>
> -D, --dump-raw-trace dump raw trace in ASCII
> -f, --force don't complain, do it
> -i, --input <file> input file name
> -v, --verbose be more verbose (show symbol address, etc)
> --kallsyms <file>
> kallsyms pathname
> --vmlinux <file> vmlinux pathname
>
> After:
> # perf lock -h
>
> Usage: perf lock [<options>] {record|report|script|info|contention}
>
> -D, --dump-raw-trace dump raw trace in ASCII
> -f, --force don't complain, do it
> -i, --input <file> input file name
> -v, --verbose be more verbose (show symbol address, etc)
> --kallsyms <file>
> kallsyms pathname
> --vmlinux <file> vmlinux pathname
>
> Fixes: 528b9cab3b81 ("perf lock: Add 'contention' subcommand")
> Signed-off-by: Yang Jihong <yangjihong1@huawei.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks for the fix!
Namhyung
> ---
> tools/perf/builtin-lock.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
> index dd11d3471baf..ea40ae52cd2c 100644
> --- a/tools/perf/builtin-lock.c
> +++ b/tools/perf/builtin-lock.c
> @@ -1874,8 +1874,7 @@ int cmd_lock(int argc, const char **argv)
> NULL
> };
> const char *const lock_subcommands[] = { "record", "report", "script",
> - "info", "contention",
> - "contention", NULL };
> + "info", "contention", NULL };
> const char *lock_usage[] = {
> NULL,
> NULL
> --
> 2.30.GIT
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] perf lock: Remove redundant word 'contention' in help message
2022-09-08 6:59 ` Namhyung Kim
@ 2022-09-08 18:24 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2022-09-08 18:24 UTC (permalink / raw)
To: Namhyung Kim
Cc: Yang Jihong, Peter Zijlstra, Ingo Molnar, Mark Rutland,
Alexander Shishkin, Jiri Olsa, linux-perf-users, linux-kernel
Em Wed, Sep 07, 2022 at 11:59:27PM -0700, Namhyung Kim escreveu:
> On Wed, Sep 7, 2022 at 6:52 PM Yang Jihong <yangjihong1@huawei.com> wrote:
> > Fixes: 528b9cab3b81 ("perf lock: Add 'contention' subcommand")
> > Signed-off-by: Yang Jihong <yangjihong1@huawei.com>
> Acked-by: Namhyung Kim <namhyung@kernel.org>
> Thanks for the fix!
Thanks, applied.
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-08 18:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-08 1:48 [PATCH] perf lock: Remove redundant word 'contention' in help message Yang Jihong
2022-09-08 6:59 ` Namhyung Kim
2022-09-08 18:24 ` Arnaldo Carvalho de Melo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.