* [PATCH] Input: melfas_mip4 - fix return value check in mip4_probe()
@ 2022-09-24 3:07 Yang Yingliang
2022-09-25 5:10 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2022-09-24 3:07 UTC (permalink / raw)
To: linux-input; +Cc: jeesw, dmitry.torokhov, rydberg, yangyingliang
devm_gpiod_get_optional() may return ERR_PTR(-EPROBE_DEFER),
add a minus sign to fix it.
Fixes: 6ccb1d8f78bd ("Input: add MELFAS MIP4 Touchscreen driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/input/touchscreen/melfas_mip4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/melfas_mip4.c b/drivers/input/touchscreen/melfas_mip4.c
index 2745bf1aee38..83f4be05e27b 100644
--- a/drivers/input/touchscreen/melfas_mip4.c
+++ b/drivers/input/touchscreen/melfas_mip4.c
@@ -1453,7 +1453,7 @@ static int mip4_probe(struct i2c_client *client, const struct i2c_device_id *id)
"ce", GPIOD_OUT_LOW);
if (IS_ERR(ts->gpio_ce)) {
error = PTR_ERR(ts->gpio_ce);
- if (error != EPROBE_DEFER)
+ if (error != -EPROBE_DEFER)
dev_err(&client->dev,
"Failed to get gpio: %d\n", error);
return error;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: melfas_mip4 - fix return value check in mip4_probe()
2022-09-24 3:07 [PATCH] Input: melfas_mip4 - fix return value check in mip4_probe() Yang Yingliang
@ 2022-09-25 5:10 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2022-09-25 5:10 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-input, jeesw, rydberg
On Sat, Sep 24, 2022 at 11:07:15AM +0800, Yang Yingliang wrote:
> devm_gpiod_get_optional() may return ERR_PTR(-EPROBE_DEFER),
> add a minus sign to fix it.
>
> Fixes: 6ccb1d8f78bd ("Input: add MELFAS MIP4 Touchscreen driver")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-25 5:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-24 3:07 [PATCH] Input: melfas_mip4 - fix return value check in mip4_probe() Yang Yingliang
2022-09-25 5:10 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.