From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Trevor Wu <trevor.wu@mediatek.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
lgirdwood@gmail.com, tiwai@suse.com,
Mark Brown <broonie@kernel.org>,
linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com,
linux-arm-kernel@lists.infradead.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH] ASoC: mediatek: mt8195-mt6359: Use snd_soc_pm_ops instead of custom ops
Date: Fri, 23 Sep 2022 13:03:51 +0800 [thread overview]
Message-ID: <Yy0+N13mJlGZE9E4@google.com> (raw)
In-Reply-To: <978af4cc1a8bfa92675bb201947cfdac1e5429f1.camel@mediatek.com>
On Fri, Sep 23, 2022 at 12:39:54PM +0800, Trevor Wu wrote:
> On Thu, 2022-09-22 at 16:10 +0200, AngeloGioacchino Del Regno wrote:
> > Il 22/09/22 15:30, Mark Brown ha scritto:
> > > On Thu, Sep 22, 2022 at 07:26:21PM +0800, Tzung-Bi Shih wrote:
> > >
> > > > snd_soc_pm_ops[1] sets some more fields. I'm not quite sure
> > > > whether
> > > > it would introduce any side effect or not. Perhaps Trevor could
> > > > provide some suggestions.
> > >
> > > If it does it should be to fix isues rather than introduce new
> > > problems - I suspect the other operations just don't work
> > > currently.
> >
> > From my upstream tests, this didn't introduce any issues, that's why
> > I've
> > sent this patch.
> >
> > In any case, let's check with Trevor, just as to be extremely sure,
> > but please
> > use an upstream kernel for eventual tests, as there are quite a bit
> > of changes
> > between 5.10 and current upstream.
> >
> > Cheers,
> > Angelo
>
> I think it's not a big risk if Angelo already did the test and
> snd_soc_pm_ops is also used in MT8186.
> I can help do more tests on 5.10 when the patch is back to chromium in
> the future.
> MTK also have a plan to support complete suspend/resume functionality
> in MT8195. If Tzung-bi has concerns about the patch, I can help submit
> the patch at the time.
I have no further concern as long as you guys are also aware of the change.
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Trevor Wu <trevor.wu@mediatek.com>
Cc: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Mark Brown <broonie@kernel.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
tiwai@suse.com, lgirdwood@gmail.com,
linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ASoC: mediatek: mt8195-mt6359: Use snd_soc_pm_ops instead of custom ops
Date: Fri, 23 Sep 2022 13:03:51 +0800 [thread overview]
Message-ID: <Yy0+N13mJlGZE9E4@google.com> (raw)
In-Reply-To: <978af4cc1a8bfa92675bb201947cfdac1e5429f1.camel@mediatek.com>
On Fri, Sep 23, 2022 at 12:39:54PM +0800, Trevor Wu wrote:
> On Thu, 2022-09-22 at 16:10 +0200, AngeloGioacchino Del Regno wrote:
> > Il 22/09/22 15:30, Mark Brown ha scritto:
> > > On Thu, Sep 22, 2022 at 07:26:21PM +0800, Tzung-Bi Shih wrote:
> > >
> > > > snd_soc_pm_ops[1] sets some more fields. I'm not quite sure
> > > > whether
> > > > it would introduce any side effect or not. Perhaps Trevor could
> > > > provide some suggestions.
> > >
> > > If it does it should be to fix isues rather than introduce new
> > > problems - I suspect the other operations just don't work
> > > currently.
> >
> > From my upstream tests, this didn't introduce any issues, that's why
> > I've
> > sent this patch.
> >
> > In any case, let's check with Trevor, just as to be extremely sure,
> > but please
> > use an upstream kernel for eventual tests, as there are quite a bit
> > of changes
> > between 5.10 and current upstream.
> >
> > Cheers,
> > Angelo
>
> I think it's not a big risk if Angelo already did the test and
> snd_soc_pm_ops is also used in MT8186.
> I can help do more tests on 5.10 when the patch is back to chromium in
> the future.
> MTK also have a plan to support complete suspend/resume functionality
> in MT8195. If Tzung-bi has concerns about the patch, I can help submit
> the patch at the time.
I have no further concern as long as you guys are also aware of the change.
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Trevor Wu <trevor.wu@mediatek.com>
Cc: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Mark Brown <broonie@kernel.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
tiwai@suse.com, lgirdwood@gmail.com,
linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ASoC: mediatek: mt8195-mt6359: Use snd_soc_pm_ops instead of custom ops
Date: Fri, 23 Sep 2022 13:03:51 +0800 [thread overview]
Message-ID: <Yy0+N13mJlGZE9E4@google.com> (raw)
In-Reply-To: <978af4cc1a8bfa92675bb201947cfdac1e5429f1.camel@mediatek.com>
On Fri, Sep 23, 2022 at 12:39:54PM +0800, Trevor Wu wrote:
> On Thu, 2022-09-22 at 16:10 +0200, AngeloGioacchino Del Regno wrote:
> > Il 22/09/22 15:30, Mark Brown ha scritto:
> > > On Thu, Sep 22, 2022 at 07:26:21PM +0800, Tzung-Bi Shih wrote:
> > >
> > > > snd_soc_pm_ops[1] sets some more fields. I'm not quite sure
> > > > whether
> > > > it would introduce any side effect or not. Perhaps Trevor could
> > > > provide some suggestions.
> > >
> > > If it does it should be to fix isues rather than introduce new
> > > problems - I suspect the other operations just don't work
> > > currently.
> >
> > From my upstream tests, this didn't introduce any issues, that's why
> > I've
> > sent this patch.
> >
> > In any case, let's check with Trevor, just as to be extremely sure,
> > but please
> > use an upstream kernel for eventual tests, as there are quite a bit
> > of changes
> > between 5.10 and current upstream.
> >
> > Cheers,
> > Angelo
>
> I think it's not a big risk if Angelo already did the test and
> snd_soc_pm_ops is also used in MT8186.
> I can help do more tests on 5.10 when the patch is back to chromium in
> the future.
> MTK also have a plan to support complete suspend/resume functionality
> in MT8195. If Tzung-bi has concerns about the patch, I can help submit
> the patch at the time.
I have no further concern as long as you guys are also aware of the change.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-23 5:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 10:35 [PATCH] ASoC: mediatek: mt8195-mt6359: Use snd_soc_pm_ops instead of custom ops AngeloGioacchino Del Regno
2022-09-22 10:35 ` AngeloGioacchino Del Regno
2022-09-22 10:35 ` AngeloGioacchino Del Regno
2022-09-22 11:26 ` Tzung-Bi Shih
2022-09-22 11:26 ` Tzung-Bi Shih
2022-09-22 11:26 ` Tzung-Bi Shih
2022-09-22 13:30 ` Mark Brown
2022-09-22 13:30 ` Mark Brown
2022-09-22 13:30 ` Mark Brown
2022-09-22 14:10 ` AngeloGioacchino Del Regno
2022-09-22 14:10 ` AngeloGioacchino Del Regno
2022-09-22 14:10 ` AngeloGioacchino Del Regno
2022-09-23 4:39 ` Trevor Wu
2022-09-23 4:39 ` Trevor Wu
2022-09-23 4:39 ` Trevor Wu
2022-09-23 5:03 ` Tzung-Bi Shih [this message]
2022-09-23 5:03 ` Tzung-Bi Shih
2022-09-23 5:03 ` Tzung-Bi Shih
2022-09-23 17:06 ` Mark Brown
2022-09-23 17:06 ` Mark Brown
2022-09-23 17:06 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yy0+N13mJlGZE9E4@google.com \
--to=tzungbi@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=tiwai@suse.com \
--cc=trevor.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.