From: Wei Liu <wei.liu@kernel.org>
To: Saurabh Sengar <ssengar@linux.microsoft.com>
Cc: ssengar@microsoft.com, drawat.floss@gmail.com, airlied@linux.ie,
daniel@ffwll.ch, linux-hyperv@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
mikelley@microsoft.com, Wei Liu <wei.liu@kernel.org>
Subject: Re: [PATCH] drm/hyperv: Don't overwrite dirt_needed value set by host
Date: Fri, 23 Sep 2022 10:15:36 +0000 [thread overview]
Message-ID: <Yy2HSKb4AtcF+em6@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <1662996766-19304-1-git-send-email-ssengar@linux.microsoft.com>
On Mon, Sep 12, 2022 at 08:32:46AM -0700, Saurabh Sengar wrote:
> Existing code is causing a race condition where dirt_needed value is
> already set by the host and gets overwritten with default value. Remove
> this default setting of dirt_needed, to avoid overwriting the value
> received in the channel callback set by vmbus_open. Removing this
> setting also means the default value for dirt_needed is changed to false
> as it's allocated by kzalloc which is similar to legacy hyperv_fb driver.
>
> Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com>
Applied to hyperv-next. Thanks.
I ended up reconstructing the patch myself since the said driver
changed. It is only a one line change so that's fine. If the committed
patch is wrong, please let me know.
WARNING: multiple messages have this Message-ID (diff)
From: Wei Liu <wei.liu@kernel.org>
To: Saurabh Sengar <ssengar@linux.microsoft.com>
Cc: linux-hyperv@vger.kernel.org, airlied@linux.ie,
ssengar@microsoft.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, mikelley@microsoft.com,
drawat.floss@gmail.com, Wei Liu <wei.liu@kernel.org>
Subject: Re: [PATCH] drm/hyperv: Don't overwrite dirt_needed value set by host
Date: Fri, 23 Sep 2022 10:15:36 +0000 [thread overview]
Message-ID: <Yy2HSKb4AtcF+em6@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <1662996766-19304-1-git-send-email-ssengar@linux.microsoft.com>
On Mon, Sep 12, 2022 at 08:32:46AM -0700, Saurabh Sengar wrote:
> Existing code is causing a race condition where dirt_needed value is
> already set by the host and gets overwritten with default value. Remove
> this default setting of dirt_needed, to avoid overwriting the value
> received in the channel callback set by vmbus_open. Removing this
> setting also means the default value for dirt_needed is changed to false
> as it's allocated by kzalloc which is similar to legacy hyperv_fb driver.
>
> Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com>
Applied to hyperv-next. Thanks.
I ended up reconstructing the patch myself since the said driver
changed. It is only a one line change so that's fine. If the committed
patch is wrong, please let me know.
next prev parent reply other threads:[~2022-09-23 10:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 15:32 [PATCH] drm/hyperv: Don't overwrite dirt_needed value set by host Saurabh Sengar
2022-09-12 22:02 ` Dexuan Cui
2022-09-22 22:46 ` Michael Kelley (LINUX)
2022-09-23 10:15 ` Wei Liu [this message]
2022-09-23 10:15 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yy2HSKb4AtcF+em6@liuwe-devbox-debian-v2 \
--to=wei.liu@kernel.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=drawat.floss@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=ssengar@linux.microsoft.com \
--cc=ssengar@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.