* Re: [PATCH v4] ARM: dts: aspeed: yosemit V2: Enable OCP debug card
@ 2022-09-23 21:52 ` Patrick Williams
0 siblings, 0 replies; 9+ messages in thread
From: Patrick Williams @ 2022-09-23 21:52 UTC (permalink / raw)
To: Karthikeyan Pasupathi
Cc: Rob Herring, Joel Stanley, Andrew Jeffery, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel, openbmc,
kernel test robot
[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]
> Subject: [PATCH v4] ARM: dts: aspeed: yosemit V2: Enable OCP debug card
Please double-check your spelling of commit messages. You've misspelled
"yosemite" here, which gives an impression that it is quite likely that
other things are wrong with your commit.
On Wed, Sep 21, 2022 at 12:13:09PM +0530, Karthikeyan Pasupathi wrote:
> Added IPMB-13 channel for Debug Card communication.
> which improve the readability of the machine and makes
> easier to debug the server. and it will display the some
> informations about the server like "system info",
> "Critical sensors" and "critical sel".
>
> ---
> --- v4- Resolved syntax error
> --- v3- Updated the title and commit
> --- v2- Updated the title
> --- v1- Initial draft
> ---
>
> Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>
> ---
> arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> index 8864e9c312a8..84236df522dc 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> @@ -215,6 +215,17 @@
> };
> };
>
> +&i2c13 {
> + status = "okay";
> + // Debug Card
> + multi-master;
> + ipmb13@10 {
> + compatible = "ipmb-dev";
> + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> + i2c-protocol;
> + };
> +};
> +
> &pwm_tacho {
> status = "okay";
> //FSC
> --
> 2.17.1
>
Reviewed-by: Patrick Williams <patrick@stwcx.xyz>
--
Patrick Williams
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v4] ARM: dts: aspeed: yosemit V2: Enable OCP debug card
@ 2022-09-23 21:52 ` Patrick Williams
0 siblings, 0 replies; 9+ messages in thread
From: Patrick Williams @ 2022-09-23 21:52 UTC (permalink / raw)
To: Karthikeyan Pasupathi
Cc: Rob Herring, Joel Stanley, Andrew Jeffery, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel, openbmc,
kernel test robot
[-- Attachment #1.1: Type: text/plain, Size: 1642 bytes --]
> Subject: [PATCH v4] ARM: dts: aspeed: yosemit V2: Enable OCP debug card
Please double-check your spelling of commit messages. You've misspelled
"yosemite" here, which gives an impression that it is quite likely that
other things are wrong with your commit.
On Wed, Sep 21, 2022 at 12:13:09PM +0530, Karthikeyan Pasupathi wrote:
> Added IPMB-13 channel for Debug Card communication.
> which improve the readability of the machine and makes
> easier to debug the server. and it will display the some
> informations about the server like "system info",
> "Critical sensors" and "critical sel".
>
> ---
> --- v4- Resolved syntax error
> --- v3- Updated the title and commit
> --- v2- Updated the title
> --- v1- Initial draft
> ---
>
> Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>
> ---
> arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> index 8864e9c312a8..84236df522dc 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> @@ -215,6 +215,17 @@
> };
> };
>
> +&i2c13 {
> + status = "okay";
> + // Debug Card
> + multi-master;
> + ipmb13@10 {
> + compatible = "ipmb-dev";
> + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> + i2c-protocol;
> + };
> +};
> +
> &pwm_tacho {
> status = "okay";
> //FSC
> --
> 2.17.1
>
Reviewed-by: Patrick Williams <patrick@stwcx.xyz>
--
Patrick Williams
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v4] ARM: dts: aspeed: yosemit V2: Enable OCP debug card
@ 2022-09-23 21:52 ` Patrick Williams
0 siblings, 0 replies; 9+ messages in thread
From: Patrick Williams @ 2022-09-23 21:52 UTC (permalink / raw)
To: Karthikeyan Pasupathi
Cc: devicetree, kernel test robot, linux-aspeed, Andrew Jeffery,
openbmc, linux-kernel, Rob Herring, Joel Stanley,
linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]
> Subject: [PATCH v4] ARM: dts: aspeed: yosemit V2: Enable OCP debug card
Please double-check your spelling of commit messages. You've misspelled
"yosemite" here, which gives an impression that it is quite likely that
other things are wrong with your commit.
On Wed, Sep 21, 2022 at 12:13:09PM +0530, Karthikeyan Pasupathi wrote:
> Added IPMB-13 channel for Debug Card communication.
> which improve the readability of the machine and makes
> easier to debug the server. and it will display the some
> informations about the server like "system info",
> "Critical sensors" and "critical sel".
>
> ---
> --- v4- Resolved syntax error
> --- v3- Updated the title and commit
> --- v2- Updated the title
> --- v1- Initial draft
> ---
>
> Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>
> ---
> arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> index 8864e9c312a8..84236df522dc 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> @@ -215,6 +215,17 @@
> };
> };
>
> +&i2c13 {
> + status = "okay";
> + // Debug Card
> + multi-master;
> + ipmb13@10 {
> + compatible = "ipmb-dev";
> + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> + i2c-protocol;
> + };
> +};
> +
> &pwm_tacho {
> status = "okay";
> //FSC
> --
> 2.17.1
>
Reviewed-by: Patrick Williams <patrick@stwcx.xyz>
--
Patrick Williams
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH v4] ARM: dts: aspeed: yosemit V2: Enable OCP debug card
2022-09-23 21:52 ` Patrick Williams
@ 2022-09-26 11:43 ` karthikeyan P
-1 siblings, 0 replies; 9+ messages in thread
From: karthikeyan P @ 2022-09-26 11:43 UTC (permalink / raw)
To: linux-aspeed
Will do, thanks!
On Sat, Sep 24, 2022 at 3:22 AM Patrick Williams <patrick@stwcx.xyz> wrote:
>
> > Subject: [PATCH v4] ARM: dts: aspeed: yosemit V2: Enable OCP debug card
>
> Please double-check your spelling of commit messages. You've misspelled
> "yosemite" here, which gives an impression that it is quite likely that
> other things are wrong with your commit.
>
> On Wed, Sep 21, 2022 at 12:13:09PM +0530, Karthikeyan Pasupathi wrote:
> > Added IPMB-13 channel for Debug Card communication.
> > which improve the readability of the machine and makes
> > easier to debug the server. and it will display the some
> > informations about the server like "system info",
> > "Critical sensors" and "critical sel".
> >
> > ---
> > --- v4- Resolved syntax error
> > --- v3- Updated the title and commit
> > --- v2- Updated the title
> > --- v1- Initial draft
> > ---
> >
> > Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>
> > ---
> > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> > index 8864e9c312a8..84236df522dc 100644
> > --- a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> > +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> > @@ -215,6 +215,17 @@
> > };
> > };
> >
> > +&i2c13 {
> > + status = "okay";
> > + // Debug Card
> > + multi-master;
> > + ipmb13 at 10 {
> > + compatible = "ipmb-dev";
> > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> > + i2c-protocol;
> > + };
> > +};
> > +
> > &pwm_tacho {
> > status = "okay";
> > //FSC
> > --
> > 2.17.1
> >
>
> Reviewed-by: Patrick Williams <patrick@stwcx.xyz>
>
> --
> Patrick Williams
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20220926/c78a348a/attachment.htm>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v4] ARM: dts: aspeed: yosemit V2: Enable OCP debug card
@ 2022-09-26 11:43 ` karthikeyan P
0 siblings, 0 replies; 9+ messages in thread
From: karthikeyan P @ 2022-09-26 11:43 UTC (permalink / raw)
To: Patrick Williams
Cc: devicetree, kernel test robot, linux-aspeed, Andrew Jeffery,
openbmc, linux-kernel, Rob Herring, Joel Stanley,
linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 1849 bytes --]
Will do, thanks!
On Sat, Sep 24, 2022 at 3:22 AM Patrick Williams <patrick@stwcx.xyz> wrote:
>
> > Subject: [PATCH v4] ARM: dts: aspeed: yosemit V2: Enable OCP debug card
>
> Please double-check your spelling of commit messages. You've misspelled
> "yosemite" here, which gives an impression that it is quite likely that
> other things are wrong with your commit.
>
> On Wed, Sep 21, 2022 at 12:13:09PM +0530, Karthikeyan Pasupathi wrote:
> > Added IPMB-13 channel for Debug Card communication.
> > which improve the readability of the machine and makes
> > easier to debug the server. and it will display the some
> > informations about the server like "system info",
> > "Critical sensors" and "critical sel".
> >
> > ---
> > --- v4- Resolved syntax error
> > --- v3- Updated the title and commit
> > --- v2- Updated the title
> > --- v1- Initial draft
> > ---
> >
> > Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>
> > ---
> > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> > index 8864e9c312a8..84236df522dc 100644
> > --- a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> > +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> > @@ -215,6 +215,17 @@
> > };
> > };
> >
> > +&i2c13 {
> > + status = "okay";
> > + // Debug Card
> > + multi-master;
> > + ipmb13@10 {
> > + compatible = "ipmb-dev";
> > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> > + i2c-protocol;
> > + };
> > +};
> > +
> > &pwm_tacho {
> > status = "okay";
> > //FSC
> > --
> > 2.17.1
> >
>
> Reviewed-by: Patrick Williams <patrick@stwcx.xyz>
>
> --
> Patrick Williams
>
[-- Attachment #2: Type: text/html, Size: 2714 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread