From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: butt3rflyh4ck <butterflyhuangxx@gmail.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
Jonas Karlman <jonas@kwiboo.se>, Dave Airlie <airlied@linux.ie>,
Liviu Dudau <Liviu.Dudau@arm.com>,
LKML <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Ben Davis <ben.davis@arm.com>
Subject: Re: A divide error bug in framebuffer_check
Date: Tue, 13 Sep 2022 11:20:51 +0300 [thread overview]
Message-ID: <YyA9Y+Cs8ZCYHXAT@intel.com> (raw)
In-Reply-To: <CAFcO6XOSwwe+4H5cCEdgj6KD+QutNMZA89rWXYvbQCsREqFqtQ@mail.gmail.com>
On Tue, Sep 13, 2022 at 01:49:40AM +0800, butt3rflyh4ck wrote:
> Hi, there is a divide error bug in framebuffer_check in
> drivers/gpu/drm/drm_framebuffer.c in the latest kernel.
> we can trigger it via drm_mode_addfb2 IOCTL.
> The call trace is drm_mode_addfb2 -> drm_internal_framebuffer_create
> -> framebuffer_check.
> let us see code below:
> ```
<snip>
> { .format = DRM_FORMAT_Q410, .depth = 0,
> .num_planes = 3, .char_per_block = { 2, 2, 2 },
> .block_w = { 1, 1, 1 }, .block_h = { 1, 1, 1 }, .hsub = 0,
> .vsub = 0, .is_yuv = true },
> { .format = DRM_FORMAT_Q401, .depth = 0,
> .num_planes = 3, .char_per_block = { 2, 2, 2 },
> .block_w = { 1, 1, 1 }, .block_h = { 1, 1, 1 }, .hsub = 0,
> .vsub = 0, .is_yuv = true },
> ```
> we can see format.hsub and format.vsub all are NULL.
Yeah, those look borked.
Added in commit 94b292b27734 ("drm: drm_fourcc: add NV15, Q410, Q401 YUV formats")
Adding the relevant people to cc...
--
Ville Syrjälä
Intel
WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: butt3rflyh4ck <butterflyhuangxx@gmail.com>
Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Dave Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
LKML <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Ben Davis <ben.davis@arm.com>,
Brian Starkey <brian.starkey@arm.com>,
Liviu Dudau <Liviu.Dudau@arm.com>,
Jonas Karlman <jonas@kwiboo.se>
Subject: Re: A divide error bug in framebuffer_check
Date: Tue, 13 Sep 2022 11:20:51 +0300 [thread overview]
Message-ID: <YyA9Y+Cs8ZCYHXAT@intel.com> (raw)
In-Reply-To: <CAFcO6XOSwwe+4H5cCEdgj6KD+QutNMZA89rWXYvbQCsREqFqtQ@mail.gmail.com>
On Tue, Sep 13, 2022 at 01:49:40AM +0800, butt3rflyh4ck wrote:
> Hi, there is a divide error bug in framebuffer_check in
> drivers/gpu/drm/drm_framebuffer.c in the latest kernel.
> we can trigger it via drm_mode_addfb2 IOCTL.
> The call trace is drm_mode_addfb2 -> drm_internal_framebuffer_create
> -> framebuffer_check.
> let us see code below:
> ```
<snip>
> { .format = DRM_FORMAT_Q410, .depth = 0,
> .num_planes = 3, .char_per_block = { 2, 2, 2 },
> .block_w = { 1, 1, 1 }, .block_h = { 1, 1, 1 }, .hsub = 0,
> .vsub = 0, .is_yuv = true },
> { .format = DRM_FORMAT_Q401, .depth = 0,
> .num_planes = 3, .char_per_block = { 2, 2, 2 },
> .block_w = { 1, 1, 1 }, .block_h = { 1, 1, 1 }, .hsub = 0,
> .vsub = 0, .is_yuv = true },
> ```
> we can see format.hsub and format.vsub all are NULL.
Yeah, those look borked.
Added in commit 94b292b27734 ("drm: drm_fourcc: add NV15, Q410, Q401 YUV formats")
Adding the relevant people to cc...
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2022-09-13 8:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 17:49 A divide error bug in framebuffer_check butt3rflyh4ck
2022-09-12 17:49 ` butt3rflyh4ck
2022-09-13 8:20 ` Ville Syrjälä [this message]
2022-09-13 8:20 ` Ville Syrjälä
2022-09-13 14:43 ` [PATCH] drm/fourcc: Fix vsub/hsub for Q410 and Q401 Brian Starkey
2022-09-13 14:43 ` Brian Starkey
2022-09-13 15:36 ` Liviu Dudau
2022-09-13 15:36 ` Liviu Dudau
2022-09-26 15:21 ` Brian Starkey
2022-09-26 15:21 ` Brian Starkey
2022-09-26 15:29 ` Liviu Dudau
2022-09-26 15:29 ` Liviu Dudau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyA9Y+Cs8ZCYHXAT@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=Liviu.Dudau@arm.com \
--cc=airlied@linux.ie \
--cc=ben.davis@arm.com \
--cc=butterflyhuangxx@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.