Re: [lpieralisi-pci:pci/dwc 3/3] drivers/pci/controller/dwc/pcie-kirin.c:373:15: error: implicit declaration of function 'gpiod_count'

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Wed, Sep 14, 2022 at 11:42:29AM +0200, Linus Walleij wrote:
> On Wed, Sep 14, 2022 at 11:38 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Tue, Sep 13, 2022 at 02:45:12AM +0800, kernel test robot wrote:
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git pci/dwc
> > > head:   2023f9c9190e657b9853a442899a52b14253aea3
> > > commit: 2023f9c9190e657b9853a442899a52b14253aea3 [3/3] PCI: dwc: Replace of_gpio_named_count() by gpiod_count()
> > > config: xtensa-randconfig-r023-20220911 (https://download.01.org/0day-ci/archive/20220913/202209130205.CPp5dG1q-lkp@intel.com/config)
> > > compiler: xtensa-linux-gcc (GCC) 12.1.0
> > > reproduce (this is a W=1 build):
> > >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > >         chmod +x ~/bin/make.cross
> > >         # https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git/commit/?id=2023f9c9190e657b9853a442899a52b14253aea3
> > >         git remote add lpieralisi-pci https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git
> > >         git fetch --no-tags lpieralisi-pci pci/dwc
> > >         git checkout 2023f9c9190e657b9853a442899a52b14253aea3
> > >         # save the config file
> > >         mkdir build_dir && cp config build_dir/.config
> > >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=xtensa SHELL=/bin/bash drivers/pci/controller/dwc/
> > >
> > > If you fix the issue, kindly add following tag where applicable
> > > Reported-by: kernel test robot <lkp@intel.com>
> > >
> > > All errors (new ones prefixed by >>):
> > >
> > >    drivers/pci/controller/dwc/pcie-kirin.c: In function 'kirin_pcie_get_gpio_enable':
> > > >> drivers/pci/controller/dwc/pcie-kirin.c:373:15: error: implicit declaration of function 'gpiod_count' [-Werror=implicit-function-declaration]
> > >      373 |         ret = gpiod_count(dev, "hisilicon,clken");
> > >          |               ^~~~~~~~~~~
> > >    cc1: some warnings being treated as errors
> >
> >
> > It's only possible if we miss to include gpio/consumer.h which is the case here
> > (at least on some architectures).
> >
> > Lorenzo, what do you want me to do? I can add the missed include, but looking
> > at the code it needs conversion to GPIO descriptors altogether.
> >
> > Linus, don't you have a patch for this driver already? (I don't remember
> > if I have seen a branch in your tree regarding this long-standing conversion
> > to GPIO descriptors all over the kernel.)
> 
> Not me, by Dmitry T sent some really nice PCI host GPIOD conversions
> recently, not this one though.

No, I do not have any outstanding changes for this driver. Maybe Andy
can finish the conversion to gpiod?

Thanks.

-- 
Dmitry