Re: [dtor-input:next 9/36] drivers/input/keyboard/matrix_keypad.c:419:39: error: implicit declaration of function 'gpiod_count'; did you mean 'of_gpio_count'?

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Wed, Sep 14, 2022 at 07:42:02PM +0300, Andy Shevchenko wrote:
> On Wed, Sep 14, 2022 at 11:14:12PM +0800, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
> > head:   d56111ed58482de0045e1e1201122e6e71516945
> > commit: f8f7f47d576f7f5d44ef9237f356bd6d42002614 [9/36] Input: matrix_keypad - replace of_gpio_named_count() by gpiod_count()
> > config: microblaze-randconfig-m041-20220914 (https://download.01.org/0day-ci/archive/20220914/202209142319.3cDIFi8V-lkp@intel.com/config)
> > compiler: microblaze-linux-gcc (GCC) 12.1.0
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git/commit/?id=f8f7f47d576f7f5d44ef9237f356bd6d42002614
> >         git remote add dtor-input https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git
> >         git fetch --no-tags dtor-input next
> >         git checkout f8f7f47d576f7f5d44ef9237f356bd6d42002614
> >         # save the config file
> >         mkdir build_dir && cp config build_dir/.config
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=microblaze SHELL=/bin/bash
> > 
> > If you fix the issue, kindly add following tag where applicable
> > Reported-by: kernel test robot <lkp@intel.com>
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    drivers/input/keyboard/matrix_keypad.c: In function 'matrix_keypad_parse_dt':
> > >> drivers/input/keyboard/matrix_keypad.c:419:39: error: implicit declaration of function 'gpiod_count'; did you mean 'of_gpio_count'? [-Werror=implicit-function-declaration]
> >      419 |         pdata->num_row_gpios = nrow = gpiod_count(dev, "row");
> >          |                                       ^~~~~~~~~~~
> >          |                                       of_gpio_count
> >    cc1: some warnings being treated as errors
> 
> Heh... Seems on some architectures this needs an explicit include of linux/gpio/consumer.h.
> Dmitry, do you want me to send a fixup, or would you squash the change yourself?

The patch is too deep in the tree to squash, so please just send a
fixup.

Thanks.

-- 
Dmitry