All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Vignesh Raghavendra <vigneshr@ti.com>
Cc: Nishanth Menon <nm@ti.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Keerthy <j-keerthy@ti.com>
Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-am62: Add general purpose timers for am62
Date: Mon, 19 Sep 2022 14:28:38 +0300	[thread overview]
Message-ID: <YyhSZugsrBS28ufb@atomide.com> (raw)
In-Reply-To: <5ac6eddb-d77c-113b-d4eb-9b04108e073c@ti.com>

* Vignesh Raghavendra <vigneshr@ti.com> [220917 06:54]:
> On 14/09/22 1:12 pm, Tony Lindgren wrote:
> > @@ -186,6 +186,103 @@ main_pmx0: pinctrl@f4000 {
> >  		pinctrl-single,function-mask = <0xffffffff>;
> >  	};
> >  
> > +	main_timer0: timer@2400000 {
> > +		compatible = "ti,am654-timer";
> > +		reg = <0x00 0x2400000 0x00 0x400>;
> > +		interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
> > +		clocks = <&k3_clks 36 2>;
> > +		clock-names = "fck";
> > +		assigned-clocks = <&k3_clks 36 2>;
> > +		assigned-clock-parents = <&k3_clks 36 3>;
> > +		power-domains = <&k3_pds 36 TI_SCI_PD_EXCLUSIVE>;
> 
> I end up with
> 
> make dtbs_check
> 
> +/workdir/arch/arm64/boot/dts/ti/k3-am625-sk.dtb: timer@4800000: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+'
> +/workdir/arch/arm64/boot/dts/ti/k3-am625-sk.dtb: timer@4810000: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+'
> +/workdir/arch/arm64/boot/dts/ti/k3-am625-sk.dtb: timer@4820000: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+'
> +/workdir/arch/arm64/boot/dts/ti/k3-am625-sk.dtb: timer@4830000: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Looks like schema does not describe power-domains :(

Thanks for catching it, I've sent a patch for the binding for this at [0]
below.

Regards,

Tony

[0] https://lore.kernel.org/linux-devicetree/20220919112357.64997-1-tony@atomide.com/T/#u

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Vignesh Raghavendra <vigneshr@ti.com>
Cc: Nishanth Menon <nm@ti.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Keerthy <j-keerthy@ti.com>
Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-am62: Add general purpose timers for am62
Date: Mon, 19 Sep 2022 14:28:38 +0300	[thread overview]
Message-ID: <YyhSZugsrBS28ufb@atomide.com> (raw)
In-Reply-To: <5ac6eddb-d77c-113b-d4eb-9b04108e073c@ti.com>

* Vignesh Raghavendra <vigneshr@ti.com> [220917 06:54]:
> On 14/09/22 1:12 pm, Tony Lindgren wrote:
> > @@ -186,6 +186,103 @@ main_pmx0: pinctrl@f4000 {
> >  		pinctrl-single,function-mask = <0xffffffff>;
> >  	};
> >  
> > +	main_timer0: timer@2400000 {
> > +		compatible = "ti,am654-timer";
> > +		reg = <0x00 0x2400000 0x00 0x400>;
> > +		interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
> > +		clocks = <&k3_clks 36 2>;
> > +		clock-names = "fck";
> > +		assigned-clocks = <&k3_clks 36 2>;
> > +		assigned-clock-parents = <&k3_clks 36 3>;
> > +		power-domains = <&k3_pds 36 TI_SCI_PD_EXCLUSIVE>;
> 
> I end up with
> 
> make dtbs_check
> 
> +/workdir/arch/arm64/boot/dts/ti/k3-am625-sk.dtb: timer@4800000: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+'
> +/workdir/arch/arm64/boot/dts/ti/k3-am625-sk.dtb: timer@4810000: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+'
> +/workdir/arch/arm64/boot/dts/ti/k3-am625-sk.dtb: timer@4820000: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+'
> +/workdir/arch/arm64/boot/dts/ti/k3-am625-sk.dtb: timer@4830000: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Looks like schema does not describe power-domains :(

Thanks for catching it, I've sent a patch for the binding for this at [0]
below.

Regards,

Tony

[0] https://lore.kernel.org/linux-devicetree/20220919112357.64997-1-tony@atomide.com/T/#u

  reply	other threads:[~2022-09-19 11:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-14  7:42 [PATCH 1/2] arm64: dts: ti: k3-am62: Add general purpose timers for am62 Tony Lindgren
2022-09-14  7:42 ` Tony Lindgren
2022-09-14  7:42 ` [PATCH 2/2] arm64: dts: ti: k3-am625-sk: Use pwm-led instead of gpio-led Tony Lindgren
2022-09-14  7:42   ` Tony Lindgren
2022-10-28 20:19   ` Georgi Vlaev
2022-10-28 20:19     ` Georgi Vlaev
2022-09-17  7:02 ` [PATCH 1/2] arm64: dts: ti: k3-am62: Add general purpose timers for am62 Vignesh Raghavendra
2022-09-17  7:02   ` Vignesh Raghavendra
2022-09-19 11:28   ` Tony Lindgren [this message]
2022-09-19 11:28     ` Tony Lindgren
2022-10-28 20:12 ` Georgi Vlaev
2022-10-28 20:12   ` Georgi Vlaev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YyhSZugsrBS28ufb@atomide.com \
    --to=tony@atomide.com \
    --cc=devicetree@vger.kernel.org \
    --cc=j-keerthy@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=nm@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.