b4 v0.10.0 is available

b4 v0.10.0 is available

[Konstantin Ryabitsev]

[-- Attachment #1: Type: text/plain, Size: 2395 bytes --]

Hello, everyone:

After a long period of churn, version 0.10.0 of b4 is available. The major new
feature in this release is a set of contributor-oriented features aimed at
making it easier for developers to prepare, submit, and refine patch series.

This new set of features is documented at the new documentation site:
https://b4.docs.kernel.org/en/stable-0.10.y/#for-developers

EXPERIMENTAL warning: please note, that developer-oriented features (prep,
send, trailers) are brand new and undoubtedly contain bugs. Please report them
to the Tools mailing list at tools@linux.kernel.org.

New in this release
-------------------
* Developer-oriented features (prep, send, trailers commands)

* Patchwork integration, which allows setting patchwork state on the patches
  retrieved and accepted via b4 commands. See documentation at:
  https://b4.docs.kernel.org/en/stable-0.10.y/config.html#patchwork-integration-settings

* The "trailer-order" setting now only reorders the trailers in your own
  custody section of the commit message. See documentation for what that
  means.

* Web submission endpoint support for "b4 send" -- it is now possible to
  submit patches without having access to an SMTP server. See documentation
  for details:
  https://b4.docs.kernel.org/en/stable-0.10.y/contributor/send.html

* Adds a "trailers-ignore-from" configuration option that allows ignoring
  followup-trailers from specific email addresses (like lkp@intel.com).

* Bugfixes and improved tests.

Upgrading
---------
If you've installed from pip, you can upgrade from pip as well:

    pip install --upgrade b4

For all other installation options, see docs:
https://b4.docs.kernel.org/en/stable-0.10.y/installing.html

Special thanks
--------------
Huge thanks to everyone who was patient enough to test out the new contributor
features despite many initial bugs. Overall, the following people have
contributed to this release (in reverse git log order):

* Mattijs Korpershoek <mkorpershoek@baylibre.com>
* Sudeep Holla <sudeep.holla@arm.com>
* Mark Brown <broonie@kernel.org>
* Maxime Ripard <maxime@cerno.tech>
* Conor Dooley <conor.dooley@microchip.com>
* Philippe Blain <levraiphilippeblain@gmail.com>
* Rob Herring <robh@kernel.org>
* Vishal Verma <vishal@kernel.org>
* Dmitry Torokhov <dmitry.torokhov@gmail.com>
* Lucas De Marchi <lucas.demarchi@intel.com>

Best regards,
Konstantin Ryabitsev

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: b4 v0.10.0 is available

[Leon Romanovsky]

Hi,

I got the following splat when tried ty functionality:

➜  kernel git:(wip/leon-for-next) ~/src/b4/b4.sh ty -aS --dry-run
Auto-thankanating commits in wip/leon-for-next
Found 2 of your commits since 1.week
Calculating patch hashes, may take a moment...
  Located: [PATCH for-next 0/2] irdma for-next updates 9-7-2022
---
Generating 1 thank-you letters
  Sending: Re: [PATCH for-next 0/2] irdma for-next updates 9-7-2022
    --- DRYRUN: message follows ---
    | From: Leon Romanovsky <leon@kernel.org>
    | To: Shiraz Saleem <shiraz.saleem@intel.com>, Jason Gunthorpe <jgg@ziepe.ca>
    | Cc: linux-rdma@vger.kernel.org
    | In-Reply-To: <20220907191324.1173-1-shiraz.saleem@intel.com>
    | References: <20220907191324.1173-1-shiraz.saleem@intel.com>
    | Subject: Re: [PATCH for-next 0/2] irdma for-next updates 9-7-2022
    | Message-Id: <166366381168.86952.7578029482213151514.b4-ty@kernel.org>
    | Date: Tue, 20 Sep 2022 11:50:11 +0300
    | MIME-Version: 1.0
    | Content-Type: text/plain; charset="utf-8"
    | Content-Transfer-Encoding: 8bit
    | X-Mailer: b4 0.11.0-dev-8af31
    |
    | On Wed, 7 Sep 2022 14:13:22 -0500, Shiraz Saleem wrote:
    | > This series adds udata inlen/outlen validation for the verb API's
    | > and fixes up completion error code reporting to ulp's.
    | >
    | > Shiraz Saleem (1):
    | >   RDMA/irdma: Validate udata inlen and outlen
    | >
    | > Sindhu-Devale (1):
    | >   RDMA/irdma: Align AE id codes to correct flush code and event
    | >
    | > [...]
    |
    | Applied, thanks!
    |
    | [1/2] RDMA/irdma: Align AE id codes to correct flush code and event
    |       commit: b6da0e79c495ba730223608f2791bc02c9af38b6
    | [2/2] RDMA/irdma: Validate udata inlen and outlen
    |       commit: b3cce21f46fe228dc5cc81c4b93ba25e3d873079
    |
    | Best regards,
    | --
    | Leon Romanovsky <leon@kernel.org>
    --- DRYRUN: message ends ---
Dry run, preserving tracked series.
---
DRYRUN: generated 1 thank-you letters
Traceback (most recent call last):
  File "/home/leonro/src/b4/b4/command.py", line 358, in <module>
    cmd()
  File "/home/leonro/src/b4/b4/command.py", line 341, in cmd
    cmdargs.func(cmdargs)
  File "/home/leonro/src/b4/b4/command.py", line 106, in cmd_ty
    b4.ty.main(cmdargs)
  File "/home/leonro/src/b4/b4/ty.py", line 674, in main
    auto_thankanator(cmdargs)
  File "/home/leonro/src/b4/b4/ty.py", line 378, in auto_thankanator
    send_messages(applied, wantbranch, cmdargs)
  File "/home/leonro/src/b4/b4/ty.py", line 469, in send_messages
    smtp.quit()
AttributeError: 'list' object has no attribute 'quit'

---------------------
My sendemail section:

   26 [sendemail]     
   27         smtpserver = /usr/local/bin/msmtp-enqueue.sh
   28         suppresscc = self
   29         chainReplyTo = false
   30         confirm = always
   31         from = Leon Romanovsky <leon@kernel.org>
   32         envelopeSender = Leon Romanovsky <leon@kernel.org>
   33         signingkey = leon@kernel.org
   34         composeencoding = utf-8
   35         # Rely on git-format-patch to generate message-id
   36         thread = false

Thanks

Re: b4 v0.10.0 is available

[Konstantin Ryabitsev]

On Tue, Sep 20, 2022 at 12:10:46PM +0300, Leon Romanovsky wrote:
> Hi,
> 
> I got the following splat when tried ty functionality:

Thank you, that's due to the new feature that supports sendmail wrappers,
which is not something I tested with "ty". There's a fix in the latest
master/stable-0.10.y

-K

Re: b4 v0.10.0 is available

[Leon Romanovsky]

On Tue, Sep 20, 2022 at 10:48:55AM -0400, Konstantin Ryabitsev wrote:
> On Tue, Sep 20, 2022 at 12:10:46PM +0300, Leon Romanovsky wrote:
> > Hi,
> > 
> > I got the following splat when tried ty functionality:
> 
> Thank you, that's due to the new feature that supports sendmail wrappers,
> which is not something I tested with "ty". There's a fix in the latest
> master/stable-0.10.y

Thanks, it fixed the splat, but I still can't send emails with ty.

➜  kernel git:(wip/leon-for-next) ~/src/b4/b4.sh ty -aS
Auto-thankanating commits in wip/leon-for-next
Found 10 of your commits since 1.week
Calculating patch hashes, may take a moment...
  Located: [PATCH] IB/hfi1: remove rc_only_opcode and uc_only_opcode declarations
---
Generating 1 thank-you letters
  Sending: Re: [PATCH] IB/hfi1: remove rc_only_opcode and uc_only_opcode declarations
---
Sending via "/usr/local/bin/msmtp-enqueue.sh"
  Re: [PATCH] IB/hfi1: remove rc_only_opcode and uc_only_opcode declarations
---
Sent 1 thank-you letters
➜  kernel git:(wip/leon-for-next) msmtp-listqueue.sh
From: Leon Romanovsky <leon@kernel.org>
To: Gaosheng Cui <cuigaosheng1@huawei.com>, mike.marciniszyn@intel.com, jgg@ziepe.ca,
Subject: Re: [PATCH] IB/hfi1: remove rc_only_opcode and uc_only_opcode declarations

➜  kernel git:(wip/leon-for-next) msmtp-runqueue.sh 
*** Sending 2022-09-20-19.58.31.mail to  ...
msmtp: no recipients found
FAILURE

➜  kernel git:(wip/leon-for-next) ls ~/.msmtpqueue
2022-09-20-19.58.31.mail  2022-09-20-19.58.31.msmtp

and 2022-09-20-19.58.31.msmtp is empty.

BTW, git send-email ... works well.

Thanks

> 
> -K
> 

Re: b4 v0.10.0 is available

[Konstantin Ryabitsev]

On Tue, Sep 20, 2022 at 08:10:00PM +0300, Leon Romanovsky wrote:
> Thanks, it fixed the splat, but I still can't send emails with ty.

Oh, I see how it is -- it actually expects recipients to be on cmdline, not
just in the message headers. I think I have it now, please try master again.

> BTW, git send-email ... works well.

Well, git-send-email is a 2000-line perl script with lots of really
questionable decisions (like supporting paths for an option called
"smtpServer"). So, full bug-for-bug compatibility is hard to achieve. :)
Thank you for being patient.

-K

Re: b4 v0.10.0 is available

[Leon Romanovsky]

On Tue, Sep 20, 2022 at 02:15:38PM -0400, Konstantin Ryabitsev wrote:
> On Tue, Sep 20, 2022 at 08:10:00PM +0300, Leon Romanovsky wrote:
> > Thanks, it fixed the splat, but I still can't send emails with ty.
> 
> Oh, I see how it is -- it actually expects recipients to be on cmdline, not
> just in the message headers. I think I have it now, please try master again.

Thanks, it sends now.

So only patchworks, that is not updated, left :)

   52 [b4]
   53         pw-url = https://patchwork.kernel.org/
   54         pw-project = linux-rdma
   55         pw-key = my_secret_key

> 
> > BTW, git send-email ... works well.
> 
> Well, git-send-email is a 2000-line perl script with lots of really
> questionable decisions (like supporting paths for an option called
> "smtpServer"). So, full bug-for-bug compatibility is hard to achieve. :)
> Thank you for being patient.

Thank you for all your work.

> 
> -K
> 

Re: b4 v0.10.0 is available

[Konstantin Ryabitsev]

On Tue, Sep 20, 2022 at 09:33:26PM +0300, Leon Romanovsky wrote:
> So only patchworks, that is not updated, left :)
> 
>    52 [b4]
>    53         pw-url = https://patchwork.kernel.org/
>    54         pw-project = linux-rdma
>    55         pw-key = my_secret_key

The docs were lying, you need three more entries. Here's how it should look
like:

    [b4]
      pw-url = https://patchwork.kernel.org/
      pw-project = linux-rdma
      pw-key = my_secret_key
      pw-review-state = under-review
      pw-accept-state = accepted
      pw-discard-state = deferred

The docs shouldn't lie any more with the latest commit.

-K

Re: b4 v0.10.0 is available

[Leon Romanovsky]

On Tue, Sep 20, 2022 at 02:59:38PM -0400, Konstantin Ryabitsev wrote:
> On Tue, Sep 20, 2022 at 09:33:26PM +0300, Leon Romanovsky wrote:
> > So only patchworks, that is not updated, left :)
> > 
> >    52 [b4]
> >    53         pw-url = https://patchwork.kernel.org/
> >    54         pw-project = linux-rdma
> >    55         pw-key = my_secret_key
> 
> The docs were lying, you need three more entries. Here's how it should look
> like:
> 
>     [b4]
>       pw-url = https://patchwork.kernel.org/
>       pw-project = linux-rdma
>       pw-key = my_secret_key
>       pw-review-state = under-review
>       pw-accept-state = accepted
>       pw-discard-state = deferred
> 
> The docs shouldn't lie any more with the latest commit.

Thanks, it worked.

> 
> -K
>