All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Ricardo Koller <ricarkol@google.com>
Cc: kvm@vger.kernel.org, maz@kernel.org, bgardon@google.com,
	andrew.jones@linux.dev, dmatlack@google.com, pbonzini@redhat.com,
	axelrasmussen@google.com, kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH v8 07/14] KVM: selftests: Add vm->memslots[] and enum kvm_mem_region_type
Date: Thu, 22 Sep 2022 18:33:32 +0000	[thread overview]
Message-ID: <YyyqfG8RkS4G8x+p@google.com> (raw)
In-Reply-To: <20220922031857.2588688-8-ricarkol@google.com>

On Thu, Sep 22, 2022, Ricardo Koller wrote:
> The vm_create() helpers are hardcoded to place most page types (code,
> page-tables, stacks, etc) in the same memslot #0, and always backed with
> anonymous 4K.  There are a couple of issues with that.  First, tests
> willing to differ a bit, like placing page-tables in a different backing
> source type must replicate much of what's already done by the vm_create()
> functions.  Second, the hardcoded assumption of memslot #0 holding most
> things is spread everywhere; this makes it very hard to change.
> 
> Fix the above issues by having selftests specify how they want memory to be
> laid out. Start by changing ____vm_create() to not create memslot #0; a
> test (to come) will specify all memslots used by the VM.  Then, add the
> vm->memslots[] array to specify the right memslot for different memory
> allocators, e.g.,: lib/elf should use the vm->[MEM_REGION_CODE] memslot.
> This will be used as a way to specify the page-tables memslots (to be
> backed by huge pages for example).
> 
> There is no functional change intended. The current commit lays out memory
> exactly as before. A future commit will change the allocators to get the
> region they should be using, e.g.,: like the page table allocators using
> the pt memslot.
> 
> Cc: Sean Christopherson <seanjc@google.com>
> Cc: Andrew Jones <andrew.jones@linux.dev>
> Signed-off-by: Ricardo Koller <ricarkol@google.com>
> Reviewed-by: Andrew Jones <andrew.jones@linux.dev>
> ---

Reviewed-by: Sean Christopherson <seanjc@google.com>
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Ricardo Koller <ricarkol@google.com>
Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
	andrew.jones@linux.dev, pbonzini@redhat.com, maz@kernel.org,
	alexandru.elisei@arm.com, eric.auger@redhat.com,
	oupton@google.com, reijiw@google.com, rananta@google.com,
	bgardon@google.com, dmatlack@google.com,
	axelrasmussen@google.com
Subject: Re: [PATCH v8 07/14] KVM: selftests: Add vm->memslots[] and enum kvm_mem_region_type
Date: Thu, 22 Sep 2022 18:33:32 +0000	[thread overview]
Message-ID: <YyyqfG8RkS4G8x+p@google.com> (raw)
In-Reply-To: <20220922031857.2588688-8-ricarkol@google.com>

On Thu, Sep 22, 2022, Ricardo Koller wrote:
> The vm_create() helpers are hardcoded to place most page types (code,
> page-tables, stacks, etc) in the same memslot #0, and always backed with
> anonymous 4K.  There are a couple of issues with that.  First, tests
> willing to differ a bit, like placing page-tables in a different backing
> source type must replicate much of what's already done by the vm_create()
> functions.  Second, the hardcoded assumption of memslot #0 holding most
> things is spread everywhere; this makes it very hard to change.
> 
> Fix the above issues by having selftests specify how they want memory to be
> laid out. Start by changing ____vm_create() to not create memslot #0; a
> test (to come) will specify all memslots used by the VM.  Then, add the
> vm->memslots[] array to specify the right memslot for different memory
> allocators, e.g.,: lib/elf should use the vm->[MEM_REGION_CODE] memslot.
> This will be used as a way to specify the page-tables memslots (to be
> backed by huge pages for example).
> 
> There is no functional change intended. The current commit lays out memory
> exactly as before. A future commit will change the allocators to get the
> region they should be using, e.g.,: like the page table allocators using
> the pt memslot.
> 
> Cc: Sean Christopherson <seanjc@google.com>
> Cc: Andrew Jones <andrew.jones@linux.dev>
> Signed-off-by: Ricardo Koller <ricarkol@google.com>
> Reviewed-by: Andrew Jones <andrew.jones@linux.dev>
> ---

Reviewed-by: Sean Christopherson <seanjc@google.com>

  reply	other threads:[~2022-09-22 18:33 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-22  3:18 [PATCH v8 00/14] KVM: selftests: Add aarch64/page_fault_test Ricardo Koller
2022-09-22  3:18 ` Ricardo Koller
2022-09-22  3:18 ` [PATCH v8 01/14] KVM: selftests: Add a userfaultfd library Ricardo Koller
2022-09-22  3:18   ` Ricardo Koller
2022-09-22  3:18 ` [PATCH v8 02/14] KVM: selftests: aarch64: Add virt_get_pte_hva() library function Ricardo Koller
2022-09-22  3:18   ` Ricardo Koller
2022-09-22  3:18 ` [PATCH v8 03/14] KVM: selftests: Add missing close and munmap in __vm_mem_region_delete() Ricardo Koller
2022-09-22  3:18   ` Ricardo Koller
2022-09-22  3:18 ` [PATCH v8 04/14] KVM: selftests: aarch64: Construct DEFAULT_MAIR_EL1 using sysreg.h macros Ricardo Koller
2022-09-22  3:18   ` Ricardo Koller
2022-09-22  3:18 ` [PATCH v8 05/14] tools: Copy bitfield.h from the kernel sources Ricardo Koller
2022-09-22  3:18   ` Ricardo Koller
2022-09-22  3:18 ` [PATCH v8 06/14] KVM: selftests: Stash backing_src_type in struct userspace_mem_region Ricardo Koller
2022-09-22  3:18   ` Ricardo Koller
2022-09-22  3:18 ` [PATCH v8 07/14] KVM: selftests: Add vm->memslots[] and enum kvm_mem_region_type Ricardo Koller
2022-09-22  3:18   ` Ricardo Koller
2022-09-22 18:33   ` Sean Christopherson [this message]
2022-09-22 18:33     ` Sean Christopherson
2022-09-22  3:18 ` [PATCH v8 08/14] KVM: selftests: Fix alignment in virt_arch_pgd_alloc() and vm_vaddr_alloc() Ricardo Koller
2022-09-22  3:18   ` Ricardo Koller
2022-09-22  3:18 ` [PATCH v8 09/14] KVM: selftests: Use the right memslot for code, page-tables, and data allocations Ricardo Koller
2022-09-22  3:18   ` Ricardo Koller
2022-09-22 18:36   ` Sean Christopherson
2022-09-22 18:36     ` Sean Christopherson
2022-09-22  3:18 ` [PATCH v8 10/14] KVM: selftests: aarch64: Add aarch64/page_fault_test Ricardo Koller
2022-09-22  3:18   ` Ricardo Koller
2022-09-22 19:32   ` Sean Christopherson
2022-09-22 19:32     ` Sean Christopherson
2022-09-26 17:22     ` Ricardo Koller
2022-09-26 17:22       ` Ricardo Koller
2022-09-27 22:06       ` Sean Christopherson
2022-09-27 22:06         ` Sean Christopherson
2022-09-28  4:24         ` Ricardo Koller
2022-09-28  4:24           ` Ricardo Koller
2022-09-28 16:58           ` Sean Christopherson
2022-09-28 16:58             ` Sean Christopherson
2022-09-28 18:10             ` Ricardo Koller
2022-09-28 18:10               ` Ricardo Koller
2022-09-22  3:18 ` [PATCH v8 11/14] KVM: selftests: aarch64: Add userfaultfd tests into page_fault_test Ricardo Koller
2022-09-22  3:18   ` Ricardo Koller
2022-09-22  3:18 ` [PATCH v8 12/14] KVM: selftests: aarch64: Add dirty logging " Ricardo Koller
2022-09-22  3:18   ` Ricardo Koller
2022-09-22  3:18 ` [PATCH v8 13/14] KVM: selftests: aarch64: Add readonly memslot " Ricardo Koller
2022-09-22  3:18   ` Ricardo Koller
2022-09-22  3:18 ` [PATCH v8 14/14] KVM: selftests: aarch64: Add mix of " Ricardo Koller
2022-09-22  3:18   ` Ricardo Koller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YyyqfG8RkS4G8x+p@google.com \
    --to=seanjc@google.com \
    --cc=andrew.jones@linux.dev \
    --cc=axelrasmussen@google.com \
    --cc=bgardon@google.com \
    --cc=dmatlack@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=maz@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=ricarkol@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.