Re: [PATCH v10 07/17] net: socket: Don't ignore EINVAL on netdev socket connection

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1357 bytes --]

On Wed, Oct 05, 2022 at 06:20:41PM +0200, Laurent Vivier wrote:
> From: Stefano Brivio <sbrivio@redhat.com>
> 
> Other errors are treated as failure by net_socket_connect_init(),
> but if connect() returns EINVAL, we'll fail silently. Remove the
> related exception.
> 
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  net/socket.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/net/socket.c b/net/socket.c
> index ade1ecf38b87..4944bb70d580 100644
> --- a/net/socket.c
> +++ b/net/socket.c
> @@ -577,8 +577,7 @@ static int net_socket_connect_init(NetClientState *peer,
>              if (errno == EINTR || errno == EWOULDBLOCK) {
>                  /* continue */
>              } else if (errno == EINPROGRESS ||
> -                       errno == EALREADY ||
> -                       errno == EINVAL) {
> +                       errno == EALREADY) {
>                  break;
>              } else {
>                  error_setg_errno(errp, errno, "can't connect socket");

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]