All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Rob Herring" <robh@kernel.org>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	kernel@collabora.com, linux-pwm@vger.kernel.org,
	"Rob Herring" <robh+dt@kernel.org>
Subject: Re: [PATCH 1/1] dt-bindings: pwm: rockchip: Add description for rk3588
Date: Wed, 28 Sep 2022 13:48:29 +0200	[thread overview]
Message-ID: <YzQ0jTmJCBwV+x2y@orome> (raw)
In-Reply-To: <20220913141601.fi6pl2xdo4xmtw6t@mercury.elektranox.org>

[-- Attachment #1: Type: text/plain, Size: 1526 bytes --]

On Tue, Sep 13, 2022 at 04:16:01PM +0200, Sebastian Reichel wrote:
> Hi,
> 
> On Tue, Sep 13, 2022 at 11:12:02AM +0200, Uwe Kleine-König wrote:
> > Hello Rob,
> > 
> > On Thu, Sep 01, 2022 at 02:14:55PM -0500, Rob Herring wrote:
> > > On Thu, 01 Sep 2022 15:55:23 +0200, Sebastian Reichel wrote:
> > > > Add "rockchip,rk3588-pwm" compatible string for PWM nodes found
> > > > on a rk3588 platform.
> > > > 
> > > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> > > > ---
> > > > No driver changes required.
> > > > ---
> > > >  Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > 
> > > Running 'make dtbs_check' with the schema in this patch gives the
> > > following warnings. Consider if they are expected or the schema is
> > > incorrect. These may not be new warnings.
> > > 
> > > Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> > > This will change in the future.
> > 
> > Is this a list of *new* warnings, or is the report (somewhat) orthogonal
> > to the actual change and you just used the opportunity that someone
> > touched the pwm-rockchip binding to point out that there is some cleanup
> > to do?
> > 
> > > Full log is available here: https://patchwork.ozlabs.org/patch/
> > 
> > Hm, that gives me a 404.
> 
> This is an existing problem with the rv1108 binding.
> The rk3588 does not have pwm interrupts.

Can somebody go and fix that, then?

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Rob Herring" <robh@kernel.org>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	kernel@collabora.com, linux-pwm@vger.kernel.org,
	"Rob Herring" <robh+dt@kernel.org>
Subject: Re: [PATCH 1/1] dt-bindings: pwm: rockchip: Add description for rk3588
Date: Wed, 28 Sep 2022 13:48:29 +0200	[thread overview]
Message-ID: <YzQ0jTmJCBwV+x2y@orome> (raw)
In-Reply-To: <20220913141601.fi6pl2xdo4xmtw6t@mercury.elektranox.org>


[-- Attachment #1.1: Type: text/plain, Size: 1526 bytes --]

On Tue, Sep 13, 2022 at 04:16:01PM +0200, Sebastian Reichel wrote:
> Hi,
> 
> On Tue, Sep 13, 2022 at 11:12:02AM +0200, Uwe Kleine-König wrote:
> > Hello Rob,
> > 
> > On Thu, Sep 01, 2022 at 02:14:55PM -0500, Rob Herring wrote:
> > > On Thu, 01 Sep 2022 15:55:23 +0200, Sebastian Reichel wrote:
> > > > Add "rockchip,rk3588-pwm" compatible string for PWM nodes found
> > > > on a rk3588 platform.
> > > > 
> > > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> > > > ---
> > > > No driver changes required.
> > > > ---
> > > >  Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > 
> > > Running 'make dtbs_check' with the schema in this patch gives the
> > > following warnings. Consider if they are expected or the schema is
> > > incorrect. These may not be new warnings.
> > > 
> > > Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> > > This will change in the future.
> > 
> > Is this a list of *new* warnings, or is the report (somewhat) orthogonal
> > to the actual change and you just used the opportunity that someone
> > touched the pwm-rockchip binding to point out that there is some cleanup
> > to do?
> > 
> > > Full log is available here: https://patchwork.ozlabs.org/patch/
> > 
> > Hm, that gives me a 404.
> 
> This is an existing problem with the rv1108 binding.
> The rk3588 does not have pwm interrupts.

Can somebody go and fix that, then?

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  parent reply	other threads:[~2022-09-28 11:48 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-01 13:55 [PATCH 1/1] dt-bindings: pwm: rockchip: Add description for rk3588 Sebastian Reichel
2022-09-01 13:55 ` Sebastian Reichel
2022-09-01 15:02 ` Krzysztof Kozlowski
2022-09-01 15:02   ` Krzysztof Kozlowski
2022-09-01 18:49 ` Heiko Stübner
2022-09-01 18:49   ` Heiko Stübner
2022-09-01 19:14 ` Rob Herring
2022-09-01 19:14   ` Rob Herring
2022-09-13  9:12   ` Uwe Kleine-König
2022-09-13  9:12     ` Uwe Kleine-König
2022-09-13 14:16     ` Sebastian Reichel
2022-09-13 14:16       ` Sebastian Reichel
2022-09-14  7:33       ` Uwe Kleine-König
2022-09-14  7:33         ` Uwe Kleine-König
2022-09-28 11:48       ` Thierry Reding [this message]
2022-09-28 11:48         ` Thierry Reding
2022-09-28 13:06         ` Sebastian Reichel
2022-09-28 13:06           ` Sebastian Reichel
2022-09-28 13:56           ` Thierry Reding
2022-09-28 13:56             ` Thierry Reding
2022-09-28 15:18             ` Johan Jonker
2022-09-28 15:18               ` Johan Jonker
2022-09-28 16:11             ` Sebastian Reichel
2022-09-28 16:11               ` Sebastian Reichel
2022-09-28 18:29       ` Johan Jonker
2022-09-28 18:29         ` Johan Jonker
2022-09-29 13:10         ` Sebastian Reichel
2022-09-29 13:10           ` Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YzQ0jTmJCBwV+x2y@orome \
    --to=thierry.reding@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=kernel@collabora.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.