All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Leo Yan <leo.yan@linaro.org>
Cc: Ali Saidi <alisaidi@amazon.com>,
	renyu.zj@linux.alibaba.com, alexander.shishkin@linux.intel.com,
	german.gomez@arm.com, james.clark@arm.com, john.garry@huawei.com,
	jolsa@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	mark.rutland@arm.com, mike.leach@linaro.org, mingo@redhat.com,
	namhyung@kernel.org, peterz@infradead.org, timothy.hayes@arm.com,
	will@kernel.org, xueshuai@linux.alibaba.com,
	zhuo.song@linux.alibaba.com
Subject: Re: [PATCH] perf arm-spe: augment the data source type with neoverse_spe list
Date: Wed, 28 Sep 2022 11:20:43 -0300	[thread overview]
Message-ID: <YzRYO9aJxI4twVVj@kernel.org> (raw)
In-Reply-To: <YzG+goZySC4K8S4Z@leoy-huanghe.lan>

Em Mon, Sep 26, 2022 at 11:00:31PM +0800, Leo Yan escreveu:
> On Mon, Sep 26, 2022 at 02:10:32PM +0000, Ali Saidi wrote:
> > > When synthesizing event with SPE data source, commit 4e6430cbb1a9("perf
> > > arm-spe: Use SPE data source for neoverse cores") augment the type with
> > > source information by MIDR. However, is_midr_in_range only compares the
> > > first entry in neoverse_spe.
> > > 
> > > Change is_midr_in_range to is_midr_in_range_list to traverse the
> > > neoverse_spe array so that all neoverse cores synthesize event with data
> > > source packet.
> > > 
> > > Fixes: 4e6430cbb1a9("perf arm-spe: Use SPE data source for neoverse cores")
> > > Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>
> > 
> > Thanks for catching this, you're absolutely right.
> > 
> > Reviewed-by: Ali Saidi <alisaidi@amazon.com>
> 
> It's also good for me:
> Reviewed-by: Leo Yan <leo.yan@linaro.org>

Thanks, applied.

- Arnaldo


WARNING: multiple messages have this Message-ID (diff)
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Leo Yan <leo.yan@linaro.org>
Cc: Ali Saidi <alisaidi@amazon.com>,
	renyu.zj@linux.alibaba.com, alexander.shishkin@linux.intel.com,
	german.gomez@arm.com, james.clark@arm.com, john.garry@huawei.com,
	jolsa@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	mark.rutland@arm.com, mike.leach@linaro.org, mingo@redhat.com,
	namhyung@kernel.org, peterz@infradead.org, timothy.hayes@arm.com,
	will@kernel.org, xueshuai@linux.alibaba.com,
	zhuo.song@linux.alibaba.com
Subject: Re: [PATCH] perf arm-spe: augment the data source type with neoverse_spe list
Date: Wed, 28 Sep 2022 11:20:43 -0300	[thread overview]
Message-ID: <YzRYO9aJxI4twVVj@kernel.org> (raw)
In-Reply-To: <YzG+goZySC4K8S4Z@leoy-huanghe.lan>

Em Mon, Sep 26, 2022 at 11:00:31PM +0800, Leo Yan escreveu:
> On Mon, Sep 26, 2022 at 02:10:32PM +0000, Ali Saidi wrote:
> > > When synthesizing event with SPE data source, commit 4e6430cbb1a9("perf
> > > arm-spe: Use SPE data source for neoverse cores") augment the type with
> > > source information by MIDR. However, is_midr_in_range only compares the
> > > first entry in neoverse_spe.
> > > 
> > > Change is_midr_in_range to is_midr_in_range_list to traverse the
> > > neoverse_spe array so that all neoverse cores synthesize event with data
> > > source packet.
> > > 
> > > Fixes: 4e6430cbb1a9("perf arm-spe: Use SPE data source for neoverse cores")
> > > Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>
> > 
> > Thanks for catching this, you're absolutely right.
> > 
> > Reviewed-by: Ali Saidi <alisaidi@amazon.com>
> 
> It's also good for me:
> Reviewed-by: Leo Yan <leo.yan@linaro.org>

Thanks, applied.

- Arnaldo


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-09-28 14:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-26 13:03 [PATCH] perf arm-spe: augment the data source type with neoverse_spe list Jing Zhang
2022-09-26 13:03 ` Jing Zhang
2022-09-26 14:10 ` Ali Saidi
2022-09-26 14:10   ` Ali Saidi
2022-09-26 15:00   ` Leo Yan
2022-09-26 15:00     ` Leo Yan
2022-09-28 14:20     ` Arnaldo Carvalho de Melo [this message]
2022-09-28 14:20       ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YzRYO9aJxI4twVVj@kernel.org \
    --to=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=alisaidi@amazon.com \
    --cc=german.gomez@arm.com \
    --cc=james.clark@arm.com \
    --cc=john.garry@huawei.com \
    --cc=jolsa@kernel.org \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mike.leach@linaro.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=renyu.zj@linux.alibaba.com \
    --cc=timothy.hayes@arm.com \
    --cc=will@kernel.org \
    --cc=xueshuai@linux.alibaba.com \
    --cc=zhuo.song@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.