All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Li Huafei <lihuafei1@huawei.com>
Cc: catalin.marinas@arm.com, will@kernel.org, rostedt@goodmis.org,
	mingo@redhat.com, Julia.Lawall@inria.fr,
	akpm@linux-foundation.org, andreyknvl@gmail.com,
	elver@google.com, wangkefeng.wang@huawei.com,
	zhouchengming@bytedance.com, ardb@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] arm64: module: Make plt_equals_entry() static
Date: Thu, 29 Sep 2022 12:27:39 +0100	[thread overview]
Message-ID: <YzWBK3fkxWAlZUYc@FVFF77S0Q05N> (raw)
In-Reply-To: <20220929094134.99512-2-lihuafei1@huawei.com>

On Thu, Sep 29, 2022 at 05:41:32PM +0800, Li Huafei wrote:
> Since commit 4e69ecf4da1e ("arm64/module: ftrace: deal with place
> relative nature of PLTs"), plt_equals_entry() is not used outside of
> module-plts.c, so make it static.
> 
> Signed-off-by: Li Huafei <lihuafei1@huawei.com>

Acked-by: Mark Rutland <mark.rutland@arm.com>

Mark.

> ---
>  arch/arm64/include/asm/module.h | 1 -
>  arch/arm64/kernel/module-plts.c | 3 ++-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/include/asm/module.h b/arch/arm64/include/asm/module.h
> index 4e7fa2623896..28514b989a0b 100644
> --- a/arch/arm64/include/asm/module.h
> +++ b/arch/arm64/include/asm/module.h
> @@ -58,7 +58,6 @@ static inline bool is_forbidden_offset_for_adrp(void *place)
>  }
>  
>  struct plt_entry get_plt_entry(u64 dst, void *pc);
> -bool plt_entries_equal(const struct plt_entry *a, const struct plt_entry *b);
>  
>  static inline bool plt_entry_is_initialized(const struct plt_entry *e)
>  {
> diff --git a/arch/arm64/kernel/module-plts.c b/arch/arm64/kernel/module-plts.c
> index a3d0494f25a9..5a0a8f552a61 100644
> --- a/arch/arm64/kernel/module-plts.c
> +++ b/arch/arm64/kernel/module-plts.c
> @@ -37,7 +37,8 @@ struct plt_entry get_plt_entry(u64 dst, void *pc)
>  	return plt;
>  }
>  
> -bool plt_entries_equal(const struct plt_entry *a, const struct plt_entry *b)
> +static bool plt_entries_equal(const struct plt_entry *a,
> +			      const struct plt_entry *b)
>  {
>  	u64 p, q;
>  
> -- 
> 2.17.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Li Huafei <lihuafei1@huawei.com>
Cc: catalin.marinas@arm.com, will@kernel.org, rostedt@goodmis.org,
	mingo@redhat.com, Julia.Lawall@inria.fr,
	akpm@linux-foundation.org, andreyknvl@gmail.com,
	elver@google.com, wangkefeng.wang@huawei.com,
	zhouchengming@bytedance.com, ardb@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] arm64: module: Make plt_equals_entry() static
Date: Thu, 29 Sep 2022 12:27:39 +0100	[thread overview]
Message-ID: <YzWBK3fkxWAlZUYc@FVFF77S0Q05N> (raw)
In-Reply-To: <20220929094134.99512-2-lihuafei1@huawei.com>

On Thu, Sep 29, 2022 at 05:41:32PM +0800, Li Huafei wrote:
> Since commit 4e69ecf4da1e ("arm64/module: ftrace: deal with place
> relative nature of PLTs"), plt_equals_entry() is not used outside of
> module-plts.c, so make it static.
> 
> Signed-off-by: Li Huafei <lihuafei1@huawei.com>

Acked-by: Mark Rutland <mark.rutland@arm.com>

Mark.

> ---
>  arch/arm64/include/asm/module.h | 1 -
>  arch/arm64/kernel/module-plts.c | 3 ++-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/include/asm/module.h b/arch/arm64/include/asm/module.h
> index 4e7fa2623896..28514b989a0b 100644
> --- a/arch/arm64/include/asm/module.h
> +++ b/arch/arm64/include/asm/module.h
> @@ -58,7 +58,6 @@ static inline bool is_forbidden_offset_for_adrp(void *place)
>  }
>  
>  struct plt_entry get_plt_entry(u64 dst, void *pc);
> -bool plt_entries_equal(const struct plt_entry *a, const struct plt_entry *b);
>  
>  static inline bool plt_entry_is_initialized(const struct plt_entry *e)
>  {
> diff --git a/arch/arm64/kernel/module-plts.c b/arch/arm64/kernel/module-plts.c
> index a3d0494f25a9..5a0a8f552a61 100644
> --- a/arch/arm64/kernel/module-plts.c
> +++ b/arch/arm64/kernel/module-plts.c
> @@ -37,7 +37,8 @@ struct plt_entry get_plt_entry(u64 dst, void *pc)
>  	return plt;
>  }
>  
> -bool plt_entries_equal(const struct plt_entry *a, const struct plt_entry *b)
> +static bool plt_entries_equal(const struct plt_entry *a,
> +			      const struct plt_entry *b)
>  {
>  	u64 p, q;
>  
> -- 
> 2.17.1
> 

  reply	other threads:[~2022-09-29 11:28 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-29  9:41 [PATCH 0/3] arm64: module/ftrace: Fix mcount-based ftrace initialization failure Li Huafei
2022-09-29  9:41 ` Li Huafei
2022-09-29  9:41 ` [PATCH 1/3] arm64: module: Make plt_equals_entry() static Li Huafei
2022-09-29  9:41   ` Li Huafei
2022-09-29 11:27   ` Mark Rutland [this message]
2022-09-29 11:27     ` Mark Rutland
2022-09-29  9:41 ` [PATCH 2/3] arm64: module: Remove unused plt_entry_is_initialized() Li Huafei
2022-09-29  9:41   ` Li Huafei
2022-09-29 11:28   ` Mark Rutland
2022-09-29 11:28     ` Mark Rutland
2022-09-29  9:41 ` [PATCH 3/3] arm64: module/ftrace: Fix mcount-based ftrace initialization failure Li Huafei
2022-09-29  9:41   ` Li Huafei
2022-09-29 11:26   ` Mark Rutland
2022-09-29 11:26     ` Mark Rutland
2022-09-29 11:59     ` Mark Rutland
2022-09-29 11:59       ` Mark Rutland
2022-09-29 12:26       ` Li Huafei
2022-09-29 12:26         ` Li Huafei
2022-09-29 13:41         ` Mark Rutland
2022-09-29 13:41           ` Mark Rutland
2022-09-29 17:54 ` (subset) [PATCH 0/3] " Catalin Marinas
2022-09-29 17:54   ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YzWBK3fkxWAlZUYc@FVFF77S0Q05N \
    --to=mark.rutland@arm.com \
    --cc=Julia.Lawall@inria.fr \
    --cc=akpm@linux-foundation.org \
    --cc=andreyknvl@gmail.com \
    --cc=ardb@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=elver@google.com \
    --cc=lihuafei1@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=wangkefeng.wang@huawei.com \
    --cc=will@kernel.org \
    --cc=zhouchengming@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.