* Re: [PATCHv2] block: use the request length for iov alignment [not found] <20220923153451.3810456-1-kbusch@fb.com> @ 2022-09-29 16:09 ` Keith Busch 2022-09-29 17:59 ` Kevin Wolf 0 siblings, 1 reply; 3+ messages in thread From: Keith Busch @ 2022-09-29 16:09 UTC (permalink / raw) To: Keith Busch Cc: qemu-block, Stefan Hajnoczi, Kevin Wolf, Jens Axboe, Damien Le Moal, Maxim Levitsky, qemu-devel On Fri, Sep 23, 2022 at 08:34:51AM -0700, Keith Busch wrote: > > An iov length needs to be aligned to the logical block size, which may > be larger than the memory alignment. And since this is only used with > file-posix backing storage, move the alignment function to there, where > the value of the request_alignment is known to be the file's logical > block size. Any objections to this version? This is fixing real bug reports that may become more frequent without this patch. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCHv2] block: use the request length for iov alignment 2022-09-29 16:09 ` [PATCHv2] block: use the request length for iov alignment Keith Busch @ 2022-09-29 17:59 ` Kevin Wolf 2022-09-29 20:04 ` Keith Busch 0 siblings, 1 reply; 3+ messages in thread From: Kevin Wolf @ 2022-09-29 17:59 UTC (permalink / raw) To: Keith Busch Cc: Keith Busch, qemu-block, Stefan Hajnoczi, Jens Axboe, Damien Le Moal, Maxim Levitsky, qemu-devel Am 29.09.2022 um 18:09 hat Keith Busch geschrieben: > On Fri, Sep 23, 2022 at 08:34:51AM -0700, Keith Busch wrote: > > > > An iov length needs to be aligned to the logical block size, which may > > be larger than the memory alignment. And since this is only used with > > file-posix backing storage, move the alignment function to there, where > > the value of the request_alignment is known to be the file's logical > > block size. > > Any objections to this version? This is fixing real bug reports that > may become more frequent without this patch. I think it is okay. Splitting it in two patches would have been nicer (one for moving code, one for making the change), but it's small enough that I can ignore that. I'll probably merge it tomorrow. Kevin ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCHv2] block: use the request length for iov alignment 2022-09-29 17:59 ` Kevin Wolf @ 2022-09-29 20:04 ` Keith Busch 0 siblings, 0 replies; 3+ messages in thread From: Keith Busch @ 2022-09-29 20:04 UTC (permalink / raw) To: Kevin Wolf Cc: Keith Busch, qemu-block, Stefan Hajnoczi, Jens Axboe, Damien Le Moal, Maxim Levitsky, qemu-devel On Thu, Sep 29, 2022 at 07:59:50PM +0200, Kevin Wolf wrote: > Am 29.09.2022 um 18:09 hat Keith Busch geschrieben: > > On Fri, Sep 23, 2022 at 08:34:51AM -0700, Keith Busch wrote: > > > > > > An iov length needs to be aligned to the logical block size, which may > > > be larger than the memory alignment. And since this is only used with > > > file-posix backing storage, move the alignment function to there, where > > > the value of the request_alignment is known to be the file's logical > > > block size. > > > > Any objections to this version? This is fixing real bug reports that > > may become more frequent without this patch. > > I think it is okay. Splitting it in two patches would have been nicer > (one for moving code, one for making the change), but it's small enough > that I can ignore that. I'll probably merge it tomorrow. I agree that splitting makes the functional change stand out, otherwise a casual look may mistake the patch as a simple function move. I'll send you a new version. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-29 20:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220923153451.3810456-1-kbusch@fb.com>
2022-09-29 16:09 ` [PATCHv2] block: use the request length for iov alignment Keith Busch
2022-09-29 17:59 ` Kevin Wolf
2022-09-29 20:04 ` Keith Busch
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.