* [PATCH] usb: dwc3: st: Rely on child's compatible instead of name
@ 2022-09-30 6:44 ` patrice.chotard
0 siblings, 0 replies; 6+ messages in thread
From: patrice.chotard @ 2022-09-30 6:44 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman, linux-arm-kernel, linux-usb,
linux-kernel
Cc: patrice.chotard, Jerome Audu
From: Patrice Chotard <patrice.chotard@foss.st.com>
To ensure that child node is found, don't rely on child's node name
which can take different value, but on child's compatible name.
Cc: Jerome Audu <jerome.audu@st.com>
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
drivers/usb/dwc3/dwc3-st.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
index 166b5bde45cb..fea5290de83f 100644
--- a/drivers/usb/dwc3/dwc3-st.c
+++ b/drivers/usb/dwc3/dwc3-st.c
@@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev)
/* Manage SoftReset */
reset_control_deassert(dwc3_data->rstc_rst);
- child = of_get_child_by_name(node, "dwc3");
+ child = of_get_compatible_child(node, "snps,dwc3");
if (!child) {
dev_err(&pdev->dev, "failed to find dwc3 core node\n");
ret = -ENODEV;
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] usb: dwc3: st: Rely on child's compatible instead of name
@ 2022-09-30 6:44 ` patrice.chotard
0 siblings, 0 replies; 6+ messages in thread
From: patrice.chotard @ 2022-09-30 6:44 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman, linux-arm-kernel, linux-usb,
linux-kernel
Cc: patrice.chotard, Jerome Audu
From: Patrice Chotard <patrice.chotard@foss.st.com>
To ensure that child node is found, don't rely on child's node name
which can take different value, but on child's compatible name.
Cc: Jerome Audu <jerome.audu@st.com>
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
drivers/usb/dwc3/dwc3-st.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
index 166b5bde45cb..fea5290de83f 100644
--- a/drivers/usb/dwc3/dwc3-st.c
+++ b/drivers/usb/dwc3/dwc3-st.c
@@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev)
/* Manage SoftReset */
reset_control_deassert(dwc3_data->rstc_rst);
- child = of_get_child_by_name(node, "dwc3");
+ child = of_get_compatible_child(node, "snps,dwc3");
if (!child) {
dev_err(&pdev->dev, "failed to find dwc3 core node\n");
ret = -ENODEV;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] usb: dwc3: st: Rely on child's compatible instead of name
2022-09-30 6:44 ` patrice.chotard
@ 2022-09-30 6:50 ` Greg Kroah-Hartman
-1 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2022-09-30 6:50 UTC (permalink / raw)
To: patrice.chotard
Cc: Felipe Balbi, linux-arm-kernel, linux-usb, linux-kernel,
Jerome Audu
On Fri, Sep 30, 2022 at 08:44:06AM +0200, patrice.chotard@foss.st.com wrote:
> From: Patrice Chotard <patrice.chotard@foss.st.com>
>
> To ensure that child node is found, don't rely on child's node name
> which can take different value, but on child's compatible name.
>
> Cc: Jerome Audu <jerome.audu@st.com>
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
What commit id does this fix?
Who reported the problem?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: dwc3: st: Rely on child's compatible instead of name
@ 2022-09-30 6:50 ` Greg Kroah-Hartman
0 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2022-09-30 6:50 UTC (permalink / raw)
To: patrice.chotard
Cc: Felipe Balbi, linux-arm-kernel, linux-usb, linux-kernel,
Jerome Audu
On Fri, Sep 30, 2022 at 08:44:06AM +0200, patrice.chotard@foss.st.com wrote:
> From: Patrice Chotard <patrice.chotard@foss.st.com>
>
> To ensure that child node is found, don't rely on child's node name
> which can take different value, but on child's compatible name.
>
> Cc: Jerome Audu <jerome.audu@st.com>
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
What commit id does this fix?
Who reported the problem?
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: dwc3: st: Rely on child's compatible instead of name
2022-09-30 6:50 ` Greg Kroah-Hartman
@ 2022-09-30 7:14 ` Patrice CHOTARD
-1 siblings, 0 replies; 6+ messages in thread
From: Patrice CHOTARD @ 2022-09-30 7:14 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Felipe Balbi, linux-arm-kernel, linux-usb, linux-kernel,
Jerome Audu
Hi Greg
On 9/30/22 08:50, Greg Kroah-Hartman wrote:
> On Fri, Sep 30, 2022 at 08:44:06AM +0200, patrice.chotard@foss.st.com wrote:
>> From: Patrice Chotard <patrice.chotard@foss.st.com>
>>
>> To ensure that child node is found, don't rely on child's node name
>> which can take different value, but on child's compatible name.
>>
>> Cc: Jerome Audu <jerome.audu@st.com>
>> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
>
> What commit id does this fix?
A fix has been already merged [1]
The goal of this patch is to hardened the child's check, but okay,
i will add a Fixes reference.
>
> Who reported the problem?
Ah, sorry, i forgot to add reported-by Felipe Balbi <felipe@balbi.sh>
Will send a v2
Thanks
Patrice
[1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20220926124359.304770-1-patrice.chotard@foss.st.com
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: dwc3: st: Rely on child's compatible instead of name
@ 2022-09-30 7:14 ` Patrice CHOTARD
0 siblings, 0 replies; 6+ messages in thread
From: Patrice CHOTARD @ 2022-09-30 7:14 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Felipe Balbi, linux-arm-kernel, linux-usb, linux-kernel,
Jerome Audu
Hi Greg
On 9/30/22 08:50, Greg Kroah-Hartman wrote:
> On Fri, Sep 30, 2022 at 08:44:06AM +0200, patrice.chotard@foss.st.com wrote:
>> From: Patrice Chotard <patrice.chotard@foss.st.com>
>>
>> To ensure that child node is found, don't rely on child's node name
>> which can take different value, but on child's compatible name.
>>
>> Cc: Jerome Audu <jerome.audu@st.com>
>> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
>
> What commit id does this fix?
A fix has been already merged [1]
The goal of this patch is to hardened the child's check, but okay,
i will add a Fixes reference.
>
> Who reported the problem?
Ah, sorry, i forgot to add reported-by Felipe Balbi <felipe@balbi.sh>
Will send a v2
Thanks
Patrice
[1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20220926124359.304770-1-patrice.chotard@foss.st.com
>
> thanks,
>
> greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-30 7:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-30 6:44 [PATCH] usb: dwc3: st: Rely on child's compatible instead of name patrice.chotard
2022-09-30 6:44 ` patrice.chotard
2022-09-30 6:50 ` Greg Kroah-Hartman
2022-09-30 6:50 ` Greg Kroah-Hartman
2022-09-30 7:14 ` Patrice CHOTARD
2022-09-30 7:14 ` Patrice CHOTARD
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.