From: Drew Fustini <drew@pdp7.com>
To: Michal Wilczynski <m.wilczynski@samsung.com>
Cc: mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, guoren@kernel.org,
wefu@redhat.com, jassisinghbrar@gmail.com,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, frank.binns@imgtec.com,
matt.coster@imgtec.com, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com,
simona@ffwll.ch, ulf.hansson@linaro.org, jszhang@kernel.org,
p.zabel@pengutronix.de, m.szyprowski@samsung.com,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
dri-devel@lists.freedesktop.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v5 19/21] riscv: dts: thead: Introduce power domain nodes with aon firmware
Date: Mon, 14 Apr 2025 19:04:29 -0700 [thread overview]
Message-ID: <Z/2+rbhsaBP0DQop@x1> (raw)
In-Reply-To: <20250219140239.1378758-20-m.wilczynski@samsung.com>
On Wed, Feb 19, 2025 at 03:02:37PM +0100, Michal Wilczynski wrote:
> The DRM Imagination GPU requires a power-domain driver. In the T-HEAD
> TH1520 SoC implements power management capabilities through the E902
> core, which can be communicated with through the mailbox, using firmware
> protocol.
>
> Add AON node, which servers as a power-domain controller.
>
> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>
> ---
> arch/riscv/boot/dts/thead/th1520.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi
> index 197df1f32b25..474f31576a1b 100644
> --- a/arch/riscv/boot/dts/thead/th1520.dtsi
> +++ b/arch/riscv/boot/dts/thead/th1520.dtsi
> @@ -6,6 +6,7 @@
>
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/clock/thead,th1520-clk-ap.h>
> +#include <dt-bindings/power/thead,th1520-power.h>
>
> / {
> compatible = "thead,th1520";
> @@ -229,6 +230,13 @@ stmmac_axi_config: stmmac-axi-config {
> snps,blen = <0 0 64 32 0 0 0>;
> };
>
> + aon: aon {
> + compatible = "thead,th1520-aon";
> + mboxes = <&mbox_910t 1>;
> + mbox-names = "aon";
> + #power-domain-cells = <1>;
> + };
> +
> soc {
> compatible = "simple-bus";
> interrupt-parent = <&plic>;
> --
> 2.34.1
>
Reviewed-by: Drew Fustini <drew@pdp7.com>
I tested this on top of 6.15-rc1 and found no issues.
-Drew
WARNING: multiple messages have this Message-ID (diff)
From: Drew Fustini <drew@pdp7.com>
To: Michal Wilczynski <m.wilczynski@samsung.com>
Cc: mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, guoren@kernel.org,
wefu@redhat.com, jassisinghbrar@gmail.com,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, frank.binns@imgtec.com,
matt.coster@imgtec.com, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com,
simona@ffwll.ch, ulf.hansson@linaro.org, jszhang@kernel.org,
p.zabel@pengutronix.de, m.szyprowski@samsung.com,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
dri-devel@lists.freedesktop.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v5 19/21] riscv: dts: thead: Introduce power domain nodes with aon firmware
Date: Mon, 14 Apr 2025 19:04:29 -0700 [thread overview]
Message-ID: <Z/2+rbhsaBP0DQop@x1> (raw)
In-Reply-To: <20250219140239.1378758-20-m.wilczynski@samsung.com>
On Wed, Feb 19, 2025 at 03:02:37PM +0100, Michal Wilczynski wrote:
> The DRM Imagination GPU requires a power-domain driver. In the T-HEAD
> TH1520 SoC implements power management capabilities through the E902
> core, which can be communicated with through the mailbox, using firmware
> protocol.
>
> Add AON node, which servers as a power-domain controller.
>
> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>
> ---
> arch/riscv/boot/dts/thead/th1520.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi
> index 197df1f32b25..474f31576a1b 100644
> --- a/arch/riscv/boot/dts/thead/th1520.dtsi
> +++ b/arch/riscv/boot/dts/thead/th1520.dtsi
> @@ -6,6 +6,7 @@
>
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/clock/thead,th1520-clk-ap.h>
> +#include <dt-bindings/power/thead,th1520-power.h>
>
> / {
> compatible = "thead,th1520";
> @@ -229,6 +230,13 @@ stmmac_axi_config: stmmac-axi-config {
> snps,blen = <0 0 64 32 0 0 0>;
> };
>
> + aon: aon {
> + compatible = "thead,th1520-aon";
> + mboxes = <&mbox_910t 1>;
> + mbox-names = "aon";
> + #power-domain-cells = <1>;
> + };
> +
> soc {
> compatible = "simple-bus";
> interrupt-parent = <&plic>;
> --
> 2.34.1
>
Reviewed-by: Drew Fustini <drew@pdp7.com>
I tested this on top of 6.15-rc1 and found no issues.
-Drew
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-04-15 2:04 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250219140249eucas1p1291eb86c932373c847a3314ae54789d5@eucas1p1.samsung.com>
2025-02-19 14:02 ` [PATCH v5 00/21] Enable drm/imagination BXM-4-64 Support for LicheePi 4A Michal Wilczynski
2025-02-19 14:02 ` Michal Wilczynski
2025-02-19 14:02 ` [PATCH v5 01/21] dt-bindings: clock: thead: Add TH1520 VO clock controller Michal Wilczynski
2025-02-19 14:02 ` Michal Wilczynski
2025-02-19 14:02 ` [PATCH v5 02/21] clk: thead: Add clock support for VO subsystem in T-Head TH1520 SoC Michal Wilczynski
2025-02-19 14:02 ` Michal Wilczynski
2025-02-19 14:02 ` [PATCH v5 03/21] dt-bindings: firmware: thead,th1520: Add support for firmware node Michal Wilczynski
2025-02-19 14:02 ` Michal Wilczynski
2025-02-19 14:02 ` [PATCH v5 04/21] firmware: thead: Add AON firmware protocol driver Michal Wilczynski
2025-02-19 14:02 ` Michal Wilczynski
2025-02-19 14:02 ` [PATCH v5 05/21] dt-bindings: power: Add TH1520 SoC power domains Michal Wilczynski
2025-02-19 14:02 ` Michal Wilczynski
2025-02-19 14:02 ` [PATCH v5 06/21] pmdomain: thead: Add power-domain driver for TH1520 Michal Wilczynski
2025-02-19 14:02 ` Michal Wilczynski
2025-02-19 14:02 ` [PATCH v5 07/21] riscv: Enable PM_GENERIC_DOMAINS for T-Head SoCs Michal Wilczynski
2025-02-19 14:02 ` Michal Wilczynski
2025-02-19 14:02 ` [PATCH v5 08/21] clk: thead: Add support for custom ops in CCU_GATE_CLK_OPS macro Michal Wilczynski
2025-02-19 14:02 ` Michal Wilczynski
2025-02-19 14:02 ` [PATCH v5 09/21] dt-bindings: clock: thead: Add GPU clkgen reset property Michal Wilczynski
2025-02-19 14:02 ` Michal Wilczynski
2025-02-21 9:11 ` Krzysztof Kozlowski
2025-02-21 9:11 ` Krzysztof Kozlowski
2025-03-03 8:42 ` Michal Wilczynski
2025-03-03 8:42 ` Michal Wilczynski
2025-03-03 8:52 ` Krzysztof Kozlowski
2025-03-03 8:52 ` Krzysztof Kozlowski
2025-03-03 9:55 ` Michal Wilczynski
2025-03-03 9:55 ` Michal Wilczynski
2025-03-03 14:07 ` Krzysztof Kozlowski
2025-03-03 14:07 ` Krzysztof Kozlowski
2025-02-19 14:02 ` [PATCH v5 10/21] clk: thead: Add GPU clock gate control with CLKGEN reset support Michal Wilczynski
2025-02-19 14:02 ` Michal Wilczynski
2025-02-19 14:02 ` [PATCH v5 11/21] dt-bindings: reset: Add T-HEAD TH1520 SoC Reset Controller Michal Wilczynski
2025-02-19 14:02 ` Michal Wilczynski
2025-02-19 14:02 ` [PATCH v5 12/21] reset: thead: Add TH1520 reset controller driver Michal Wilczynski
2025-02-19 14:02 ` Michal Wilczynski
2025-02-19 15:01 ` Philipp Zabel
2025-02-19 15:01 ` Philipp Zabel
2025-02-20 11:59 ` Michal Wilczynski
2025-02-20 11:59 ` Michal Wilczynski
2025-02-19 14:02 ` [PATCH v5 13/21] drm/imagination: Add reset controller support for GPU initialization Michal Wilczynski
2025-02-19 14:02 ` Michal Wilczynski
2025-04-16 14:25 ` Michal Wilczynski
2025-04-16 14:25 ` Michal Wilczynski
2025-04-16 16:53 ` Matt Coster
2025-04-16 16:53 ` Matt Coster
2025-02-19 14:02 ` [PATCH v5 14/21] dt-bindings: gpu: Add 'resets' property " Michal Wilczynski
2025-02-19 14:02 ` Michal Wilczynski
2025-02-19 14:02 ` [PATCH v5 15/21] dt-bindings: gpu: Add support for T-HEAD TH1520 GPU Michal Wilczynski
2025-02-19 14:02 ` Michal Wilczynski
2025-02-21 9:16 ` Krzysztof Kozlowski
2025-02-21 9:16 ` Krzysztof Kozlowski
2025-02-19 14:02 ` [PATCH v5 16/21] drm/imagination: Add support for IMG BXM-4-64 GPU Michal Wilczynski
2025-02-19 14:02 ` Michal Wilczynski
2025-02-19 14:02 ` [PATCH v5 17/21] drm/imagination: Enable PowerVR driver for RISC-V Michal Wilczynski
2025-02-19 14:02 ` Michal Wilczynski
2025-02-19 14:02 ` [PATCH v5 18/21] riscv: dts: thead: Add device tree VO clock controller Michal Wilczynski
2025-02-19 14:02 ` Michal Wilczynski
2025-02-19 14:02 ` [PATCH v5 19/21] riscv: dts: thead: Introduce power domain nodes with aon firmware Michal Wilczynski
2025-02-19 14:02 ` Michal Wilczynski
2025-04-15 2:04 ` Drew Fustini [this message]
2025-04-15 2:04 ` Drew Fustini
2025-04-15 18:48 ` Drew Fustini
2025-04-15 18:48 ` Drew Fustini
2025-04-16 11:22 ` Michal Wilczynski
2025-04-16 11:22 ` Michal Wilczynski
2025-02-19 14:02 ` [PATCH v5 20/21] riscv: dts: thead: Introduce reset controller node Michal Wilczynski
2025-02-19 14:02 ` Michal Wilczynski
2025-04-19 19:09 ` Drew Fustini
2025-04-19 19:09 ` Drew Fustini
2025-04-22 7:47 ` Michal Wilczynski
2025-04-22 7:47 ` Michal Wilczynski
2025-04-25 19:16 ` Drew Fustini
2025-04-25 19:16 ` Drew Fustini
2025-02-19 14:02 ` [PATCH v5 21/21] riscv: dts: thead: Add GPU node to TH1520 device tree Michal Wilczynski
2025-02-19 14:02 ` Michal Wilczynski
2025-02-21 9:12 ` [PATCH v5 00/21] Enable drm/imagination BXM-4-64 Support for LicheePi 4A Krzysztof Kozlowski
2025-02-21 9:12 ` Krzysztof Kozlowski
2025-03-03 8:38 ` Michal Wilczynski
2025-03-03 8:38 ` Michal Wilczynski
2025-03-03 17:43 ` Krzysztof Kozlowski
2025-03-03 17:43 ` Krzysztof Kozlowski
2025-03-04 7:38 ` Michal Wilczynski
2025-03-04 7:38 ` Michal Wilczynski
2025-03-04 7:44 ` Krzysztof Kozlowski
2025-03-04 7:44 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z/2+rbhsaBP0DQop@x1 \
--to=drew@pdp7.com \
--cc=airlied@gmail.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frank.binns@imgtec.com \
--cc=guoren@kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=jszhang@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=m.szyprowski@samsung.com \
--cc=m.wilczynski@samsung.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matt.coster@imgtec.com \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=ulf.hansson@linaro.org \
--cc=wefu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.