From: Nicolin Chen <nicolinc@nvidia.com>
To: "Aneesh Kumar K.V (Arm)" <aneesh.kumar@kernel.org>
Cc: <iommu@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <will@kernel.org>,
<robin.murphy@arm.com>, <jgg@ziepe.ca>, <jsnitsel@redhat.com>,
<praan@google.com>, <kevin.tian@intel.com>, <ddutile@redhat.com>
Subject: Re: [PATCH] iommu/arm-smmu-v3: Add missing S2FWB feature detection
Date: Tue, 8 Apr 2025 00:31:23 -0700 [thread overview]
Message-ID: <Z/TQywPiu7Wmtz7S@nvidia.com> (raw)
In-Reply-To: <20250408033351.1012411-1-aneesh.kumar@kernel.org>
On Tue, Apr 08, 2025 at 09:03:51AM +0530, Aneesh Kumar K.V (Arm) wrote:
> Commit 67e4fe398513 ("iommu/arm-smmu-v3: Use S2FWB for NESTED domains")
> introduced S2FWB usage but omitted the corresponding feature detection.
> As a result, vIOMMU allocation fails on FVP in arm_vsmmu_alloc(), due to
> the following check:
>
> if (!arm_smmu_master_canwbs(master) &&
> !(smmu->features & ARM_SMMU_FEAT_S2FWB))
> return ERR_PTR(-EOPNOTSUPP);
>
> This patch adds the missing detection logic to prevent allocation
> failure when S2FWB is supported.
>
> Fixes: 67e4fe398513 ("iommu/arm-smmu-v3: Use S2FWB for NESTED domains")
> Signed-off-by: Aneesh Kumar K.V (Arm) <aneesh.kumar@kernel.org>
Reviewed-by: Nicolin Chen <nicolinc@nvidia.com>
next prev parent reply other threads:[~2025-04-08 7:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 3:33 [PATCH] iommu/arm-smmu-v3: Add missing S2FWB feature detection Aneesh Kumar K.V (Arm)
2025-04-08 5:30 ` Pranjal Shrivastava
2025-04-08 7:31 ` Nicolin Chen [this message]
2025-04-08 12:09 ` Jason Gunthorpe
2025-04-11 16:03 ` Will Deacon
2025-04-17 14:27 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z/TQywPiu7Wmtz7S@nvidia.com \
--to=nicolinc@nvidia.com \
--cc=aneesh.kumar@kernel.org \
--cc=ddutile@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=jsnitsel@redhat.com \
--cc=kevin.tian@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=praan@google.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.