* [PATCH] target/i386: Fix model number of Zhaoxin YongFeng vCPU template
@ 2025-03-31 8:03 Ewan Hai
2025-04-01 15:27 ` Zhao Liu
0 siblings, 1 reply; 2+ messages in thread
From: Ewan Hai @ 2025-03-31 8:03 UTC (permalink / raw)
To: pbonzini, zhao1.liu; +Cc: qemu-devel
The model number was mistakenly set to 0x0b (11) in commit ff04bc1ac4.
The correct value is 0x5b. This mistake occurred because the extended
model bits in cpuid[eax=0x1].eax were overlooked, and only the base
model was used.
This patch corrects the model field.
Signed-off-by: Ewan Hai <ewanhai-oc@zhaoxin.com>
---
target/i386/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 1b64ceaaba..0dd9788a68 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -5503,7 +5503,7 @@ static const X86CPUDefinition builtin_x86_defs[] = {
.level = 0x1F,
.vendor = CPUID_VENDOR_ZHAOXIN1,
.family = 7,
- .model = 11,
+ .model = 0x5b,
.stepping = 3,
/* missing: CPUID_HT, CPUID_TM, CPUID_PBE */
.features[FEAT_1_EDX] =
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] target/i386: Fix model number of Zhaoxin YongFeng vCPU template
2025-03-31 8:03 [PATCH] target/i386: Fix model number of Zhaoxin YongFeng vCPU template Ewan Hai
@ 2025-04-01 15:27 ` Zhao Liu
0 siblings, 0 replies; 2+ messages in thread
From: Zhao Liu @ 2025-04-01 15:27 UTC (permalink / raw)
To: Ewan Hai; +Cc: pbonzini, qemu-devel
On Mon, Mar 31, 2025 at 04:03:56AM -0400, Ewan Hai wrote:
> Date: Mon, 31 Mar 2025 04:03:56 -0400
> From: Ewan Hai <ewanhai-oc@zhaoxin.com>
> Subject: [PATCH] target/i386: Fix model number of Zhaoxin YongFeng vCPU
> template
> X-Mailer: git-send-email 2.34.1
>
> The model number was mistakenly set to 0x0b (11) in commit ff04bc1ac4.
> The correct value is 0x5b. This mistake occurred because the extended
> model bits in cpuid[eax=0x1].eax were overlooked, and only the base
> model was used.
>
> This patch corrects the model field.
It's better to add:
Fixes: ff04bc1ac4 ("target/i386: Introduce Zhaoxin Yongfeng CPU model")
> Signed-off-by: Ewan Hai <ewanhai-oc@zhaoxin.com>
> ---
> target/i386/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-01 15:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-31 8:03 [PATCH] target/i386: Fix model number of Zhaoxin YongFeng vCPU template Ewan Hai
2025-04-01 15:27 ` Zhao Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.