From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz,
torvalds@linux-foundation.org, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org
Subject: Re: [Intel-wired-lan] [RFC] slab: introduce auto_kfree macro
Date: Wed, 2 Apr 2025 15:55:38 +0300 [thread overview]
Message-ID: <Z-0zykUvrF-73MXI@smile.fi.intel.com> (raw)
In-Reply-To: <20250402122104.GK25239@noisy.programming.kicks-ass.net>
On Wed, Apr 02, 2025 at 02:21:04PM +0200, Peter Zijlstra wrote:
> On Wed, Apr 02, 2025 at 01:32:51PM +0300, Andy Shevchenko wrote:
> > What would be better in my opinion is to have it something like DEFINE_*()
> > type, which will look more naturally in the current kernel codebase
> > (as we have tons of DEFINE_FOO().
> >
> > DEFINE_AUTO_KFREE_VAR(name, struct foo);
>
> Still weird. Much better to have the compiler complain about the
> obvious use of uninitialized.
That would be ideal!
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz,
torvalds@linux-foundation.org, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org
Subject: Re: [RFC] slab: introduce auto_kfree macro
Date: Wed, 2 Apr 2025 15:55:38 +0300 [thread overview]
Message-ID: <Z-0zykUvrF-73MXI@smile.fi.intel.com> (raw)
In-Reply-To: <20250402122104.GK25239@noisy.programming.kicks-ass.net>
On Wed, Apr 02, 2025 at 02:21:04PM +0200, Peter Zijlstra wrote:
> On Wed, Apr 02, 2025 at 01:32:51PM +0300, Andy Shevchenko wrote:
> > What would be better in my opinion is to have it something like DEFINE_*()
> > type, which will look more naturally in the current kernel codebase
> > (as we have tons of DEFINE_FOO().
> >
> > DEFINE_AUTO_KFREE_VAR(name, struct foo);
>
> Still weird. Much better to have the compiler complain about the
> obvious use of uninitialized.
That would be ideal!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-04-02 12:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 13:44 [Intel-wired-lan] [RFC] slab: introduce auto_kfree macro Przemek Kitszel
2025-04-01 13:44 ` Przemek Kitszel
2025-04-02 10:32 ` [Intel-wired-lan] " Andy Shevchenko
2025-04-02 10:32 ` Andy Shevchenko
2025-04-02 10:40 ` [Intel-wired-lan] " Andy Shevchenko
2025-04-02 10:40 ` Andy Shevchenko
2025-04-02 12:19 ` [Intel-wired-lan] " Peter Zijlstra
2025-04-02 12:19 ` Peter Zijlstra
2025-04-02 12:22 ` [Intel-wired-lan] " Peter Zijlstra
2025-04-02 12:22 ` Peter Zijlstra
2025-04-02 12:57 ` [Intel-wired-lan] " Andy Shevchenko
2025-04-02 12:57 ` Andy Shevchenko
2025-04-04 3:05 ` [Intel-wired-lan] " Herbert Xu
2025-04-04 3:05 ` Herbert Xu
2025-04-02 12:21 ` [Intel-wired-lan] " Peter Zijlstra
2025-04-02 12:21 ` Peter Zijlstra
2025-04-02 12:55 ` Andy Shevchenko [this message]
2025-04-02 12:55 ` Andy Shevchenko
2025-04-02 10:44 ` [Intel-wired-lan] " Vlastimil Babka
2025-04-02 10:44 ` Vlastimil Babka
2025-04-03 16:59 ` [Intel-wired-lan] " Kees Cook
2025-04-03 16:59 ` Kees Cook
2025-04-03 17:35 ` [Intel-wired-lan] " Matthew Wilcox
2025-04-03 17:35 ` Matthew Wilcox
2025-04-03 17:46 ` [Intel-wired-lan] " Andy Shevchenko
2025-04-03 17:46 ` Andy Shevchenko
2025-04-03 18:15 ` [Intel-wired-lan] " Linus Torvalds
2025-04-03 18:15 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-0zykUvrF-73MXI@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.