From: Stanislav Fomichev <stfomichev@gmail.com>
To: Justin Iurman <justin.iurman@uliege.be>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
kuniyu@amazon.com,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH net] net: lwtunnel: disable preemption when required
Date: Thu, 3 Apr 2025 09:24:17 -0700 [thread overview]
Message-ID: <Z-62MSCyMsqtMW1N@mini-arch> (raw)
In-Reply-To: <20250403083956.13946-1-justin.iurman@uliege.be>
On 04/03, Justin Iurman wrote:
> In lwtunnel_{input|output|xmit}(), dev_xmit_recursion() may be called in
> preemptible scope for PREEMPT kernels. This patch disables preemption
> before calling dev_xmit_recursion(). Preemption is re-enabled only at
> the end, since we must ensure the same CPU is used for both
> dev_xmit_recursion_inc() and dev_xmit_recursion_dec() (and any other
> recursion levels in some cases) in order to maintain valid per-cpu
> counters.
Dummy question: CONFIG_PREEMPT_RT uses current->net_xmit.recursion to
track the recursion. Any reason not to do it in the generic PREEMPT case?
next prev parent reply other threads:[~2025-04-03 16:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 8:39 [PATCH net] net: lwtunnel: disable preemption when required Justin Iurman
2025-04-03 16:24 ` Stanislav Fomichev [this message]
2025-04-03 19:08 ` Justin Iurman
2025-04-03 20:35 ` Alexei Starovoitov
2025-04-04 14:19 ` Sebastian Sewior
2025-04-06 8:59 ` Justin Iurman
2025-04-07 17:54 ` Alexei Starovoitov
2025-04-11 18:34 ` Justin Iurman
2025-04-14 23:13 ` Alexei Starovoitov
2025-04-15 9:25 ` Justin Iurman
2025-04-15 11:56 ` Justin Iurman
2025-04-15 0:54 ` Andrea Mayer
2025-04-15 9:10 ` Justin Iurman
2025-04-15 14:38 ` Jakub Kicinski
2025-04-15 15:12 ` Justin Iurman
2025-04-15 15:12 ` Alexei Starovoitov
2025-04-15 17:12 ` Justin Iurman
2025-04-03 23:38 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-62MSCyMsqtMW1N@mini-arch \
--to=stfomichev@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=justin.iurman@uliege.be \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.