Re: [PATCH] system/vl: Tidy up break in QEMU_OPTION_machine case

["Daniel P. Berrangé" <berrange@redhat.com>]

On Mon, Mar 24, 2025 at 12:00:06AM +0100, Philippe Mathieu-Daudé wrote:
> The break in the QEMU_OPTION_machine case is mis-placed.

I think that's largely a bikeshed colouring question. If you
look at other places in the outer switch using a block in
the case, eg

   case FOO:
      {
         .....
      }

or

   case FOO: {
         .....
   }

they'll also have 'break' inside the '{}', so either this patch
should change all, or change none.

> 
> Not a big deal, since producing the same outcome, but
> suspicious, so put it in the correct place.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  system/vl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/system/vl.c b/system/vl.c
> index ec93988a03a..dbca9ebba4d 100644
> --- a/system/vl.c
> +++ b/system/vl.c
> @@ -3409,8 +3409,8 @@ void qemu_init(int argc, char **argv)
>                          machine_help_func(machine_opts_dict);
>                          exit(EXIT_SUCCESS);
>                      }
> -                    break;
>                  }
> +                break;
>              case QEMU_OPTION_accel:
>                  accel_opts = qemu_opts_parse_noisily(qemu_find_opts("accel"),
>                                                       optarg, true);
> -- 
> 2.47.1
> 
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|