From: Jaegeuk Kim via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Daeho Jeong <daeho43@gmail.com>
Cc: Daeho Jeong <daehojeong@google.com>,
kernel-team@android.com, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: support zero sized file truncate for device aliasing files
Date: Mon, 24 Mar 2025 16:28:43 +0000 [thread overview]
Message-ID: <Z-GIOxj1reO87F6E@google.com> (raw)
In-Reply-To: <20250321213328.1170234-1-daeho43@gmail.com>
Do we still need this patch?
On 03/21, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
>
> support a file truncation to zero size for device aliasing files.
>
> Signed-off-by: Daeho Jeong <daehojeong@google.com>
> ---
> v2: make the extent length zero
> ---
> fs/f2fs/file.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index f92a9fba9991..69952f208086 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -775,6 +775,11 @@ int f2fs_do_truncate_blocks(struct inode *inode, u64 from, bool lock)
> f2fs_update_time(sbi, REQ_TIME);
>
> f2fs_put_page(ipage, 1);
> +
> + write_lock(&et->lock);
> + et->largest.len = 0;
> + write_unlock(&et->lock);
> +
> goto out;
> }
>
> @@ -1036,7 +1041,7 @@ int f2fs_setattr(struct mnt_idmap *idmap, struct dentry *dentry,
>
> if ((attr->ia_valid & ATTR_SIZE)) {
> if (!f2fs_is_compress_backend_ready(inode) ||
> - IS_DEVICE_ALIASING(inode))
> + (IS_DEVICE_ALIASING(inode) && attr->ia_size))
> return -EOPNOTSUPP;
> if (is_inode_flag_set(inode, FI_COMPRESS_RELEASED) &&
> !IS_ALIGNED(attr->ia_size,
> --
> 2.49.0.395.g12beb8f557-goog
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Daeho Jeong <daeho43@gmail.com>
Cc: linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com,
Daeho Jeong <daehojeong@google.com>
Subject: Re: [PATCH v2] f2fs: support zero sized file truncate for device aliasing files
Date: Mon, 24 Mar 2025 16:28:43 +0000 [thread overview]
Message-ID: <Z-GIOxj1reO87F6E@google.com> (raw)
In-Reply-To: <20250321213328.1170234-1-daeho43@gmail.com>
Do we still need this patch?
On 03/21, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
>
> support a file truncation to zero size for device aliasing files.
>
> Signed-off-by: Daeho Jeong <daehojeong@google.com>
> ---
> v2: make the extent length zero
> ---
> fs/f2fs/file.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index f92a9fba9991..69952f208086 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -775,6 +775,11 @@ int f2fs_do_truncate_blocks(struct inode *inode, u64 from, bool lock)
> f2fs_update_time(sbi, REQ_TIME);
>
> f2fs_put_page(ipage, 1);
> +
> + write_lock(&et->lock);
> + et->largest.len = 0;
> + write_unlock(&et->lock);
> +
> goto out;
> }
>
> @@ -1036,7 +1041,7 @@ int f2fs_setattr(struct mnt_idmap *idmap, struct dentry *dentry,
>
> if ((attr->ia_valid & ATTR_SIZE)) {
> if (!f2fs_is_compress_backend_ready(inode) ||
> - IS_DEVICE_ALIASING(inode))
> + (IS_DEVICE_ALIASING(inode) && attr->ia_size))
> return -EOPNOTSUPP;
> if (is_inode_flag_set(inode, FI_COMPRESS_RELEASED) &&
> !IS_ALIGNED(attr->ia_size,
> --
> 2.49.0.395.g12beb8f557-goog
>
next prev parent reply other threads:[~2025-03-24 16:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 21:33 [f2fs-dev] [PATCH v2] f2fs: support zero sized file truncate for device aliasing files Daeho Jeong
2025-03-21 21:33 ` Daeho Jeong
2025-03-24 16:28 ` Jaegeuk Kim via Linux-f2fs-devel [this message]
2025-03-24 16:28 ` Jaegeuk Kim
2025-03-24 16:56 ` [f2fs-dev] " Daeho Jeong
2025-03-24 16:56 ` Daeho Jeong
2025-03-25 2:19 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-03-25 2:19 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-GIOxj1reO87F6E@google.com \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=daeho43@gmail.com \
--cc=daehojeong@google.com \
--cc=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.