From: Andy Shevchenko <andy@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Dan Scally" <djrscally@gmail.com>,
"Alan Stern" <stern@rowland.harvard.edu>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Hao Yao" <hao.yao@intel.com>,
"Bingbu Cao" <bingbu.cao@intel.com>,
platform-driver-x86@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 1/8] platform/x86: int3472: Add skl_int3472_register_clock() helper
Date: Tue, 25 Mar 2025 18:43:53 +0200 [thread overview]
Message-ID: <Z-LdSYeqmAKQ3eTr@smile.fi.intel.com> (raw)
In-Reply-To: <20250325161340.342192-2-hdegoede@redhat.com>
On Tue, Mar 25, 2025 at 05:13:33PM +0100, Hans de Goede wrote:
> skl_int3472_register_dsm_clock() and skl_int3472_register_gpio_clock() are
> 80% the same code. Factor out the common code into a new
> skl_int3472_register_clock() helper.
Indeed. Good catch!
Reviewed-by: Andy Shevchenko <andy@kernel.org>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-03-25 16:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 16:13 [PATCH 0/8] platform/x86: int3472: Add handshake pin support Hans de Goede
2025-03-25 16:13 ` [PATCH 1/8] platform/x86: int3472: Add skl_int3472_register_clock() helper Hans de Goede
2025-03-25 16:43 ` Andy Shevchenko [this message]
2025-03-25 16:13 ` [PATCH 2/8] platform/x86: int3472: Stop setting a supply-name for GPIO regulators Hans de Goede
2025-03-25 16:44 ` Andy Shevchenko
2025-03-25 16:13 ` [PATCH 3/8] platform/x86: int3472: Drop unused gpio field from struct int3472_gpio_regulator Hans de Goede
2025-03-25 16:47 ` Andy Shevchenko
2025-03-25 16:13 ` [PATCH 4/8] platform/x86: int3472: Rework AVDD second sensor quirk handling Hans de Goede
2025-03-25 16:13 ` [PATCH 5/8] platform/x86: int3472: Make regulator supply name configurable Hans de Goede
2025-03-25 16:53 ` Andy Shevchenko
2025-03-25 18:08 ` Hans de Goede
2025-03-25 16:13 ` [PATCH 6/8] platform/x86: int3472: Prepare for registering more then 1 GPIO regulator Hans de Goede
2025-03-25 16:13 ` [PATCH 7/8] platform/x86: int3472: Add handshake pin support Hans de Goede
2025-03-25 16:13 ` [PATCH 8/8] platform/x86: int3472: Debug log when remapping pins Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-LdSYeqmAKQ3eTr@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=bingbu.cao@intel.com \
--cc=djrscally@gmail.com \
--cc=hao.yao@intel.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-media@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.