Re: [PATCH 5/8] platform/x86: int3472: Make regulator supply name configurable

[Andy Shevchenko <andy@kernel.org>]

On Tue, Mar 25, 2025 at 05:13:37PM +0100, Hans de Goede wrote:
> This is a preparation patch for registering multiple regulators, which
> requires a different supply-name for each regulator. Make supply-name
> a parameter to skl_int3472_register_regulator() and use con-id to set it
> so that the existing int3472_gpio_map remapping can be used with it.
> 
> Since supply-name now is a parameter, drop the fixed
> skl_int3472_regulator_map_supplies[] array and instead add lower- +
> upper-case mappings of the passed in supply-name to the regulator.

...

> +	if (strlen(supply_name) >= GPIO_SUPPPLY_NAME_LENGTH) {

Hmm... This can potentially go up to the page fault.
If we are _not_ okay with that, strnlen() should be used.

> +		dev_err(int3472->dev, "supply-name '%s' length too long\n", supply_name);

> +		return -EOVERFLOW;

This error code is for integers, we use E2BIG for the string lengths.

> +	}

-- 
With Best Regards,
Andy Shevchenko