* [PATCH v1] perf doc: Improve perf trace's doc on --force-btf option @ 2025-03-26 16:04 Howard Chu 2025-03-26 18:14 ` Namhyung Kim 0 siblings, 1 reply; 3+ messages in thread From: Howard Chu @ 2025-03-26 16:04 UTC (permalink / raw) To: acme Cc: mingo, namhyung, mark.rutland, alexander.shishkin, jolsa, irogers, adrian.hunter, peterz, kan.liang, linux-perf-users, linux-kernel, Howard Chu As mentioned by Arnaldo in a past discussion (Link: https://lore.kernel.org/linux-perf-users/Z2m0pWiQgZNXhvxK@x1/), the current documentation on --force-btf is vague and inaccurate, this patch aims to provide a clearer explanation of the option. Signed-off-by: Howard Chu <howardchu95@gmail.com> Suggested-by: Arnaldo Carvalho de Melo <acme@kernel.org> --- tools/perf/Documentation/perf-trace.txt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/perf/Documentation/perf-trace.txt b/tools/perf/Documentation/perf-trace.txt index 887dc37773d0..cf2445d2ba3d 100644 --- a/tools/perf/Documentation/perf-trace.txt +++ b/tools/perf/Documentation/perf-trace.txt @@ -246,10 +246,10 @@ the thread executes on the designated CPUs. Default is to monitor all CPUs. arguments to strings (pid to comm, syscall id to syscall name, etc). --force-btf:: - Use btf_dump to pretty print syscall argument data, instead of using hand-crafted pretty - printers. This option is intended for testing BTF integration in perf trace. btf_dump-based - pretty-printing serves as a fallback to hand-crafted pretty printers, as the latter can - better pretty-print integer flags and struct pointers. + Use libbpf's btf_dump to pretty print syscall arguments, utilizing only the debug + information from BTF. This option is intended for testing BTF integration in perf + trace. Using libbpf is a fallback to perf trace's own prettifiers generated from the + kernel source, as the latter can better pretty-print integer flags and struct members. PAGEFAULTS ---------- -- 2.45.2 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] perf doc: Improve perf trace's doc on --force-btf option 2025-03-26 16:04 [PATCH v1] perf doc: Improve perf trace's doc on --force-btf option Howard Chu @ 2025-03-26 18:14 ` Namhyung Kim 2025-03-26 18:22 ` Howard Chu 0 siblings, 1 reply; 3+ messages in thread From: Namhyung Kim @ 2025-03-26 18:14 UTC (permalink / raw) To: Howard Chu Cc: acme, mingo, mark.rutland, alexander.shishkin, jolsa, irogers, adrian.hunter, peterz, kan.liang, linux-perf-users, linux-kernel Hello, On Wed, Mar 26, 2025 at 09:04:16AM -0700, Howard Chu wrote: > As mentioned by Arnaldo in a past discussion (Link: > https://lore.kernel.org/linux-perf-users/Z2m0pWiQgZNXhvxK@x1/), the > current documentation on --force-btf is vague and inaccurate, this patch > aims to provide a clearer explanation of the option. > > Signed-off-by: Howard Chu <howardchu95@gmail.com> > Suggested-by: Arnaldo Carvalho de Melo <acme@kernel.org> > --- > tools/perf/Documentation/perf-trace.txt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/perf/Documentation/perf-trace.txt b/tools/perf/Documentation/perf-trace.txt > index 887dc37773d0..cf2445d2ba3d 100644 > --- a/tools/perf/Documentation/perf-trace.txt > +++ b/tools/perf/Documentation/perf-trace.txt > @@ -246,10 +246,10 @@ the thread executes on the designated CPUs. Default is to monitor all CPUs. > arguments to strings (pid to comm, syscall id to syscall name, etc). > > --force-btf:: > - Use btf_dump to pretty print syscall argument data, instead of using hand-crafted pretty > - printers. This option is intended for testing BTF integration in perf trace. btf_dump-based > - pretty-printing serves as a fallback to hand-crafted pretty printers, as the latter can > - better pretty-print integer flags and struct pointers. > + Use libbpf's btf_dump to pretty print syscall arguments, utilizing only the debug > + information from BTF. This option is intended for testing BTF integration in perf > + trace. Using libbpf is a fallback to perf trace's own prettifiers generated from the > + kernel source, as the latter can better pretty-print integer flags and struct members. "the latter" means our own prettifier, right? Then why do we need the fallback as it's better and always works? Thanks, Namhyung > > PAGEFAULTS > ---------- > -- > 2.45.2 > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] perf doc: Improve perf trace's doc on --force-btf option 2025-03-26 18:14 ` Namhyung Kim @ 2025-03-26 18:22 ` Howard Chu 0 siblings, 0 replies; 3+ messages in thread From: Howard Chu @ 2025-03-26 18:22 UTC (permalink / raw) To: Namhyung Kim Cc: acme, mingo, mark.rutland, alexander.shishkin, jolsa, irogers, adrian.hunter, peterz, kan.liang, linux-perf-users, linux-kernel Hello Namhyung, On Wed, Mar 26, 2025 at 11:14 AM Namhyung Kim <namhyung@kernel.org> wrote: > > Hello, > > On Wed, Mar 26, 2025 at 09:04:16AM -0700, Howard Chu wrote: > > As mentioned by Arnaldo in a past discussion (Link: > > https://lore.kernel.org/linux-perf-users/Z2m0pWiQgZNXhvxK@x1/), the > > current documentation on --force-btf is vague and inaccurate, this patch > > aims to provide a clearer explanation of the option. > > > > Signed-off-by: Howard Chu <howardchu95@gmail.com> > > Suggested-by: Arnaldo Carvalho de Melo <acme@kernel.org> > > --- > > tools/perf/Documentation/perf-trace.txt | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/tools/perf/Documentation/perf-trace.txt b/tools/perf/Documentation/perf-trace.txt > > index 887dc37773d0..cf2445d2ba3d 100644 > > --- a/tools/perf/Documentation/perf-trace.txt > > +++ b/tools/perf/Documentation/perf-trace.txt > > @@ -246,10 +246,10 @@ the thread executes on the designated CPUs. Default is to monitor all CPUs. > > arguments to strings (pid to comm, syscall id to syscall name, etc). > > > > --force-btf:: > > - Use btf_dump to pretty print syscall argument data, instead of using hand-crafted pretty > > - printers. This option is intended for testing BTF integration in perf trace. btf_dump-based > > - pretty-printing serves as a fallback to hand-crafted pretty printers, as the latter can > > - better pretty-print integer flags and struct pointers. > > + Use libbpf's btf_dump to pretty print syscall arguments, utilizing only the debug > > + information from BTF. This option is intended for testing BTF integration in perf > > + trace. Using libbpf is a fallback to perf trace's own prettifiers generated from the > > + kernel source, as the latter can better pretty-print integer flags and struct members. > > "the latter" means our own prettifier, right? Then why do we need the > fallback as it's better and always works? Honestly, for debugging—if BTF exists, it always works, yes. I don't know if libbpf is 'better' because our prettifiers are prettier :), yet there are so few of them. Thanks, Howard > > Thanks, > Namhyung > > > > > PAGEFAULTS > > ---------- > > -- > > 2.45.2 > > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-26 18:22 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-03-26 16:04 [PATCH v1] perf doc: Improve perf trace's doc on --force-btf option Howard Chu 2025-03-26 18:14 ` Namhyung Kim 2025-03-26 18:22 ` Howard Chu
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.